yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-11 00:35:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix-22668 Glossary term missing from UI in columns search (#22764)

Browse Source 
* Fix-22668 Glossary term missing from UI in columns searching

* add test

(cherry picked from commit 730b2ff07eab6c430d46790987a4d083a5815995)
This commit is contained in:
sonika-shah 2025-08-06 10:35:34 +05:30 committed by OpenMetadata Release Bot
parent b68ae69ef0
commit 9d3ccf7890
2 changed files with 68 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/TableRepository.java
View File

@ -2028,6 +2028,10 @@ public class TableRepository extends EntityRepository<Table> {
} }
} }
if (fields.contains("tags") || fields.contains("*")) {
populateEntityFieldTags(entityType, paginatedResults, table.getFullyQualifiedName(), true);
}
if (fieldsParam != null && fieldsParam.contains("profile")) { if (fieldsParam != null && fieldsParam.contains("profile")) {
setColumnProfile(matchingColumns); setColumnProfile(matchingColumns);
populateEntityFieldTags(entityType, matchingColumns, table.getFullyQualifiedName(), true); populateEntityFieldTags(entityType, matchingColumns, table.getFullyQualifiedName(), true);

66
openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/TableResourceTest.java
View File

@ -3973,7 +3973,7 @@ public class TableResourceTest extends EntityResourceTest<Table, CreateTable> {
List<Column> columns = new ArrayList<>(); List<Column> columns = new ArrayList<>();
columns.add( columns.add(
getColumn("user_id", INT, null) getColumn("user_id", INT, USER_ADDRESS_TAG_LABEL)
.withOrdinalPosition(1) .withOrdinalPosition(1)
.withDescription("Primary key for user identification")); .withDescription("Primary key for user identification"));
columns.add( columns.add(
@ -4069,13 +4069,75 @@ public class TableResourceTest extends EntityResourceTest<Table, CreateTable> {
assertEquals(0, response.getData().size()); assertEquals(0, response.getData().size());
assertEquals(0, response.getPaging().getTotal()); assertEquals(0, response.getPaging().getTotal());
// Create a custom metric for testing
CreateCustomMetric customMetric = new CreateCustomMetric();
customMetric
.withName("TestMetric")
.withDescription("Test custom metric")
.withColumnName("user_id")
.withExpression("SELECT COUNT(*) FROM test");
putCustomMetric(table.getId(), customMetric, ADMIN_AUTH_HEADERS);
// Test search with tags field
target =
getResource("tables/" + table.getId() + "/columns/search")
.queryParam("q", "user_id")
.queryParam("fields", "tags");
response = TestUtils.get(target, TableResource.TableColumnList.class, ADMIN_AUTH_HEADERS);
assertEquals(1, response.getData().size());
Column column = response.getData().getFirst();
assertEquals("user_id", column.getName());
assertNotNull(column.getTags(), "Column tags should not be null");
assertFalse(column.getTags().isEmpty(), "Column tags should not be empty");
assertEquals(1, column.getTags().size(), "Column should have exactly 1 tag");
TagLabel expectedTag = USER_ADDRESS_TAG_LABEL;
TagLabel actualTag = column.getTags().getFirst();
assertEquals(expectedTag.getTagFQN(), actualTag.getTagFQN(), "Tag FQN should match");
// Test search with customMetrics field
target =
getResource("tables/" + table.getId() + "/columns/search")
.queryParam("q", "user_id")
.queryParam("fields", "customMetrics");
response = TestUtils.get(target, TableResource.TableColumnList.class, ADMIN_AUTH_HEADERS);
assertEquals(1, response.getData().size());
column = response.getData().getFirst();
assertEquals("user_id", column.getName());
assertNotNull(column.getCustomMetrics(), "Column custom metrics should not be null");
assertFalse(column.getCustomMetrics().isEmpty(), "Column custom metrics should not be empty");
assertEquals(1, column.getCustomMetrics().size(), "Column should have exactly 1 custom metric");
CustomMetric actualMetric = column.getCustomMetrics().getFirst();
assertEquals(customMetric.getName(), actualMetric.getName(), "Custom metric name should match");
// Test search with both fields together
target = target =
getResource("tables/" + table.getId() + "/columns/search") getResource("tables/" + table.getId() + "/columns/search")
.queryParam("q", "user_id") .queryParam("q", "user_id")
.queryParam("fields", "tags,customMetrics"); .queryParam("fields", "tags,customMetrics");
response = TestUtils.get(target, TableResource.TableColumnList.class, ADMIN_AUTH_HEADERS); response = TestUtils.get(target, TableResource.TableColumnList.class, ADMIN_AUTH_HEADERS);
assertEquals(1, response.getData().size()); assertEquals(1, response.getData().size());
assertNotNull(response.getData().get(0)); // Should include requested fields column = response.getData().getFirst();
assertEquals("user_id", column.getName());
// Verify tags
assertNotNull(column.getTags(), "Column tags should not be null");
assertFalse(column.getTags().isEmpty(), "Column tags should not be empty");
assertEquals(1, column.getTags().size(), "Column should have exactly 1 tag");
actualTag = column.getTags().getFirst();
assertEquals(expectedTag.getTagFQN(), actualTag.getTagFQN(), "Tag FQN should match");
// Verify custom metrics
assertNotNull(column.getCustomMetrics(), "Column custom metrics should not be null");
assertFalse(column.getCustomMetrics().isEmpty(), "Column custom metrics should not be empty");
assertEquals(1, column.getCustomMetrics().size(), "Column should have exactly 1 custom metric");
actualMetric = column.getCustomMetrics().getFirst();
assertEquals(customMetric.getName(), actualMetric.getName(), "Custom metric name should match");
target =
getResource("tables/" + table.getId() + "/columns/search")
.queryParam("q", "user_id")
.queryParam("fields", "tags,customMetrics");
response = TestUtils.get(target, TableResource.TableColumnList.class, ADMIN_AUTH_HEADERS);
assertEquals(1, response.getData().size());
assertNotNull(response.getData().getFirst()); // Should include requested fields
final WebTarget invalidTarget = final WebTarget invalidTarget =
getResource("tables/" + table.getId() + "/columns/search") getResource("tables/" + table.getId() + "/columns/search")