From a002155845cf64d3db643b8dc34b65d79d215aae Mon Sep 17 00:00:00 2001 From: parthp2107 <83201188+parthp2107@users.noreply.github.com> Date: Wed, 15 Dec 2021 19:02:48 +0530 Subject: [PATCH] modified description related tests cases (#1772) --- .../dashboardDetails/DashboardDetailsPageTest.java | 5 ++++- .../dashboardService/DashboardServiceTestPage.java | 2 +- .../databaseService/DatabaseServicePageTest.java | 2 +- .../messagingService/MessagingServicePageTest.java | 2 +- .../pipelineDetails/PipelineDetailsPageTest.java | 5 ++++- .../pipelineService/PipelineServiceTestPage.java | 2 +- .../pages/tableDetails/TableDetailsPageTest.java | 11 +++++++---- .../catalog/selenium/pages/tags/TagsPageTest.java | 2 +- .../catalog/selenium/pages/teams/TeamsPageTest.java | 2 +- .../pages/topicDetails/TopicDetailsPageTest.java | 7 +++++-- 10 files changed, 26 insertions(+), 14 deletions(-) diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardDetails/DashboardDetailsPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardDetails/DashboardDetailsPageTest.java index a9455258570..822b7fadd48 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardDetails/DashboardDetailsPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardDetails/DashboardDetailsPageTest.java @@ -186,11 +186,14 @@ public class DashboardDetailsPageTest { Events.click(webDriver, By.cssSelector("[data-testid='data-name']")); Thread.sleep(waitTime); Events.click(webDriver, By.cssSelector("[data-testid='breadcrumb-link']")); - Events.click(webDriver, By.cssSelector("[data-testid='description-edit']")); // edit description + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); // edit description Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); Events.click(webDriver, By.cssSelector("[data-testid='save']")); for (int i = 1; i <= 3; i++) { //check topics in service Events.click(webDriver, By.xpath("(//tr[@data-testid='column']//td[1]/a)" + "[" + i + "]")); // dashboards + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); // edit description + Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); + Events.click(webDriver, By.cssSelector("[data-testid='save']")); Thread.sleep(waitTime); webDriver.navigate().back(); } diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardService/DashboardServiceTestPage.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardService/DashboardServiceTestPage.java index 1a3b2f30de1..400b10618c1 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardService/DashboardServiceTestPage.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardService/DashboardServiceTestPage.java @@ -118,7 +118,7 @@ public class DashboardServiceTestPage { Thread.sleep(2000); Events.click(webDriver, By.cssSelector("[data-testid='service-name-" + serviceName + "']")); Thread.sleep(waitTime); - Events.click(webDriver, By.cssSelector("[data-testid='description-edit']")); + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); Events.click(webDriver, By.xpath(enterDescription)); Events.sendEnter(webDriver, By.xpath(enterDescription)); Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/databaseService/DatabaseServicePageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/databaseService/DatabaseServicePageTest.java index d3153861f1c..7814bf7e2e7 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/databaseService/DatabaseServicePageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/databaseService/DatabaseServicePageTest.java @@ -120,7 +120,7 @@ public class DatabaseServicePageTest { Thread.sleep(2000); Events.click(webDriver, By.cssSelector("[data-testid='service-name-" + serviceName + "']")); Thread.sleep(waitTime); - Events.click(webDriver, By.cssSelector("[data-testid='description-edit']")); + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); Events.click(webDriver, By.xpath(enterDescription)); Events.sendEnter(webDriver, By.xpath(enterDescription)); Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/messagingService/MessagingServicePageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/messagingService/MessagingServicePageTest.java index a3dec7efe50..6d4ffef830e 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/messagingService/MessagingServicePageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/messagingService/MessagingServicePageTest.java @@ -116,7 +116,7 @@ public class MessagingServicePageTest { Thread.sleep(2000); Events.click(webDriver, By.cssSelector("[data-testid='service-name-" + serviceName + "']")); Thread.sleep(waitTime); - Events.click(webDriver, By.cssSelector("[data-testid='description-edit']")); + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); Events.click(webDriver, By.xpath(enterDescription)); Events.sendEnter(webDriver, By.xpath(enterDescription)); Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineDetails/PipelineDetailsPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineDetails/PipelineDetailsPageTest.java index fbd62331ebf..74438daad34 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineDetails/PipelineDetailsPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineDetails/PipelineDetailsPageTest.java @@ -164,11 +164,14 @@ public class PipelineDetailsPageTest { Events.click(webDriver, By.cssSelector("[data-testid='data-name'][id ='sample_airflowdim_product_etl']")); Thread.sleep(waitTime); Events.click(webDriver, By.cssSelector("[data-testid='breadcrumb-link']")); - Events.click(webDriver, By.cssSelector("[data-testid='description-edit']")); // edit description + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); // edit description Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); Events.click(webDriver, By.cssSelector("[data-testid='save']")); for (int i = 1; i <= 3; i++) { //check topics in service Events.click(webDriver, By.xpath("(//tr[@data-testid='column']//td[1]/a)" + "[" + i + "]")); // pipelines + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); // edit description + Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); + Events.click(webDriver, By.cssSelector("[data-testid='save']")); Thread.sleep(waitTime); webDriver.navigate().back(); } diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineService/PipelineServiceTestPage.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineService/PipelineServiceTestPage.java index 1cc2811b946..a4276aedc63 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineService/PipelineServiceTestPage.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineService/PipelineServiceTestPage.java @@ -115,7 +115,7 @@ public class PipelineServiceTestPage { Thread.sleep(2000); Events.click(webDriver, By.cssSelector("[data-testid='service-name-" + serviceName + "']")); Thread.sleep(waitTime); - Events.click(webDriver, By.cssSelector("[data-testid='description-edit']")); + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); Events.click(webDriver, By.xpath(enterDescription)); Events.sendEnter(webDriver, By.xpath(enterDescription)); Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java index 28414df55f3..87c42a949b1 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java @@ -206,16 +206,19 @@ public class TableDetailsPageTest { openExplorePage(); Events.click(webDriver, By.xpath("(//a[@data-testid='table-link'])[last()]")); Events.click(webDriver, By.cssSelector("[data-testid='breadcrumb-link']")); - Events.click(webDriver, By.cssSelector("[data-testid='description-edit']")); // edit description + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); // edit description Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); Events.click(webDriver, By.cssSelector("[data-testid='save']")); Events.click(webDriver, By.xpath("(//tr[@data-testid='column']//td[1]/a)[1]")); // database -// Events.click(webDriver, By.cssSelector("[data-testid='description-edit-button']")); // edit description -// Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); -// Events.click(webDriver, By.cssSelector("[data-testid='save']")); + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); // edit description + Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); + Events.click(webDriver, By.cssSelector("[data-testid='save']")); for (int i = 1; i <= 3; i++) { //check topics in service Events.click( webDriver, By.xpath("(//tr[@data-testid='tabale-column']//td[1]/a)" + "[" + i + "]")); // tables + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); // edit description + Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); + Events.click(webDriver, By.cssSelector("[data-testid='save']")); Thread.sleep(waitTime); webDriver.navigate().back(); } diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tags/TagsPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tags/TagsPageTest.java index 62f37ae77b7..ae22c0dc327 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tags/TagsPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tags/TagsPageTest.java @@ -94,7 +94,7 @@ public class TagsPageTest { public void editTagCategoryDescription() throws InterruptedException { openTagsPage(); Events.click(webDriver, By.xpath("//*[text()[contains(.,'" + tagCategoryDisplayName + "')]] ")); - Events.click(webDriver, By.cssSelector("[data-testid='add-description']")); + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); wait.until(ExpectedConditions.presenceOfElementLocated(By.xpath(enterDescription))); Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); Events.click(webDriver, By.cssSelector("[data-testid='save']")); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/teams/TeamsPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/teams/TeamsPageTest.java index bdc20569ada..5819f3c5300 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/teams/TeamsPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/teams/TeamsPageTest.java @@ -103,7 +103,7 @@ public class TeamsPageTest { openTeamsPage(); Events.click(webDriver, By.xpath("//*[text()[contains(.,'" + teamDisplayName + "')]] ")); // Select the created listed team - Events.click(webDriver, By.cssSelector("[data-testid='add-description']")); + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); wait.until(ExpectedConditions.elementToBeClickable( By.xpath(enterDescription))); Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/topicDetails/TopicDetailsPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/topicDetails/TopicDetailsPageTest.java index cae33670c5c..7212122d4af 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/topicDetails/TopicDetailsPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/topicDetails/TopicDetailsPageTest.java @@ -164,12 +164,15 @@ public class TopicDetailsPageTest { Events.click(webDriver, By.xpath("(//a[@data-testid='table-link'])[last()]")); wait.until(ExpectedConditions.elementToBeClickable(By.cssSelector("[data-testid='breadcrumb-link']"))); Events.click(webDriver, By.cssSelector("[data-testid='breadcrumb-link']")); - wait.until(ExpectedConditions.elementToBeClickable(By.cssSelector("[data-testid='description-edit']"))); - Events.click(webDriver, By.cssSelector("[data-testid='description-edit']")); // edit description + wait.until(ExpectedConditions.elementToBeClickable(By.cssSelector("[data-testid='edit-description']"))); + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); // edit description Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); Events.click(webDriver, By.cssSelector("[data-testid='save']")); for (int i = 1; i <= 3; i++) { //check topics in service Events.click(webDriver, By.xpath("(//tr[@data-testid='column']//td[1]/a)" + "[" + i + "]")); // topics + Events.click(webDriver, By.cssSelector("[data-testid='edit-description']")); // edit description + Events.sendKeys(webDriver, By.xpath(enterDescription), faker.address().toString()); + Events.click(webDriver, By.cssSelector("[data-testid='save']")); Thread.sleep(waitTime); webDriver.navigate().back(); }