diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedList/ActivityFeedList.tsx b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedList/ActivityFeedList.tsx index f9220806c90..902854c17a3 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedList/ActivityFeedList.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedList/ActivityFeedList.tsx @@ -13,7 +13,7 @@ import { Button, Col, Row, Typography } from 'antd'; import classNames from 'classnames'; -import { ERROR_PLACEHOLDER_TYPE } from 'enums/common.enum'; +import { ERROR_PLACEHOLDER_TYPE, SIZE } from 'enums/common.enum'; import { isUndefined } from 'lodash'; import React, { FC, useCallback, useEffect, useMemo, useState } from 'react'; import { useTranslation } from 'react-i18next'; @@ -310,7 +310,11 @@ const ActivityFeedList: FC = ({ {entityName && feedFilter === FeedFilter.ALL && !threadType ? ( ) : !refreshFeedCount ? ( - + ) : null} ) diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ContainerVersion/ContainerVersion.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/ContainerVersion/ContainerVersion.component.tsx index 38d7b12896c..b616d33cad0 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ContainerVersion/ContainerVersion.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/ContainerVersion/ContainerVersion.component.tsx @@ -10,8 +10,11 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + +import { Card } from 'antd'; import classNames from 'classnames'; -import PageContainer from 'components/containers/PageContainer'; +import PageContainerV1 from 'components/containers/PageContainerV1'; +import PageLayoutV1 from 'components/containers/PageLayoutV1'; import { ChangeDescription, Column, @@ -384,11 +387,11 @@ const ContainerVersion: React.FC = ({ }, [currentVersionData]); return ( - -
+ + {isVersionLoading ? ( ) : ( @@ -408,7 +411,7 @@ const ContainerVersion: React.FC = ({ />
-
+
= ({ />
-
+
)} @@ -441,8 +444,8 @@ const ContainerVersion: React.FC = ({ versionList={versionList} onBack={backHandler} /> - -
+ + ); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DashboardDetails/DashboardDetails.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DashboardDetails/DashboardDetails.component.tsx index 71894a3f6f8..14b9cbb2a88 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DashboardDetails/DashboardDetails.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DashboardDetails/DashboardDetails.component.tsx @@ -859,19 +859,18 @@ const DashboardDetails = ({ )} {activeTab === 4 && ( - - - + )}
= ({ ); return ( - -
- {isVersionLoading ? ( - - ) : ( -
- -
- -
-
-
- + + +
+ {isVersionLoading ? ( + + ) : ( +
+ +
+ + +
+
+ +
+
+ + -
-
- - + - - )} + )} - - - + + + + ); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DashboardVersion/DashboardVersion.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DashboardVersion/DashboardVersion.test.tsx index cc2b01f1fa7..d3862f23b69 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DashboardVersion/DashboardVersion.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DashboardVersion/DashboardVersion.test.tsx @@ -12,7 +12,7 @@ */ import { findByTestId, findByText, render } from '@testing-library/react'; -import React from 'react'; +import React, { ReactNode } from 'react'; import { MemoryRouter } from 'react-router-dom'; import DashboardVersion from './DashboardVersion.component'; import { DashboardVersionProp } from './DashboardVersion.interface'; @@ -65,6 +65,22 @@ jest.mock('../../utils/EntityVersionUtils', () => ({ getTagsDiff: jest.fn(), })); +jest.mock('components/containers/PageContainerV1', () => { + return jest + .fn() + .mockImplementation(({ children }: { children: ReactNode }) => ( +
{children}
+ )); +}); + +jest.mock('components/containers/PageLayoutV1', () => { + return jest + .fn() + .mockImplementation(({ children }: { children: ReactNode }) => ( +
{children}
+ )); +}); + JSON.parse = jest.fn().mockReturnValue([]); describe('Test DashboardVersion page', () => { diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataModelVersion/DataModelVersion.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DataModelVersion/DataModelVersion.component.tsx index ee6c2e9b652..5a8369dd766 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DataModelVersion/DataModelVersion.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DataModelVersion/DataModelVersion.component.tsx @@ -11,11 +11,12 @@ * limitations under the License. */ -import { Table, Typography } from 'antd'; +import { Card, Table, Typography } from 'antd'; import { ColumnsType } from 'antd/lib/table'; import classNames from 'classnames'; import RichTextEditorPreviewer from 'components/common/rich-text-editor/RichTextEditorPreviewer'; -import PageContainer from 'components/containers/PageContainer'; +import PageContainerV1 from 'components/containers/PageContainerV1'; +import PageLayoutV1 from 'components/containers/PageLayoutV1'; import TagsViewer from 'components/Tag/TagsViewer/tags-viewer'; import { ChangeDescription, @@ -248,71 +249,78 @@ const DataModelVersion: FC = ({ ); return ( - -
- {isVersionLoading ? ( - - ) : ( -
- -
- -
-
-
- + + +
+ {isVersionLoading ? ( + + ) : ( +
+ +
+ + +
+
+ +
+
+
+ -
-
- - + - - )} + )} - - - + + + + ); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx index ae1c1b228ee..e796b24a5d9 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx @@ -796,12 +796,10 @@ const DatasetDetails: React.FC = ({ )} {activeTab === 3 && ( - - - + )} {activeTab === 4 && ( = ({ )} {activeTab === 9 && ( - - - + )} diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DatasetVersion/DatasetVersion.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DatasetVersion/DatasetVersion.component.tsx index 96eaf57f5eb..35ccbd54b4b 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DatasetVersion/DatasetVersion.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DatasetVersion/DatasetVersion.component.tsx @@ -11,12 +11,15 @@ * limitations under the License. */ +import { Card } from 'antd'; import classNames from 'classnames'; -import PageContainer from 'components/containers/PageContainer'; +import PageContainerV1 from 'components/containers/PageContainerV1'; +import PageLayoutV1 from 'components/containers/PageLayoutV1'; import { cloneDeep, isEqual, isUndefined, toString } from 'lodash'; import { ExtraInfo } from 'Models'; import React, { useEffect, useState } from 'react'; import { useTranslation } from 'react-i18next'; +import { getEntityName } from 'utils/EntityUtils'; import { FQN_SEPARATOR_CHAR } from '../../constants/char.constants'; import { EntityField } from '../../constants/Feeds.constants'; import { FqnPart } from '../../enums/entity.enum'; @@ -375,11 +378,11 @@ const DatasetVersion: React.FC = ({ }, [currentVersionData]); return ( - -
+ + {isVersionLoading ? ( ) : ( @@ -399,7 +402,7 @@ const DatasetVersion: React.FC = ({ />
-
+
= ({ />
-
+
)} @@ -434,8 +437,8 @@ const DatasetVersion: React.FC = ({ versionList={versionList} onBack={backHandler} /> - -
+ + ); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx index d3976cd05a7..9607fd96c88 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx @@ -439,7 +439,7 @@ const EntityTable = ({ {hasDescriptionEditAccess && ( <> - ) : null} - {scrollHandle.right ? ( - - ) : null} + return sampleData?.rows?.length && sampleData?.columns?.length ? ( + +
{ + setScrollOffSet(tableRef.current?.scrollLeft ?? 0); + }}> + {scrollHandle.left ? ( + + ) : null} + {scrollHandle.right ? ( + + ) : null} - {sampleData?.rows?.length && sampleData?.columns?.length ? (
@@ -224,27 +224,27 @@ const SampleDataTable: FunctionComponent = ({
- ) : ( - - - - } - values={{ - entity: t('label.profiler-ingestion'), - }} +
+
+ ) : ( + + + - - - )} -
+ } + values={{ + entity: t('label.profiler-ingestion'), + }} + /> + + ); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/TableTags/TableTags.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/TableTags/TableTags.component.tsx index a26d6ea02f9..e92e63f5d5b 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/TableTags/TableTags.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/TableTags/TableTags.component.tsx @@ -160,7 +160,7 @@ const TableTags = ({
{tags[type].length && hasTagEditAccess ? (
- + + ); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/VersionTable/VersionTable.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/VersionTable/VersionTable.component.tsx index 82bf7b080ac..9a294774b1e 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/VersionTable/VersionTable.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/VersionTable/VersionTable.component.tsx @@ -12,6 +12,7 @@ */ import { Col, Row, Table } from 'antd'; +import FilterTablePlaceHolder from 'components/common/error-with-placeholder/FilterTablePlaceHolder'; import { NO_DATA_PLACEHOLDER } from 'constants/constants'; import React, { useEffect, useMemo, useState } from 'react'; import { useTranslation } from 'react-i18next'; @@ -140,6 +141,7 @@ const VersionTable = ({ columnName, columns, joins }: VersionTableProps) => { { ...getTableExpandableConfig(), defaultExpandedRowKeys: [], }} + locale={{ + emptyText: , + }} pagination={false} rowKey="name" scroll={{ x: 1200 }} diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.interface.ts b/openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.interface.ts index c0dd362d30b..fff94b3abfd 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.interface.ts +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.interface.ts @@ -31,4 +31,5 @@ export interface CustomPropertyProps { entityType: EntityType; handleExtensionUpdate: (updatedTable: EntityDetails) => Promise; hasEditAccess: boolean; + className?: string; } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.tsx index 26bf3daa2db..5a0838c400f 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.tsx @@ -11,7 +11,7 @@ * limitations under the License. */ -import { Table, Typography } from 'antd'; +import { Card, Table, Typography } from 'antd'; import { ColumnsType } from 'antd/lib/table'; import { AxiosError } from 'axios'; import Loader from 'components/Loader/Loader'; @@ -31,6 +31,7 @@ export const CustomPropertyTable: FC = ({ handleExtensionUpdate, entityType, hasEditAccess, + className, }) => { const { t } = useTranslation(); const [entityTypeDetail, setEntityTypeDetail] = useState({} as Type); @@ -97,7 +98,7 @@ export const CustomPropertyTable: FC = ({ return ( <> {isEmpty(entityTypeDetail.customProperties) ? ( - + {t('message.adding-new-entity-is-easy-just-give-it-a-spin', { entity: t('label.custom-property-plural'), @@ -105,15 +106,17 @@ export const CustomPropertyTable: FC = ({ ) : ( -
+ +
+ )} ); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/description/Description.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/description/Description.tsx index 283d62e7cd6..661b023ed8a 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/description/Description.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/description/Description.tsx @@ -181,7 +181,7 @@ const Description: FC = ({ {hasEditAccess && ( + { {t('label.custom-property-plural')} }> - - - + diff --git a/openmetadata-ui/src/main/resources/ui/src/styles/app.less b/openmetadata-ui/src/main/resources/ui/src/styles/app.less index 30b3657dacb..9cb00467463 100644 --- a/openmetadata-ui/src/main/resources/ui/src/styles/app.less +++ b/openmetadata-ui/src/main/resources/ui/src/styles/app.less @@ -61,6 +61,9 @@ // text color .text-primary { color: @primary; + &:hover { + color: @primary; + } } .error-text { color: #ff4c3b; diff --git a/openmetadata-ui/src/main/resources/ui/src/styles/spacing.less b/openmetadata-ui/src/main/resources/ui/src/styles/spacing.less index da58c2f73e3..dd2262b46e2 100644 --- a/openmetadata-ui/src/main/resources/ui/src/styles/spacing.less +++ b/openmetadata-ui/src/main/resources/ui/src/styles/spacing.less @@ -322,6 +322,10 @@ padding-left: 0px; } +.pt-8 { + padding-top: 2rem; +} + .padding-r-l-l { padding: 0 @padding-lg; }