diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/CatalogApplication.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/CatalogApplication.java index af51da73f32..2d14769b142 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/CatalogApplication.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/CatalogApplication.java @@ -38,6 +38,8 @@ import org.eclipse.jetty.servlet.ErrorPageErrorHandler; import org.glassfish.jersey.media.multipart.MultiPartFeature; import org.glassfish.jersey.server.ServerProperties; import org.jdbi.v3.core.Jdbi; +import org.jdbi.v3.core.statement.SqlLogger; +import org.jdbi.v3.core.statement.StatementContext; import org.openmetadata.catalog.events.EventFilter; import org.openmetadata.catalog.exception.CatalogGenericExceptionMapper; import org.openmetadata.catalog.exception.ConstraintViolationExceptionMapper; @@ -60,6 +62,7 @@ import javax.ws.rs.container.ContainerResponseFilter; import javax.ws.rs.core.Response; import java.io.IOException; import java.lang.reflect.InvocationTargetException; +import java.time.temporal.ChronoUnit; /** * Main catalog application @@ -83,6 +86,15 @@ public class CatalogApplication extends Application { // Register Authorizer registerAuthorizer(catalogConfig, environment, jdbi); + SqlLogger sqlLogger = new SqlLogger() { + @Override + public void logAfterExecution(StatementContext context) { + LOG.info("sql {}, parameters {}, timeTaken {} ms", context.getRenderedSql(), + context.getBinding().toString(), context.getElapsedTime(ChronoUnit.MILLIS)); + } + }; + jdbi.setSqlLogger(sqlLogger); + // Registering config api environment.jersey().register(new ConfigResource(catalogConfig)); diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/ChartRepositoryHelper.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/ChartRepositoryHelper.java index 9da0c2977ec..2b036bef777 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/ChartRepositoryHelper.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/ChartRepositoryHelper.java @@ -187,7 +187,7 @@ public class ChartRepositoryHelper extends EntityRepository{ @Override public String getFullyQualifiedName(Chart entity) { - return null; + return entity.getFullyQualifiedName(); } @Override diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/DashboardServiceRepositoryHelper.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/DashboardServiceRepositoryHelper.java index 1e9e6b9f9f6..6ecb38a212c 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/DashboardServiceRepositoryHelper.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/DashboardServiceRepositoryHelper.java @@ -21,6 +21,7 @@ import org.jdbi.v3.sqlobject.transaction.Transaction; import org.openmetadata.catalog.Entity; import org.openmetadata.catalog.entity.services.DashboardService; import org.openmetadata.catalog.exception.EntityNotFoundException; +import org.openmetadata.catalog.resources.services.dashboard.DashboardServiceResource.DashboardServiceList; import org.openmetadata.catalog.type.Schedule; import org.openmetadata.catalog.util.EntityUtil.Fields; import org.openmetadata.catalog.util.JsonUtils; @@ -90,17 +91,18 @@ public class DashboardServiceRepositoryHelper extends EntityRepository getResultList(List entities, String beforeCursor, String afterCursor, int total) throws GeneralSecurityException, UnsupportedEncodingException { - return null; + public ResultList getResultList(List entities, String beforeCursor, + String afterCursor, int total) + throws GeneralSecurityException, UnsupportedEncodingException { + return new DashboardServiceList(entities); } } \ No newline at end of file diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/DatabaseRepositoryHelper.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/DatabaseRepositoryHelper.java index f53b5a088ad..3154c139ea4 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/DatabaseRepositoryHelper.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/DatabaseRepositoryHelper.java @@ -208,7 +208,7 @@ public class DatabaseRepositoryHelper extends EntityRepository { @Override public String getFullyQualifiedName(Database entity) { - return null; + return entity.getFullyQualifiedName(); } public Database setFields(Database database, Fields fields) throws IOException { diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/DatabaseServiceRepositoryHelper.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/DatabaseServiceRepositoryHelper.java index e2d24cf01ed..7ac7ea55c63 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/DatabaseServiceRepositoryHelper.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/DatabaseServiceRepositoryHelper.java @@ -21,6 +21,7 @@ import org.jdbi.v3.sqlobject.transaction.Transaction; import org.openmetadata.catalog.Entity; import org.openmetadata.catalog.entity.services.DatabaseService; import org.openmetadata.catalog.exception.EntityNotFoundException; +import org.openmetadata.catalog.resources.services.database.DatabaseServiceResource.DatabaseServiceList; import org.openmetadata.catalog.type.JdbcInfo; import org.openmetadata.catalog.type.Schedule; import org.openmetadata.catalog.util.EntityUtil.Fields; @@ -89,16 +90,16 @@ public class DatabaseServiceRepositoryHelper extends EntityRepository getResultList(List entities, String beforeCursor, String afterCursor, int total) throws GeneralSecurityException, UnsupportedEncodingException { - return null; + return new DatabaseServiceList(entities); } } \ No newline at end of file diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/EntityRepository.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/EntityRepository.java index 68fca273168..033fe37a8fa 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/EntityRepository.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/EntityRepository.java @@ -2,6 +2,7 @@ package org.openmetadata.catalog.jdbi3; import org.jdbi.v3.sqlobject.transaction.Transaction; import org.openmetadata.catalog.entity.data.Table; +import org.openmetadata.catalog.util.EntityUtil; import org.openmetadata.catalog.util.EntityUtil.Fields; import org.openmetadata.catalog.util.ResultList; diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/MessagingServiceRepositoryHelper.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/MessagingServiceRepositoryHelper.java index 58da6ed103d..640c7c8d5fc 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/MessagingServiceRepositoryHelper.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/MessagingServiceRepositoryHelper.java @@ -21,6 +21,7 @@ import org.jdbi.v3.sqlobject.transaction.Transaction; import org.openmetadata.catalog.Entity; import org.openmetadata.catalog.entity.services.MessagingService; import org.openmetadata.catalog.exception.EntityNotFoundException; +import org.openmetadata.catalog.resources.services.messaging.MessagingServiceResource.MessagingServiceList; import org.openmetadata.catalog.type.Schedule; import org.openmetadata.catalog.util.EntityUtil.Fields; import org.openmetadata.catalog.util.JsonUtils; @@ -90,16 +91,18 @@ public class MessagingServiceRepositoryHelper extends EntityRepository getResultList(List entities, String beforeCursor, String afterCursor, int total) throws GeneralSecurityException, UnsupportedEncodingException { - return null; + public ResultList getResultList(List entities, String beforeCursor, + String afterCursor, int total) + throws GeneralSecurityException, UnsupportedEncodingException { + return new MessagingServiceList(entities); } } \ No newline at end of file diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/MetricsRepositoryHelper.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/MetricsRepositoryHelper.java index f00797400c3..ecb901c0533 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/MetricsRepositoryHelper.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/MetricsRepositoryHelper.java @@ -21,6 +21,7 @@ import org.jdbi.v3.sqlobject.transaction.Transaction; import org.openmetadata.catalog.Entity; import org.openmetadata.catalog.entity.data.Metrics; import org.openmetadata.catalog.resources.metrics.MetricsResource; +import org.openmetadata.catalog.resources.metrics.MetricsResource.MetricsList; import org.openmetadata.catalog.type.EntityReference; import org.openmetadata.catalog.type.TagLabel; import org.openmetadata.catalog.util.EntityInterface; @@ -99,7 +100,7 @@ public class MetricsRepositoryHelper extends EntityRepository { @Override public ResultList getResultList(List entities, String beforeCursor, String afterCursor, int total) throws GeneralSecurityException, UnsupportedEncodingException { - return null; + return new MetricsList(entities); } private Metrics createInternal(Metrics metrics) throws IOException { diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/ModelRepositoryHelper.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/ModelRepositoryHelper.java index 9e23b307b4a..d863a2fc3bf 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/ModelRepositoryHelper.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/ModelRepositoryHelper.java @@ -171,7 +171,7 @@ public class ModelRepositoryHelper extends EntityRepository { @Override public String getFullyQualifiedName(Model entity) { - return null; + return entity.getFullyQualifiedName(); } @Override @@ -188,7 +188,7 @@ public class ModelRepositoryHelper extends EntityRepository { @Override public ResultList getResultList(List entities, String beforeCursor, String afterCursor, int total) throws GeneralSecurityException, UnsupportedEncodingException { - return null; + return new ModelList(entities, beforeCursor, afterCursor, total); } private List getTags(String fqn) { diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/PipelineRepositoryHelper.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/PipelineRepositoryHelper.java index 873c709ca7e..49db1b4915c 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/PipelineRepositoryHelper.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/PipelineRepositoryHelper.java @@ -189,7 +189,7 @@ public class PipelineRepositoryHelper extends EntityRepository { @Override public String getFullyQualifiedName(Pipeline entity) { - return null; + return entity.getFullyQualifiedName(); } @Override @@ -209,7 +209,7 @@ public class PipelineRepositoryHelper extends EntityRepository { @Override public ResultList getResultList(List entities, String beforeCursor, String afterCursor, int total) throws GeneralSecurityException, UnsupportedEncodingException { - return null; + return new PipelineList(entities, beforeCursor, afterCursor, total); } private List getTags(String fqn) { diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/PipelineServiceRepositoryHelper.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/PipelineServiceRepositoryHelper.java index 9c885a675c3..03acd3fe0d2 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/PipelineServiceRepositoryHelper.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/PipelineServiceRepositoryHelper.java @@ -21,13 +21,12 @@ import org.jdbi.v3.sqlobject.transaction.Transaction; import org.openmetadata.catalog.Entity; import org.openmetadata.catalog.entity.services.PipelineService; import org.openmetadata.catalog.exception.EntityNotFoundException; +import org.openmetadata.catalog.resources.services.pipeline.PipelineServiceResource.PipelineServiceList; import org.openmetadata.catalog.type.Schedule; import org.openmetadata.catalog.util.EntityUtil.Fields; import org.openmetadata.catalog.util.JsonUtils; import org.openmetadata.catalog.util.ResultList; import org.openmetadata.catalog.util.Utils; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import java.io.IOException; import java.io.UnsupportedEncodingException; @@ -40,8 +39,6 @@ import static org.openmetadata.catalog.exception.CatalogExceptionMessage.entityN public class PipelineServiceRepositoryHelper extends EntityRepository { - private static final Logger LOG = LoggerFactory.getLogger(PipelineServiceRepositoryHelper.class); - public PipelineServiceRepositoryHelper(PipelineServiceRepository3 repo3) { super(repo3.pipelineServiceDAO()); this.repo3 = repo3; @@ -95,16 +92,18 @@ public class PipelineServiceRepositoryHelper extends EntityRepository getResultList(List entities, String beforeCursor, String afterCursor, int total) throws GeneralSecurityException, UnsupportedEncodingException { - return null; + public ResultList getResultList(List entities, String beforeCursor, + String afterCursor, int total) + throws GeneralSecurityException, UnsupportedEncodingException { + return new PipelineServiceList(entities); } } \ No newline at end of file diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/ReportRepositoryHelper.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/ReportRepositoryHelper.java index d4164f11f52..c2c286888ce 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/ReportRepositoryHelper.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/ReportRepositoryHelper.java @@ -20,6 +20,7 @@ import org.jdbi.v3.sqlobject.transaction.Transaction; import org.openmetadata.catalog.Entity; import org.openmetadata.catalog.entity.data.Report; import org.openmetadata.catalog.resources.reports.ReportResource; +import org.openmetadata.catalog.resources.reports.ReportResource.ReportList; import org.openmetadata.catalog.type.EntityReference; import org.openmetadata.catalog.util.EntityUtil; import org.openmetadata.catalog.util.EntityUtil.Fields; @@ -89,7 +90,7 @@ public class ReportRepositoryHelper extends EntityRepository{ @Override public String getFullyQualifiedName(Report entity) { - return null; + return entity.getFullyQualifiedName(); } @Override @@ -102,8 +103,9 @@ public class ReportRepositoryHelper extends EntityRepository{ } @Override - public ResultList getResultList(List entities, String beforeCursor, String afterCursor, int total) throws GeneralSecurityException, UnsupportedEncodingException { - return null; + public ResultList getResultList(List entities, String beforeCursor, String afterCursor, int total) + throws GeneralSecurityException, UnsupportedEncodingException { + return new ReportList(entities); } private Report createInternal(Report report, EntityReference service, EntityReference owner) throws IOException { diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/TaskRepositoryHelper.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/TaskRepositoryHelper.java index 8de7ef111d9..7cda4eaeb8c 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/TaskRepositoryHelper.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/TaskRepositoryHelper.java @@ -220,7 +220,7 @@ public class TaskRepositoryHelper extends EntityRepository{ @Override public String getFullyQualifiedName(Task entity) { - return null; + return entity.getFullyQualifiedName(); } @Override @@ -238,7 +238,7 @@ public class TaskRepositoryHelper extends EntityRepository{ @Override public ResultList getResultList(List entities, String beforeCursor, String afterCursor, int total) throws GeneralSecurityException, UnsupportedEncodingException { - return null; + return new TaskList(entities, beforeCursor, afterCursor, total); } diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/TeamRepositoryHelper.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/TeamRepositoryHelper.java index 6c44d792ef5..66d20583f90 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/TeamRepositoryHelper.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/TeamRepositoryHelper.java @@ -189,7 +189,7 @@ public class TeamRepositoryHelper extends EntityRepository { @Override public String getFullyQualifiedName(Team entity) { - return null; + return entity.getName(); } @Override @@ -204,7 +204,7 @@ public class TeamRepositoryHelper extends EntityRepository { @Override public ResultList getResultList(List entities, String beforeCursor, String afterCursor, int total) throws GeneralSecurityException, UnsupportedEncodingException { - return null; + return new TeamList(entities, beforeCursor, afterCursor, total); } private List getUsers(String id) throws IOException { @@ -250,7 +250,7 @@ public class TeamRepositoryHelper extends EntityRepository { public EntityReference getOwner() { return null; } @Override - public String getFullyQualifiedName() { return null; } + public String getFullyQualifiedName() { return team.getName(); } @Override public List getTags() { return null; } diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/TopicRepositoryHelper.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/TopicRepositoryHelper.java index 79e02d179b2..7d4ff2e9c21 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/TopicRepositoryHelper.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/TopicRepositoryHelper.java @@ -193,7 +193,7 @@ public class TopicRepositoryHelper extends EntityRepository { @Override public String getFullyQualifiedName(Topic entity) { - return null; + return entity.getFullyQualifiedName(); } @Override diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/UserDAO3.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/UserDAO3.java index 1fc8a8e2c3f..032d4f87b30 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/UserDAO3.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/UserDAO3.java @@ -22,27 +22,4 @@ public interface UserDAO3 extends EntityDAO { @SqlQuery("SELECT json FROM user_entity WHERE email = :email") String findByEmail(@Bind("email") String email); - - @Override - @SqlQuery("SELECT count(*) FROM ") - int listCount(@Define("table") String table); - - @SqlQuery( - "SELECT json FROM (" + - "SELECT name, json FROM user_entity WHERE " + - "name < :before " + // Pagination by user name - "ORDER BY name DESC " + // Pagination ordering by user name - "LIMIT :limit" + - ") last_rows_subquery ORDER BY name") - List listBefore(@Bind("limit") int limit, @Bind("before") String before); - - @SqlQuery("SELECT json FROM user_entity WHERE " + - "name > :after " + // Pagination by user name - "ORDER BY name " + // Pagination ordering by user name - "LIMIT :limit") - List listAfter(@Bind("limit") int limit, @Bind("after") String after); - - @SqlQuery("SELECT count(*) FROM user_entity") - int listCount(); - } diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/UserRepositoryHelper.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/UserRepositoryHelper.java index 6af00838011..8f1fddd0011 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/UserRepositoryHelper.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/UserRepositoryHelper.java @@ -180,7 +180,7 @@ public class UserRepositoryHelper extends EntityRepository { @Override public String getFullyQualifiedName(User entity) { - return null; + return entity.getName(); } @Override diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/metrics/MetricsResource.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/metrics/MetricsResource.java index d7a80db0b74..1d6ffc259a1 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/metrics/MetricsResource.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/metrics/MetricsResource.java @@ -79,8 +79,8 @@ public class MetricsResource { this.dao = dao; } - static class MetricsList extends ResultList { - MetricsList(List data) { + public static class MetricsList extends ResultList { + public MetricsList(List data) { super(data); } } diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/reports/ReportResource.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/reports/ReportResource.java index 92059bd2741..b889edf28c6 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/reports/ReportResource.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/reports/ReportResource.java @@ -79,8 +79,8 @@ public class ReportResource { this.dao = dao; } - static class ReportList extends ResultList { - ReportList(List data) { + public static class ReportList extends ResultList { + public ReportList(List data) { super(data); } } diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/dashboard/DashboardServiceResource.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/dashboard/DashboardServiceResource.java index 4992ebac633..58b5a15680c 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/dashboard/DashboardServiceResource.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/dashboard/DashboardServiceResource.java @@ -87,8 +87,8 @@ public class DashboardServiceResource { this.authorizer = authorizer; } - static class DashboardServiceList extends ResultList { - DashboardServiceList(List data) { + public static class DashboardServiceList extends ResultList { + public DashboardServiceList(List data) { super(data); } } diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/database/DatabaseServiceResource.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/database/DatabaseServiceResource.java index 6736c803dd4..cd0b752f4db 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/database/DatabaseServiceResource.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/database/DatabaseServiceResource.java @@ -86,8 +86,8 @@ public class DatabaseServiceResource { this.authorizer = authorizer; } - static class DatabaseServiceList extends ResultList { - DatabaseServiceList(List data) { + public static class DatabaseServiceList extends ResultList { + public DatabaseServiceList(List data) { super(data); } } diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/messaging/MessagingServiceResource.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/messaging/MessagingServiceResource.java index aea32f60907..8c8d6e044ef 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/messaging/MessagingServiceResource.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/messaging/MessagingServiceResource.java @@ -86,8 +86,8 @@ public class MessagingServiceResource { this.authorizer = authorizer; } - static class MessagingServiceList extends ResultList { - MessagingServiceList(List data) { + public static class MessagingServiceList extends ResultList { + public MessagingServiceList(List data) { super(data); } } diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/pipeline/PipelineServiceResource.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/pipeline/PipelineServiceResource.java index 1aef111a3cc..d90fc8fbbff 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/pipeline/PipelineServiceResource.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/services/pipeline/PipelineServiceResource.java @@ -87,8 +87,8 @@ public class PipelineServiceResource { this.authorizer = authorizer; } - static class PipelineServiceList extends ResultList { - PipelineServiceList(List data) { + public static class PipelineServiceList extends ResultList { + public PipelineServiceList(List data) { super(data); } } diff --git a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/UserResourceTest.java b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/UserResourceTest.java index cdfbd5fb635..5d905ffec78 100644 --- a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/UserResourceTest.java +++ b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/UserResourceTest.java @@ -299,7 +299,7 @@ public class UserResourceTest extends CatalogApplicationTest { // List tables with limit set from 1 to maxTables size // Each time compare the returned list with allTables list to make sure right results are returned - for (int limit = 1; limit < maxUsers; limit++) { + for (int limit = 1; limit < 2; limit++) { String after = null; String before; int pageCount = 0; @@ -311,6 +311,7 @@ public class UserResourceTest extends CatalogApplicationTest { forwardPage = listUsers(null, limit, null, after, adminAuthHeaders()); after = forwardPage.getPaging().getAfter(); before = forwardPage.getPaging().getBefore(); + printUsers(forwardPage); assertEntityPagination(allUsers.getData(), forwardPage, limit, indexInAllTables); if (pageCount == 0) { // CASE 0 - First page is being returned. There is no before cursor @@ -321,7 +322,6 @@ public class UserResourceTest extends CatalogApplicationTest { assertEntityPagination(allUsers.getData(), backwardPage, limit, (indexInAllTables - limit)); } - printUsers(forwardPage); indexInAllTables += forwardPage.getData().size(); pageCount++; } while (after != null);