Fix #1299: Move UI module into its own maven module (#1351)

* Fix #1299: Move UI module into its own maven module

* Fix #1299: fix indentation in selenium tests

* Fix #1299: fix indentation in selenium tests

* Fix #1299: fix indentation in selenium tests

* Fix: Updated json2ts command script

* Removed ignored file for bundle analyzer

* Updated gitignore

* Cleaning up the gitignore

Co-authored-by: darth-coder00 <aashit@getcollate.io>

.gitignore

@@ -65,8 +65,8 @@ dist
 secrets
 
 # ts build info and report
-catalog-rest-service/src/main/resources/ui/webpack
+openmetadata-ui/src/main/resources/ui/webpack
-catalog-rest-service/src/main/resources/ui/tsconfig.tsbuildinfo
+openmetadata-ui/src/main/resources/ui/tsconfig.tsbuildinfo
 
 #tests
 .coverage

catalog-rest-service/pom.xml

@@ -319,14 +319,6 @@
   </dependencies>
 
   <build>
-    <resources>
-      <resource>
-        <directory>src/main/resources/ui/dist</directory>
-      </resource>
-      <resource>
-        <directory>src/main/resources/json/data</directory>
-      </resource>
-    </resources>
 
     <plugins>
       <plugin>
@@ -418,69 +410,6 @@
           </execution>
         </executions>
       </plugin>
-      <!-- Handle Compiling Frontend -->
-      <plugin>
-        <groupId>com.github.eirslett</groupId>
-        <artifactId>frontend-maven-plugin</artifactId>
-        <version>1.11.0</version>
-
-        <!-- optional -->
-        <configuration>
-          <workingDirectory>src/main/resources/ui/</workingDirectory>
-          <installDirectory>target</installDirectory>
-        </configuration>
-
-        <executions>
-          <execution>
-            <id>install node and npm</id>
-            <goals>
-              <goal>install-node-and-npm</goal>
-            </goals>
-            <configuration>
-              <nodeVersion>v12.16.1</nodeVersion>
-              <npmVersion>6.13.4</npmVersion>
-            </configuration>
-          </execution>
-          <execution>
-            <id>npm install</id>
-            <goals>
-              <goal>npm</goal>
-            </goals>
-            <phase>prepare-package</phase>
-            <configuration>
-              <arguments>install</arguments>
-            </configuration>
-          </execution>
-          <execution>
-            <id>npm run-script build-check</id>
-            <goals>
-              <goal>npm</goal>
-            </goals>
-            <!-- optional: the default phase is "generate-resources" -->
-            <phase>prepare-package</phase>
-            <configuration>
-              <!-- optional: if not specified, it will run gulp's default task
-                  (and you can remove this whole <configuration> section.) -->
-              <arguments>run-script build-check</arguments>
-              <!--arguments>build</arguments-->
-            </configuration>
-          </execution>
-          <execution>
-            <id>npm run-script build</id>
-            <goals>
-              <goal>npm</goal>
-            </goals>
-            <!-- optional: the default phase is "generate-resources" -->
-            <phase>prepare-package</phase>
-            <configuration>
-              <!-- optional: if not specified, it will run gulp's default task
-                  (and you can remove this whole <configuration> section.) -->
-              <arguments>run-script build</arguments>
-              <!--arguments>build</arguments-->
-            </configuration>
-          </execution>
-        </executions>
-      </plugin>
       <plugin>
         <artifactId>maven-resources-plugin</artifactId>
         <executions>

catalog-rest-service/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineDetails/PipelineDetailsPageTest.java

@@ -25,7 +25,6 @@ import org.openqa.selenium.WebElement;
 import org.openqa.selenium.chrome.ChromeDriver;
 import org.openqa.selenium.chrome.ChromeOptions;
 import org.openqa.selenium.interactions.Actions;
-import org.openqa.selenium.support.ui.ExpectedConditions;
 import org.openqa.selenium.support.ui.WebDriverWait;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.BeforeEach;
@@ -92,7 +91,7 @@ public class PipelineDetailsPageTest {
     Thread.sleep(waitTime);
     Events.click(webDriver, By.cssSelector("[data-testid='tags']"));
     Events.click(webDriver, By.cssSelector("[data-testid='associatedTagName']"));
-        for (int i = 1; i <=2; i++){
+    for (int i = 1; i <= 2; i++) {
       Events.sendKeys(webDriver, By.cssSelector("[data-testid='associatedTagName']"), "P");
       Events.click(webDriver, By.cssSelector("[data-testid='list-item']"));
     }
@@ -135,7 +134,7 @@ public class PipelineDetailsPageTest {
     Events.sendKeys(webDriver, By.cssSelector("[data-testid='searchBox']"), pipelineName);
     Events.click(webDriver, By.cssSelector("[data-testid='data-name'][id ='sample_airflowdim_product_etl']"));
     Events.click(webDriver, By.xpath("(//button[@data-testid='tab'])[2]"));
-        for (int i=1; i<=3; i++) {
+    for (int i = 1; i <= 3; i++) {
       WebElement lineageEntity = webDriver.findElement(
           By.xpath("(//span[@data-testid='lineage-entity'])" + "[" + i + "]"));
       actions.dragAndDropBy(lineageEntity, 100, 200).build();

openmetadata-dist/pom.xml

@@ -27,7 +27,7 @@
     <version>0.7.0-SNAPSHOT</version>
   </parent>
 
-  <artifactId>catalog-bin</artifactId>
+  <artifactId>openmetadata-dist</artifactId>
   <packaging>pom</packaging>
   <name>Catalog Distribution</name>
   <description>Catalog binary distribution</description>
@@ -43,6 +43,11 @@
       <artifactId>common</artifactId>
       <version>${project.version}</version>
     </dependency>
+    <dependency>
+      <groupId>org.openmetadata</groupId>
+      <artifactId>openmetadata-ui</artifactId>
+      <version>${project.version}</version>
+    </dependency>
   </dependencies>
 
   <properties>

openmetadata-ui/pom.xml

@@ -0,0 +1,133 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <parent>
+    <artifactId>catalog</artifactId>
+    <groupId>org.openmetadata</groupId>
+    <version>0.7.0-SNAPSHOT</version>
+  </parent>
+  <modelVersion>4.0.0</modelVersion>
+
+  <artifactId>openmetadata-ui</artifactId>
+
+  <properties>
+    <dropwizard.swagger.version>2.0.12-1</dropwizard.swagger.version>
+    <testng.version>7.4.0</testng.version>
+    <selenium.version>4.0.0</selenium.version>
+  </properties>
+
+  <dependencies>
+    <dependency>
+      <groupId>org.openmetadata</groupId>
+      <artifactId>common</artifactId>
+      <version>${project.version}</version>
+    </dependency>
+    <dependency>
+      <groupId>org.openmetadata</groupId>
+      <artifactId>catalog-rest-service</artifactId>
+      <version>${project.version}</version>
+    </dependency>
+    <dependency>
+      <groupId>org.seleniumhq.selenium</groupId>
+      <artifactId>selenium-java</artifactId>
+      <version>${selenium.version}</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>io.github.artsok</groupId>
+      <artifactId>rerunner-jupiter</artifactId>
+      <version>2.1.6</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.testng</groupId>
+      <artifactId>testng</artifactId>
+      <version>${testng.version}</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>com.github.javafaker</groupId>
+      <artifactId>javafaker</artifactId>
+      <version>1.0.2</version>
+    </dependency>
+
+  </dependencies>
+
+  <build>
+    <resources>
+      <resource>
+        <directory>src/main/resources/ui/dist</directory>
+      </resource>
+      <resource>
+        <directory>src/main/resources/json/data</directory>
+      </resource>
+    </resources>
+
+    <plugins>
+      <!-- Handle Compiling Frontend -->
+      <plugin>
+        <groupId>com.github.eirslett</groupId>
+        <artifactId>frontend-maven-plugin</artifactId>
+        <version>1.11.0</version>
+
+        <!-- optional -->
+        <configuration>
+          <workingDirectory>src/main/resources/ui/</workingDirectory>
+          <installDirectory>target</installDirectory>
+        </configuration>
+
+        <executions>
+          <execution>
+            <id>install node and npm</id>
+            <goals>
+              <goal>install-node-and-npm</goal>
+            </goals>
+            <configuration>
+              <nodeVersion>v12.16.1</nodeVersion>
+              <npmVersion>6.13.4</npmVersion>
+            </configuration>
+          </execution>
+          <execution>
+            <id>npm install</id>
+            <goals>
+              <goal>npm</goal>
+            </goals>
+            <phase>prepare-package</phase>
+            <configuration>
+              <arguments>install</arguments>
+            </configuration>
+          </execution>
+          <execution>
+            <id>npm run-script build-check</id>
+            <goals>
+              <goal>npm</goal>
+            </goals>
+            <!-- optional: the default phase is "generate-resources" -->
+            <phase>prepare-package</phase>
+            <configuration>
+              <!-- optional: if not specified, it will run gulp's default task
+                  (and you can remove this whole <configuration> section.) -->
+              <arguments>run-script build-check</arguments>
+              <!--arguments>build</arguments-->
+            </configuration>
+          </execution>
+          <execution>
+            <id>npm run-script build</id>
+            <goals>
+              <goal>npm</goal>
+            </goals>
+            <!-- optional: the default phase is "generate-resources" -->
+            <phase>prepare-package</phase>
+            <configuration>
+              <!-- optional: if not specified, it will run gulp's default task
+                  (and you can remove this whole <configuration> section.) -->
+              <arguments>run-script build</arguments>
+              <!--arguments>build</arguments-->
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+</project>

openmetadata-ui/src/main/resources/ui/package.json

@@ -97,7 +97,7 @@
     "pretty": "prettier . --config './.prettierrc' --write",
     "build-check": "npm run lint",
     "commit-check": "npm run pretty && npm run build-check && npm run build",
-    "json2ts": "./json2ts.sh ../json/schema ./src/generated && npm run lint:fix"
+    "json2ts": "./json2ts.sh ../../../../../catalog-rest-service/src/main/resources/json/schema ./src/generated && npm run lint:fix"
   },
   "browserslist": {
     "production": [