fix: tour page and tags count inside table (#20583)

This commit is contained in:
Pranita Fulsundar 2025-04-02 21:55:56 +05:30 committed by GitHub
parent 2d9fbcde17
commit a1e728ad84
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 6 additions and 3 deletions

View File

@ -116,7 +116,7 @@ const ActivityFeedListV1New = ({
return <Loader />;
}
if (isEmpty(entityThread) && !isLoading) {
if (isEmpty(entityThread) && isEmpty(feedList) && !isLoading) {
return (
<div
className="p-x-md no-data-placeholder-container"

View File

@ -14,6 +14,7 @@
import classNames from 'classnames';
import { lowerCase } from 'lodash';
import React from 'react';
import { TAG_LIST_SIZE } from '../../../constants/constants';
import { EntityField } from '../../../constants/Feeds.constants';
import EntityTasks from '../../../pages/TasksPage/EntityTasks/EntityTasks.component';
import { useGenericContext } from '../../Customization/GenericProvider/GenericProvider';
@ -52,6 +53,7 @@ const TableTags = <T extends TableUnion>({
selectedTags={tags}
showHeader={false}
showInlineEditButton={showInlineEditTagButton}
sizeCap={TAG_LIST_SIZE}
tagType={type}
onSelectionChange={async (selectedTags) => {
await handleTagSelection(selectedTags, record);

View File

@ -91,7 +91,7 @@ const TagsViewer: FunctionComponent<TagsViewerProps> = ({
const popoverRenderElement = useMemo(
() =>
sortedTagsBySource.slice(sizeCap).length > 0 && (
<div className="m-t-xs" data-testid="popover-element">
<div className="m-t-xss" data-testid="popover-element">
<Popover
content={
<div className="d-flex flex-column flex-wrap gap-2">

View File

@ -55,6 +55,7 @@ export const PAGE_SIZE_LARGE = 50;
export const ES_MAX_PAGE_SIZE = 10000;
export const API_RES_MAX_SIZE = 100000;
export const LIST_SIZE = 5;
export const TAG_LIST_SIZE = 3;
export const ADD_USER_CONTAINER_HEIGHT = 250;
export const INGESTION_PROGRESS_START_VAL = 20;
export const INGESTION_PROGRESS_END_VAL = 80;

View File

@ -228,7 +228,7 @@ export const getTourSteps = ({
i18nKey="message.tour-step-click-on-entity-tab"
renderElement={<strong />}
values={{
text: i18next.t('label.profiler'),
text: i18next.t('label.data-obervability'),
}}
/>
</p>