yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-04 20:49:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix the advanced search AUT failing due to page closed (#23904)

Browse Source
This commit is contained in:
Aniket Katkar 2025-10-16 10:13:55 +05:30 committed by GitHub
parent 4942e2bdfb
commit a27d36f41f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 20 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
openmetadata-ui/src/main/resources/ui/playwright/utils/advancedSearch.ts
View File

@ -537,6 +537,12 @@ export const checkAddRuleOrGroupWithOperator = async (
.click(); .click();
} }
// Since the OR operator with must not conditions will result in huge API response
// with huge data, checking the required criteria might not be present on first page
// Hence, checking the criteria only for AND operator
if (field.id === 'Column') {
await page.getByTestId('apply-btn').click();
} else {
const searchRes = page.waitForResponse( const searchRes = page.waitForResponse(
`/api/v1/search/query?*index=dataAsset&from=0&size=15*${getEncodedFqn( `/api/v1/search/query?*index=dataAsset&from=0&size=15*${getEncodedFqn(
searchCriteria1.toLowerCase(), searchCriteria1.toLowerCase(),
@ -544,17 +550,20 @@ export const checkAddRuleOrGroupWithOperator = async (
)}*${getEncodedFqn(searchCriteria2.toLowerCase(), true)}*` )}*${getEncodedFqn(searchCriteria2.toLowerCase(), true)}*`
); );
await page.getByTestId('apply-btn').click(); await page.getByTestId('apply-btn').click();
// Since the OR operator with must not conditions will result in huge API response
// with huge data, checking the required criteria might not be present on first page
// Hence, checking the criteria only for AND operator
if (field.id !== 'Column' && operator === 'AND') {
const res = await searchRes; const res = await searchRes;
const json = await res.json(); const json = await res.json();
const hits = json.hits.hits; const hits = json.hits.hits;
if (operator === 'AND') {
expect(JSON.stringify(hits)).toContain(searchCriteria1); expect(JSON.stringify(hits)).toContain(searchCriteria1);
expect(JSON.stringify(hits)).not.toContain(searchCriteria2); expect(JSON.stringify(hits)).not.toContain(searchCriteria2);
} else {
const hitsString = JSON.stringify(hits);
const containsCriteria1 = hitsString.includes(searchCriteria1);
const containsCriteria2 = hitsString.includes(searchCriteria2);
expect(containsCriteria1 || !containsCriteria2).toBe(true);
}
} }
}; };