yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-21 15:38:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed: #3455 Able to select same term name in related terms (#3470)

Browse Source
This commit is contained in:
darth-coder00 2022-03-17 04:05:01 +05:30 committed by GitHub
parent 4874124358
commit a2a3a0ebde
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
openmetadata-ui/src/main/resources/ui/src/components/GlossaryTerms/GlossaryTermsV1.component.tsx
View File

@ -629,6 +629,7 @@ const GlossaryTermsV1 = ({
{showRelatedTermsModal && ( {showRelatedTermsModal && (
<RelatedTermsModal <RelatedTermsModal
glossaryTermFQN={glossaryTerm.fullyQualifiedName}
header="Add Related Terms" header="Add Related Terms"
relatedTerms={relatedTerms} relatedTerms={relatedTerms}
onCancel={onRelatedTermsModalCancel} onCancel={onRelatedTermsModalCancel}

10
openmetadata-ui/src/main/resources/ui/src/components/Modals/RelatedTermsModal/RelatedTermsModal.tsx
View File

@ -24,6 +24,7 @@ import Searchbar from '../../common/searchbar/Searchbar';
import Loader from '../../Loader/Loader'; import Loader from '../../Loader/Loader';
type RelatedTermsModalProp = { type RelatedTermsModalProp = {
glossaryTermFQN?: string;
relatedTerms?: Array<FormattedGlossaryTermData>; relatedTerms?: Array<FormattedGlossaryTermData>;
onCancel: () => void; onCancel: () => void;
onSave: (terms: Array<FormattedGlossaryTermData>) => void; onSave: (terms: Array<FormattedGlossaryTermData>) => void;
@ -31,6 +32,7 @@ type RelatedTermsModalProp = {
}; };
const RelatedTermsModal = ({ const RelatedTermsModal = ({
glossaryTermFQN = '',
relatedTerms, relatedTerms,
onCancel, onCancel,
onSave, onSave,
@ -56,9 +58,11 @@ const RelatedTermsModal = ({
setIsLoading(true); setIsLoading(true);
searchData(searchText, 1, PAGE_SIZE, '', '', '', SearchIndex.GLOSSARY) searchData(searchText, 1, PAGE_SIZE, '', '', '', SearchIndex.GLOSSARY)
.then((res: SearchResponse) => { .then((res: SearchResponse) => {
const termResult = formatSearchGlossaryTermResponse( const termResult = (
res?.data?.hits?.hits || [] formatSearchGlossaryTermResponse(
); res?.data?.hits?.hits || []
) as FormattedGlossaryTermData[]
).filter((item) => item.fqdn !== glossaryTermFQN);
const data = !searchText ? getSearchedTerms(termResult) : termResult; const data = !searchText ? getSearchedTerms(termResult) : termResult;
setOptions(data); setOptions(data);
}) })