Fix : Fixing #2299 Able to add the tag itself as it's associated tag and #2311 (#2310)

* Fix : Fixing #2299 Able to add the tag itself as it's associated tag.

* Fixing #2311 UI struct text in dataTypeDisplay looks like a link
This commit is contained in:
Sachin Chaurasiya 2022-01-20 23:15:23 +05:30 committed by GitHub
parent b0beac243b
commit a41dd01aaa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 7 deletions

View File

@ -377,9 +377,7 @@ const EntityTable = ({
<PopOver
html={
<div className="tw-break-words">
<RichTextEditorPreviewer
markdown={cell.value.toLowerCase()}
/>
<span>{cell.value.toLowerCase()}</span>
</div>
}
position="bottom"

View File

@ -15,7 +15,7 @@ import { AxiosError, AxiosResponse } from 'axios';
import classNames from 'classnames';
import { isUndefined, toLower } from 'lodash';
import { EntityTags, FormErrorData } from 'Models';
import React, { useEffect, useState } from 'react';
import React, { useCallback, useEffect, useState } from 'react';
import { Link } from 'react-router-dom';
import {
createTag,
@ -68,6 +68,12 @@ const TagsPage = () => {
const [errorDataCategory, setErrorDataCategory] = useState<FormErrorData>();
const [errorDataTag, setErrorDataTag] = useState<FormErrorData>();
const getTags = useCallback(() => {
return getTaglist(categories).filter(
(tag) => editTag?.fullyQualifiedName !== tag
);
}, [currentCategory, editTag]);
const fetchCategories = () => {
setIsLoading(true);
getTagCategories('usageCount')
@ -440,9 +446,7 @@ const TagsPage = () => {
tagFQN: tag,
})) || []
}
tagList={
getTaglist(categories) as Array<string>
}
tagList={getTags()}
onCancel={() => {
handleTagSelection();
}}