yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2026-01-08 05:26:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix HexByteString Issue, revert datatype change (#11145)

Browse Source 
* Fix HexByteString Issue, revert datatype change

* Add E2E MSSQL Bit type
This commit is contained in:
Ayush Shah 2023-04-21 13:38:27 +05:30 committed by GitHub
parent 97b58c65f5
commit a50c31539b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ingestion/src/metadata/profiler/orm/converter.py
View File

@ -52,7 +52,7 @@ _TYPE_MAP = {
DataType.CHAR: sqlalchemy.CHAR,
DataType.VARCHAR: sqlalchemy.VARCHAR,
DataType.BOOLEAN: sqlalchemy.BOOLEAN,
DataType.BINARY: CustomTypes.BYTES.value,
DataType.BINARY: sqlalchemy.LargeBinary,
DataType.VARBINARY: sqlalchemy.VARBINARY,
DataType.ARRAY: sqlalchemy.ARRAY,
DataType.BLOB: CustomTypes.BYTES.value,

6
ingestion/tests/cli_e2e/common/test_cli_db.py
View File

@ -12,6 +12,7 @@
"""
Test database connectors which extend from `CommonDbSourceService` with CLI
"""
import json
from abc import ABC, abstractmethod
from pathlib import Path
from typing import Optional
@ -110,6 +111,11 @@ class CliCommonDB:
self.assertTrue(
column_profile[key] == expected_column_profile[key]
)
if sample_data:
self.assertTrue(
len(json.loads(sample_data.json()).get("rows"))
== table_profile.get("rowCount")
)
def assert_for_delete_table_is_marked_as_deleted(
self, source_status: SourceStatus, sink_status: SinkStatus

23
ingestion/tests/cli_e2e/test_cli_mssql.py
View File

@ -26,8 +26,9 @@ class MSSQLCliTest(CliCommonDB.TestSuite, SQACommonMethods):
CREATE TABLE e2e_cli_tests.dbo.persons (
person_id int,
full_name varchar(255),
birthdate date
)
birthdate date,
is_meeting_scheduled bit,
);
"""
create_view_query: str = """
@ -38,13 +39,13 @@ class MSSQLCliTest(CliCommonDB.TestSuite, SQACommonMethods):
insert_data_queries: List[str] = [
"""
INSERT INTO persons (person_id, full_name, birthdate) VALUES
(1,'Peter Parker', '2004-08-10'),
(2,'Bruce Banner', '1988-12-18'),
(3,'Steve Rogers', '1988-07-04'),
(4,'Natasha Romanoff', '1997-12-03'),
(5,'Wanda Maximoff', '1998-02-10'),
(6,'Diana Prince', '1976-03-17');
INSERT INTO persons (person_id, full_name, birthdate, is_meeting_scheduled) VALUES
(1,'Peter Parker', '2004-08-10', 1),
(2,'Bruce Banner', '1988-12-18', 1),
(3,'Steve Rogers', '1988-07-04', 0),
(4,'Natasha Romanoff', '1997-12-03', 1),
(5,'Wanda Maximoff', '1998-02-10', 1),
(6,'Diana Prince', '1976-03-17', 0);
"""
]
@ -80,7 +81,7 @@ class MSSQLCliTest(CliCommonDB.TestSuite, SQACommonMethods):
return 6
def view_column_lineage_count(self) -> int:
return 3
return 4
@staticmethod
def fqn_created_table() -> str:
@ -135,7 +136,7 @@ class MSSQLCliTest(CliCommonDB.TestSuite, SQACommonMethods):
def get_profiler_time_partition_results() -> dict:
return {
"table_profile": {
"columnCount": 3.0,
"columnCount": 4.0,
"rowCount": 3.0,
},
"column_profile": [