-
+
{service.serviceType}
@@ -212,18 +216,22 @@ const Services = ({
placement="left"
title={
addServicePermission
- ? 'Add Service'
+ ? t('label.add-entity', {
+ entity: t('label.service'),
+ })
: NO_PERMISSION_FOR_ACTION
}>
-
- Add new {servicesDisplayName[serviceName]}
-
+ {t('label.add-new-entity', {
+ entity: servicesDisplayName[serviceName],
+ })}
+
}
doc={CONNECTORS_DOCS}
diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json
index a95cd562d27..a5cf226f17c 100644
--- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json
+++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json
@@ -13,6 +13,7 @@
"activity-lowercase-plural": "activities",
"add": "Add",
"add-a-new-service": "Add a New Service",
+ "add-custom-entity-property": "Add Custom {{entity}} Property",
"add-deploy": "Add & Deploy",
"add-entity": "Add {{entity}}",
"add-glossary": "Add Glossary",
diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/CustomPropertiesPageV1/CustomPropertiesPageV1.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/CustomPropertiesPageV1/CustomPropertiesPageV1.tsx
index bbb33afafed..c039a25e176 100644
--- a/openmetadata-ui/src/main/resources/ui/src/pages/CustomPropertiesPageV1/CustomPropertiesPageV1.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/pages/CustomPropertiesPageV1/CustomPropertiesPageV1.tsx
@@ -11,9 +11,8 @@
* limitations under the License.
*/
-import { Button as ButtonAntd, Col, Row, Tooltip } from 'antd';
+import { Button, Col, Row, Tooltip } from 'antd';
import { AxiosError } from 'axios';
-import { Button } from 'components/buttons/Button/Button';
import ErrorPlaceHolder from 'components/common/error-with-placeholder/ErrorPlaceHolder';
import TabsPane from 'components/common/TabsPane/TabsPane';
import { CustomPropertyTable } from 'components/CustomEntityDetail/CustomPropertyTable';
@@ -27,7 +26,8 @@ import {
import SchemaEditor from 'components/schema-editor/SchemaEditor';
import { compare } from 'fast-json-patch';
import { isEmpty, isUndefined } from 'lodash';
-import React, { useCallback, useEffect, useMemo, useState } from 'react';
+import React, { useEffect, useMemo, useState } from 'react';
+import { useTranslation } from 'react-i18next';
import { useHistory, useParams } from 'react-router-dom';
import { getTypeByFQN, updateType } from 'rest/metadataTypeAPI';
import {
@@ -47,6 +47,7 @@ import { showErrorToast } from '../../utils/ToastUtils';
import './CustomPropertiesPageV1.less';
const CustomEntityDetailV1 = () => {
+ const { t } = useTranslation();
const { tab } = useParams<{ [key: string]: string }>();
const history = useHistory();
@@ -141,19 +142,22 @@ const CustomEntityDetailV1 = () => {
}
};
- const getCustomPageHeader = useCallback(() => {
+ const customPageHeader = useMemo(() => {
switch (tabAttributePath) {
case ENTITY_PATH.tables:
return PAGE_HEADERS.TABLES_CUSTOM_ATTRIBUTES;
+
case ENTITY_PATH.topics:
return PAGE_HEADERS.TOPICS_CUSTOM_ATTRIBUTES;
+
case ENTITY_PATH.dashboards:
return PAGE_HEADERS.DASHBOARD_CUSTOM_ATTRIBUTES;
+
case ENTITY_PATH.pipelines:
return PAGE_HEADERS.PIPELINES_CUSTOM_ATTRIBUTES;
+
case ENTITY_PATH.mlmodels:
return PAGE_HEADERS.ML_MODELS_CUSTOM_ATTRIBUTES;
-
default:
return PAGE_HEADERS.TABLES_CUSTOM_ATTRIBUTES;
}
@@ -191,7 +195,7 @@ const CustomEntityDetailV1 = () => {
data-testid="custom-entity-container"
gutter={[16, 16]}>
-
+
{
-
+
+ {t('label.add-entity', {
+ entity: t('label.property'),
+ })}
+
}
dataTestId="custom-properties-no-data"
@@ -237,15 +249,24 @@ const CustomEntityDetailV1 = () => {
+ placement="topRight"
+ title={
+ editPermission
+ ? t('label.add-custom-entity-property', {
+ entity: customPageHeader.header,
+ })
+ : NO_PERMISSION_FOR_ACTION
+ }>
diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/Glossary/GlossaryLeftPanel/GlossaryLeftPanel.component.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/Glossary/GlossaryLeftPanel/GlossaryLeftPanel.component.tsx
index 0c05a2f23f3..72dae241c3a 100644
--- a/openmetadata-ui/src/main/resources/ui/src/pages/Glossary/GlossaryLeftPanel/GlossaryLeftPanel.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/pages/Glossary/GlossaryLeftPanel/GlossaryLeftPanel.component.tsx
@@ -14,7 +14,7 @@
import { Button, Col, Menu, MenuProps, Row, Tooltip, Typography } from 'antd';
import { ItemType } from 'antd/lib/menu/hooks/useItems';
import { ReactComponent as IconFolder } from 'assets/svg/folder.svg';
-import { ReactComponent as PlusIcon } from 'assets/svg/plus-primery.svg';
+import { ReactComponent as PlusIcon } from 'assets/svg/plus-primary.svg';
import LeftPanelCard from 'components/common/LeftPanelCard/LeftPanelCard';
import Searchbar from 'components/common/searchbar/Searchbar';
import { usePermissionProvider } from 'components/PermissionProvider/PermissionProvider';
diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/Glossary/GlossaryPage/GlossaryPage.component.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/Glossary/GlossaryPage/GlossaryPage.component.tsx
index c4fd7e9aa4a..201236ea0f7 100644
--- a/openmetadata-ui/src/main/resources/ui/src/pages/Glossary/GlossaryPage/GlossaryPage.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/pages/Glossary/GlossaryPage/GlossaryPage.component.tsx
@@ -234,10 +234,10 @@ const GlossaryPage = () => {
{t('label.add-new-entity', { entity: t('label.glossary') })}
diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/tags/index.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/tags/index.tsx
index 2edaf6ccf3e..b7039821275 100644
--- a/openmetadata-ui/src/main/resources/ui/src/pages/tags/index.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/pages/tags/index.tsx
@@ -60,6 +60,7 @@ import {
patchClassification,
patchTag,
} from 'rest/tagAPI';
+import { ReactComponent as PlusIcon } from '../../assets/svg/plus-primary.svg';
import {
INITIAL_PAGING_VALUE,
PAGE_SIZE,
@@ -619,21 +620,22 @@ const TagsPage = () => {
})
: t('message.no-permission-for-action')
}>
- }
onClick={() => {
setIsAddingClassification((prevState) => !prevState);
setErrorDataClassification(undefined);
}}>
- {' '}
{t('label.add-entity', {
entity: t('label.classification'),
})}
-
+
@@ -877,22 +879,33 @@ const TagsPage = () => {
})}