From a5ff3a349944033ab2ee779cbfb23e8e0c66c6c8 Mon Sep 17 00:00:00 2001 From: Onkar Ravgan Date: Thu, 2 Jun 2022 18:37:22 +0530 Subject: [PATCH] Removed connectionOptions dictionary (#5264) Co-authored-by: Onkar Ravgan --- ingestion/src/metadata/utils/connections.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/ingestion/src/metadata/utils/connections.py b/ingestion/src/metadata/utils/connections.py index c5e9fc5fe12..1866116d547 100644 --- a/ingestion/src/metadata/utils/connections.py +++ b/ingestion/src/metadata/utils/connections.py @@ -27,7 +27,6 @@ from sqlalchemy.orm.session import Session from metadata.generated.schema.entity.services.connections.connectionBasicType import ( ConnectionArguments, - ConnectionOptions, ) from metadata.generated.schema.entity.services.connections.dashboard.metabaseConnection import ( MetabaseConnection, @@ -101,11 +100,9 @@ def create_generic_connection(connection, verbose: bool = False) -> Engine: :param verbose: debugger or not :return: SQAlchemy Engine """ - options = connection.connectionOptions or ConnectionOptions() engine = create_engine( get_connection_url(connection), - **options.dict(), connect_args=get_connection_args(connection), pool_reset_on_return=None, # https://docs.sqlalchemy.org/en/14/core/pooling.html#reset-on-return echo=verbose,