yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-27 16:55:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removed connectionOptions dictionary (#5264)

Browse Source 
Co-authored-by: Onkar Ravgan <onkarravgan@Onkars-MacBook-Pro.local>
This commit is contained in:
Onkar Ravgan 2022-06-02 18:37:22 +05:30 committed by GitHub
parent 8e525b60e0
commit a5ff3a3499
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ingestion/src/metadata/utils/connections.py
View File

@ -27,7 +27,6 @@ from sqlalchemy.orm.session import Session
from metadata.generated.schema.entity.services.connections.connectionBasicType import ( from metadata.generated.schema.entity.services.connections.connectionBasicType import (
ConnectionArguments, ConnectionArguments,
ConnectionOptions,
) )
from metadata.generated.schema.entity.services.connections.dashboard.metabaseConnection import ( from metadata.generated.schema.entity.services.connections.dashboard.metabaseConnection import (
MetabaseConnection, MetabaseConnection,
@ -101,11 +100,9 @@ def create_generic_connection(connection, verbose: bool = False) -> Engine:
:param verbose: debugger or not :param verbose: debugger or not
:return: SQAlchemy Engine :return: SQAlchemy Engine
""" """
options = connection.connectionOptions or ConnectionOptions()
engine = create_engine( engine = create_engine(
get_connection_url(connection), get_connection_url(connection),
**options.dict(),
connect_args=get_connection_args(connection), connect_args=get_connection_args(connection),
pool_reset_on_return=None, # https://docs.sqlalchemy.org/en/14/core/pooling.html#reset-on-return pool_reset_on_return=None, # https://docs.sqlalchemy.org/en/14/core/pooling.html#reset-on-return
echo=verbose, echo=verbose,