Minor: Entity Header certificates Design changes (#20484)

* fixed header certificates

* view source url renamed

* fixed broze medal case sensitivity

* fixed test case and comments

* fixed certification

* fixed certification className

* fixed certificates

* fixed variable usage

---------

Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
This commit is contained in:
Dhruv Parmar 2025-04-03 19:18:43 +05:30 committed by GitHub
parent f6441ad404
commit a6c96611fd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
23 changed files with 49 additions and 9 deletions

View File

@ -553,7 +553,9 @@ export const DataAssetsHeader = ({
<Typography.Link <Typography.Link
href={(dataAsset as Table).sourceUrl} href={(dataAsset as Table).sourceUrl}
target="_blank"> target="_blank">
{t('label.source-url')} {t('label.view-in-service-type', {
serviceType: (dataAsset as Table).serviceType,
})}
</Typography.Link> </Typography.Link>
</Button> </Button>
</Tooltip> </Tooltip>
@ -627,7 +629,7 @@ export const DataAssetsHeader = ({
data-testid="header-tier-container"> data-testid="header-tier-container">
{tier ? ( {tier ? (
<div className="d-flex flex-col gap-2"> <div className="d-flex flex-col gap-2">
<div className="d-flex items-center gap-1"> <div className="tier-heading-container d-flex items-center gap-1">
<span className="entity-no-tier "> <span className="entity-no-tier ">
{t('label.tier')} {t('label.tier')}
</span> </span>
@ -654,7 +656,7 @@ export const DataAssetsHeader = ({
</div> </div>
) : ( ) : (
<div className="flex items-center flex-col gap-2"> <div className="flex items-center flex-col gap-2">
<div className="d-flex items-center gap-1"> <div className="tier-heading-container d-flex items-center gap-1">
<span className="entity-no-tier"> <span className="entity-no-tier">
{t('label.tier')} {t('label.tier')}
</span> </span>

View File

@ -17,7 +17,10 @@ import {
APIEndpoint, APIEndpoint,
APIRequestMethod, APIRequestMethod,
} from '../../../generated/entity/data/apiEndpoint'; } from '../../../generated/entity/data/apiEndpoint';
import { Container } from '../../../generated/entity/data/container'; import {
Container,
StorageServiceType,
} from '../../../generated/entity/data/container';
import { MOCK_TIER_DATA } from '../../../mocks/TableData.mock'; import { MOCK_TIER_DATA } from '../../../mocks/TableData.mock';
import { getDataQualityLineage } from '../../../rest/lineageAPI'; import { getDataQualityLineage } from '../../../rest/lineageAPI';
import { getContainerByName } from '../../../rest/storageAPI'; import { getContainerByName } from '../../../rest/storageAPI';
@ -42,6 +45,7 @@ const mockProps: DataAssetsHeaderProps = {
name: 's3_storage_sample', name: 's3_storage_sample',
type: 'storageService', type: 'storageService',
}, },
serviceType: 'moc service' as StorageServiceType,
} as Container, } as Container,
entityType: EntityType.CONTAINER, entityType: EntityType.CONTAINER,
permissions: DEFAULT_ENTITY_PERMISSION, permissions: DEFAULT_ENTITY_PERMISSION,
@ -246,7 +250,9 @@ describe('DataAssetsHeader component', () => {
expect(sourceUrlButton).toBeInTheDocument(); expect(sourceUrlButton).toBeInTheDocument();
expect(sourceUrlLink).toHaveAttribute('href', mockSourceUrl); expect(sourceUrlLink).toHaveAttribute('href', mockSourceUrl);
expect(sourceUrlLink).toHaveAttribute('target', '_blank'); expect(sourceUrlLink).toHaveAttribute('target', '_blank');
expect(screen.getByText('label.source-url')).toBeInTheDocument(); expect(screen.getByText('label.view-in-service-type')).toBeInTheDocument();
``;
}); });
it('should not render source URL button when sourceUrl is not present', () => { it('should not render source URL button when sourceUrl is not present', () => {

View File

@ -124,4 +124,9 @@
.extra-info-container { .extra-info-container {
max-width: 148px; max-width: 148px;
} }
.tier-heading-container {
svg {
fill: @de-active-color;
}
}
} }

View File

@ -112,7 +112,7 @@ const EntityHeaderTitle = ({
wrap={false}> wrap={false}>
{icon && <Col className="flex-center">{icon}</Col>} {icon && <Col className="flex-center">{icon}</Col>}
<Col <Col
className={classNames('d-flex flex-col gap-2', { className={classNames('d-flex flex-col gap-1', {
'w-max-full-140': deleted || badge, 'w-max-full-140': deleted || badge,
})}> })}>
{/* If we do not have displayName name only be shown in the bold from the below code */} {/* If we do not have displayName name only be shown in the bold from the below code */}

View File

@ -27,11 +27,11 @@ const CertificationTag = ({
}) => { }) => {
if (certification.tagLabel.style?.iconURL) { if (certification.tagLabel.style?.iconURL) {
const name = getEntityName(certification.tagLabel); const name = getEntityName(certification.tagLabel);
const actualName = certification.tagLabel.name ?? '';
const tagSrc = getTagImageSrc(certification.tagLabel.style.iconURL); const tagSrc = getTagImageSrc(certification.tagLabel.style.iconURL);
return ( return (
<Tooltip <Tooltip
className="cursor-pointer"
title={getTagTooltip(name, certification.tagLabel.description)} title={getTagTooltip(name, certification.tagLabel.description)}
trigger="hover"> trigger="hover">
<div <div
@ -50,7 +50,10 @@ const CertificationTag = ({
src={tagSrc} src={tagSrc}
/> />
{showName && ( {showName && (
<span className="certification-name text-sm font-medium"> <span
className={classNames('text-sm font-medium', {
[`${actualName.toLowerCase()}`]: Boolean(actualName),
})}>
{name} {name}
</span> </span>
)} )}

View File

@ -38,7 +38,13 @@
width: 16px; width: 16px;
height: 16px; height: 16px;
} }
span { span.bronze {
color: @red-16;
}
span.silver {
color: @grey-700;
}
span.gold {
color: @yellow-11; color: @yellow-11;
} }
} }

View File

@ -1497,6 +1497,7 @@
"view-definition": "Ansichtsdefinition", "view-definition": "Ansichtsdefinition",
"view-detail-plural": "Details anzeigen", "view-detail-plural": "Details anzeigen",
"view-entity": "{{entity}} anzeigen", "view-entity": "{{entity}} anzeigen",
"view-in-service-type": "In {{serviceType}} anzeigen",
"view-less": "Weniger anzeigen", "view-less": "Weniger anzeigen",
"view-more": "Mehr anzeigen", "view-more": "Mehr anzeigen",
"view-new-count": "{{count}} Neu anzeigen", "view-new-count": "{{count}} Neu anzeigen",

View File

@ -1497,6 +1497,7 @@
"view-definition": "View Definition", "view-definition": "View Definition",
"view-detail-plural": "View Details", "view-detail-plural": "View Details",
"view-entity": "View {{entity}}", "view-entity": "View {{entity}}",
"view-in-service-type": "View in {{serviceType}}",
"view-less": "View less", "view-less": "View less",
"view-more": "View more", "view-more": "View more",
"view-new-count": "View {{count}} new", "view-new-count": "View {{count}} new",

View File

@ -1497,6 +1497,7 @@
"view-definition": "View Definition", "view-definition": "View Definition",
"view-detail-plural": "Ver detalles", "view-detail-plural": "Ver detalles",
"view-entity": "Ver {{entity}}", "view-entity": "Ver {{entity}}",
"view-in-service-type": "Ver en {{serviceType}}",
"view-less": "Ver menos", "view-less": "Ver menos",
"view-more": "Ver más", "view-more": "Ver más",
"view-new-count": "Ver {{count}} nuevo", "view-new-count": "Ver {{count}} nuevo",

View File

@ -1497,6 +1497,7 @@
"view-definition": "Définition de la Vue", "view-definition": "Définition de la Vue",
"view-detail-plural": "Voir les détails", "view-detail-plural": "Voir les détails",
"view-entity": "Voir la {{entity}}", "view-entity": "Voir la {{entity}}",
"view-in-service-type": "Voir dans {{serviceType}}",
"view-less": "Voir moins", "view-less": "Voir moins",
"view-more": "Voir Plus", "view-more": "Voir Plus",
"view-new-count": "Voir {{count}} Nouveau", "view-new-count": "Voir {{count}} Nouveau",

View File

@ -1497,6 +1497,7 @@
"view-definition": "Ver definición", "view-definition": "Ver definición",
"view-detail-plural": "Ver detalles", "view-detail-plural": "Ver detalles",
"view-entity": "Ver {{entity}}", "view-entity": "Ver {{entity}}",
"view-in-service-type": "Ver en {{serviceType}}",
"view-less": "Ver menos", "view-less": "Ver menos",
"view-more": "Ver máis", "view-more": "Ver máis",
"view-new-count": "Ver {{count}} novos", "view-new-count": "Ver {{count}} novos",

View File

@ -1497,6 +1497,7 @@
"view-definition": "הצג תיאור", "view-definition": "הצג תיאור",
"view-detail-plural": "הצג פרטים", "view-detail-plural": "הצג פרטים",
"view-entity": "הצג {{entity}}", "view-entity": "הצג {{entity}}",
"view-in-service-type": "צפה ב-{{serviceType}}",
"view-less": "הצג פחות", "view-less": "הצג פחות",
"view-more": "הצג עוד", "view-more": "הצג עוד",
"view-new-count": "הצג {{count}} חדש", "view-new-count": "הצג {{count}} חדש",

View File

@ -1497,6 +1497,7 @@
"view-definition": "View Definition", "view-definition": "View Definition",
"view-detail-plural": "詳細を表示", "view-detail-plural": "詳細を表示",
"view-entity": "{{entity}}を見る", "view-entity": "{{entity}}を見る",
"view-in-service-type": "{{serviceType}}에서 보기",
"view-less": "表示を減らす", "view-less": "表示を減らす",
"view-more": "もっと見る", "view-more": "もっと見る",
"view-new-count": "View {{count}} new", "view-new-count": "View {{count}} new",

View File

@ -1497,6 +1497,7 @@
"view-definition": "정의 보기", "view-definition": "정의 보기",
"view-detail-plural": "View Details", "view-detail-plural": "View Details",
"view-entity": "{{entity}} 보기", "view-entity": "{{entity}} 보기",
"view-in-service-type": "View in {{serviceType}}",
"view-less": "적게 보기", "view-less": "적게 보기",
"view-more": "더 보기", "view-more": "더 보기",
"view-new-count": "{{count}}개 새 항목 보기", "view-new-count": "{{count}}개 새 항목 보기",

View File

@ -1497,6 +1497,7 @@
"view-definition": "परिभाषा पहा", "view-definition": "परिभाषा पहा",
"view-detail-plural": "तपशील पहा", "view-detail-plural": "तपशील पहा",
"view-entity": "{{entity}} पहा", "view-entity": "{{entity}} पहा",
"view-in-service-type": "{{serviceType}} मध्ये पहा",
"view-less": "कमी पहा", "view-less": "कमी पहा",
"view-more": "अधिक पहा", "view-more": "अधिक पहा",
"view-new-count": "{{count}} नवीन पहा", "view-new-count": "{{count}} नवीन पहा",

View File

@ -1497,6 +1497,7 @@
"view-definition": "Viewdefinitie", "view-definition": "Viewdefinitie",
"view-detail-plural": "Details bekijken", "view-detail-plural": "Details bekijken",
"view-entity": "Bekijk {{entity}}", "view-entity": "Bekijk {{entity}}",
"view-in-service-type": "Bekijk in {{serviceType}}",
"view-less": "Minder weergeven", "view-less": "Minder weergeven",
"view-more": "Bekijk meer", "view-more": "Bekijk meer",
"view-new-count": "Bekijk {{count}} nieuw", "view-new-count": "Bekijk {{count}} nieuw",

View File

@ -1497,6 +1497,7 @@
"view-definition": "مشاهده تعریف", "view-definition": "مشاهده تعریف",
"view-detail-plural": "مشاهده جزئیات", "view-detail-plural": "مشاهده جزئیات",
"view-entity": "مشاهده {{entity}}", "view-entity": "مشاهده {{entity}}",
"view-in-service-type": "در {{serviceType}} مشاهده کنید",
"view-less": "Ver menos", "view-less": "Ver menos",
"view-more": "مشاهده بیشتر", "view-more": "مشاهده بیشتر",
"view-new-count": "مشاهده {{count}} جدید", "view-new-count": "مشاهده {{count}} جدید",

View File

@ -1497,6 +1497,7 @@
"view-definition": "Definição de Visualização", "view-definition": "Definição de Visualização",
"view-detail-plural": "Ver detalhes", "view-detail-plural": "Ver detalhes",
"view-entity": "Visualizar {{entity}}", "view-entity": "Visualizar {{entity}}",
"view-in-service-type": "Ver no {{serviceType}}",
"view-less": "Ver menos", "view-less": "Ver menos",
"view-more": "Ver mais", "view-more": "Ver mais",
"view-new-count": "Visualizar {{count}} novos", "view-new-count": "Visualizar {{count}} novos",

View File

@ -1497,6 +1497,7 @@
"view-definition": "Definição de Visualização", "view-definition": "Definição de Visualização",
"view-detail-plural": "Ver detalhes", "view-detail-plural": "Ver detalhes",
"view-entity": "Visualizar {{entity}}", "view-entity": "Visualizar {{entity}}",
"view-in-service-type": "Ver em {{serviceType}}",
"view-less": "Ver menos", "view-less": "Ver menos",
"view-more": "Ver mais", "view-more": "Ver mais",
"view-new-count": "Visualizar {{count}} novos", "view-new-count": "Visualizar {{count}} novos",

View File

@ -1497,6 +1497,7 @@
"view-definition": "Посмотреть определение", "view-definition": "Посмотреть определение",
"view-detail-plural": "Просмотр деталей", "view-detail-plural": "Просмотр деталей",
"view-entity": "Посмотреть {{entity}}", "view-entity": "Посмотреть {{entity}}",
"view-in-service-type": "Просмотр в {{serviceType}}",
"view-less": "Показать меньше", "view-less": "Показать меньше",
"view-more": "Посмотреть больше", "view-more": "Посмотреть больше",
"view-new-count": "Посмотреть {{count}} новых", "view-new-count": "Посмотреть {{count}} новых",

View File

@ -1497,6 +1497,7 @@
"view-definition": "ดูคำจำกัดความ", "view-definition": "ดูคำจำกัดความ",
"view-detail-plural": "ดูรายละเอียด", "view-detail-plural": "ดูรายละเอียด",
"view-entity": "ดู {{entity}}", "view-entity": "ดู {{entity}}",
"view-in-service-type": "ดูใน {{serviceType}}",
"view-less": "ดูน้อยลง", "view-less": "ดูน้อยลง",
"view-more": "ดูเพิ่มเติม", "view-more": "ดูเพิ่มเติม",
"view-new-count": "ดู {{count}} ใหม่", "view-new-count": "ดู {{count}} ใหม่",

View File

@ -1497,6 +1497,7 @@
"view-definition": "查看定义", "view-definition": "查看定义",
"view-detail-plural": "查看详情", "view-detail-plural": "查看详情",
"view-entity": "查看{{entity}}", "view-entity": "查看{{entity}}",
"view-in-service-type": "在 {{serviceType}} 中查看",
"view-less": "查看较少", "view-less": "查看较少",
"view-more": "查看更多", "view-more": "查看更多",
"view-new-count": "查看{{count}}个新的", "view-new-count": "查看{{count}}个新的",

View File

@ -65,6 +65,7 @@
@red-13: #fda29b; @red-13: #fda29b;
@red-14: #d92d20; @red-14: #d92d20;
@red-15: #e52315; @red-15: #e52315;
@red-16: #7e2410;
@orange-1: #fff6ed; @orange-1: #fff6ed;
@orange-2: #c4320a; @orange-2: #c4320a;
@ -122,6 +123,7 @@
@grey-19: #363f72; @grey-19: #363f72;
@text-grey-muted: @grey-4; @text-grey-muted: @grey-4;
@de-active-color: #6b7280;
@font-size-base: 14px; @font-size-base: 14px;
@box-shadow-base: 0px 2px 10px rgba(0, 0, 0, 0.12); @box-shadow-base: 0px 2px 10px rgba(0, 0, 0, 0.12);
@white: #fff; @white: #fff;