From a6fa899cbb59f2fe5278af036eda22f00f0d65b6 Mon Sep 17 00:00:00 2001
From: Pere Miquel Brull <peremiquelbrull@gmail.com>
Date: Mon, 3 Mar 2025 10:03:22 +0100
Subject: [PATCH] MINOR - Fix user update roles (#20014)

---
 .../java/org/openmetadata/service/jdbi3/UserRepository.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/UserRepository.java b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/UserRepository.java
index 2e77c9af93c..13bbc7a52ff 100644
--- a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/UserRepository.java
+++ b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/UserRepository.java
@@ -648,8 +648,8 @@ public class UserRepository extends EntityRepository<User> {
       deleteFrom(original.getId(), USER, Relationship.HAS, Entity.ROLE);
       assignRoles(updated, updated.getRoles());
 
-      List<EntityReference> origRoles = listOrEmpty(original.getRoles());
-      List<EntityReference> updatedRoles = listOrEmpty(updated.getRoles());
+      List<EntityReference> origRoles = listOrEmptyMutable(original.getRoles());
+      List<EntityReference> updatedRoles = listOrEmptyMutable(updated.getRoles());
 
       origRoles.sort(EntityUtil.compareEntityReference);
       updatedRoles.sort(EntityUtil.compareEntityReference);