yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-29 01:32:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix query for mysql con. (#18272)

Browse Source
This commit is contained in:
harshsoni2024 2024-10-15 14:03:49 +05:30 committed by harshsoni2024
parent dfb7a3ce9d
commit a9a37cfd0b
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ingestion/src/metadata/ingestion/source/dashboard/superset/connection.py
View File

@ -84,7 +84,12 @@ def test_connection(
else:
test_fn["CheckAccess"] = partial(test_connection_engine_step, client)
test_fn["GetDashboards"] = partial(test_query, client, FETCH_DASHBOARDS_TEST)
test_fn["GetCharts"] = partial(test_query, client, FETCH_ALL_CHARTS_TEST)
if isinstance(service_connection.connection, MysqlConnection):
test_fn["GetCharts"] = partial(
test_query, client, FETCH_ALL_CHARTS_TEST.replace('"', "`")
)
else:
test_fn["GetCharts"] = partial(test_query, client, FETCH_ALL_CHARTS_TEST)
test_connection_steps(
metadata=metadata,

8
ingestion/src/metadata/ingestion/source/dashboard/superset/db_source.py
View File

@ -26,6 +26,9 @@ from metadata.generated.schema.api.data.createDashboardDataModel import (
from metadata.generated.schema.entity.data.chart import Chart
from metadata.generated.schema.entity.data.dashboardDataModel import DataModelType
from metadata.generated.schema.entity.data.table import Table
from metadata.generated.schema.entity.services.connections.database.mysqlConnection import (
MysqlConnection,
)
from metadata.generated.schema.entity.services.databaseService import DatabaseService
from metadata.generated.schema.entity.services.ingestionPipelines.status import (
StackTraceError,
@ -81,7 +84,10 @@ class SupersetDBSource(SupersetSourceMixin):
the required information which is not available in fetch_charts_with_id api
"""
try:
charts = self.engine.execute(FETCH_ALL_CHARTS)
if isinstance(self.service_connection.connection, MysqlConnection):
charts = self.engine.execute(FETCH_ALL_CHARTS.replace('"', "`"))
else:
charts = self.engine.execute(FETCH_ALL_CHARTS)
for chart in charts:
chart_detail = FetchChart(**chart)
self.all_charts[chart_detail.id] = chart_detail