yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-12-24 22:18:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #5880 Validate Airflow connection in Test Connection button (#6060)

Browse Source
This commit is contained in:
Sachin Chaurasiya 2022-07-13 19:26:46 +05:30 committed by GitHub
parent 5d584731ed
commit a9d2fc5572
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
openmetadata-ui/src/main/resources/ui/src/components/ServiceConfig/ConnectionConfigForm.tsx
View File

@ -14,7 +14,14 @@
import { ISubmitEvent } from '@rjsf/core';
import { cloneDeep, isNil } from 'lodash';
import { LoadingState } from 'Models';
import React, { Fragment, FunctionComponent, useMemo } from 'react';
import React, {
Fragment,
FunctionComponent,
useEffect,
useMemo,
useState,
} from 'react';
import { checkAirflowStatus } from '../../axiosAPIs/ingestionPipelineAPI';
import { TestConnection } from '../../axiosAPIs/serviceAPI';
import { ServiceCategory } from '../../enums/service.enum';
import { MlModelServiceType } from '../../generated/api/services/createMlModelService';
@ -76,6 +83,8 @@ const ConnectionConfigForm: FunctionComponent<Props> = ({
onCancel,
onSave,
}: Props) => {
const [isAirflowAvailable, setIsAirflowAvailable] = useState<boolean>(false);
const allowTestConn = useMemo(() => {
return shouldTestConnection(serviceType);
}, [serviceType]);
@ -165,11 +174,28 @@ const ConnectionConfigForm: FunctionComponent<Props> = ({
uiSchema={connSch.uiSchema}
onCancel={onCancel}
onSubmit={handleSave}
onTestConnection={allowTestConn ? handleTestConnection : undefined}
onTestConnection={
allowTestConn && isAirflowAvailable ? handleTestConnection : undefined
}
/>
);
};
useEffect(() => {
checkAirflowStatus()
.then((res) => {
if (res.status === 200) {
setIsAirflowAvailable(true);
} else {
setIsAirflowAvailable(false);
}
})
.catch((error) => {
// eslint-disable-next-line no-console
console.log(error);
});
}, []);
return <Fragment>{getDatabaseFields()}</Fragment>;
};