diff --git a/openmetadata-ui/src/main/resources/ui/playwright/constant/customizeDetail.ts b/openmetadata-ui/src/main/resources/ui/playwright/constant/customizeDetail.ts index de05b87e36e..924e7009907 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/constant/customizeDetail.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/constant/customizeDetail.ts @@ -33,15 +33,16 @@ export enum ECustomizedGovernance { } export const TABLE_DEFAULT_TABS = [ - 'Schema', 'Activity Feeds & Tasks', - 'Sample Data', - 'Queries', + 'Contract', + 'Custom Properties', 'Data Observability', 'Lineage', - 'dbt', + 'Queries', + 'Sample Data', + 'Schema', 'View Definition', - 'Custom Properties', + 'dbt', ]; export const TOPIC_DEFAULT_TABS = [ diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/CustomizeDetailPage.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/CustomizeDetailPage.spec.ts index c74d60b614b..dff3416925a 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/CustomizeDetailPage.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/CustomizeDetailPage.spec.ts @@ -388,6 +388,9 @@ test.describe('Persona customization', () => { .getByTestId('remove-widget-button') .click(); + await adminPage.getByTestId('tab-Custom Properties').click(); + await adminPage.getByText('Hide').click(); + await adminPage.getByRole('button', { name: 'Add tab' }).click(); await adminPage diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Customization/GenericTab/GenericTab.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Customization/GenericTab/GenericTab.tsx index 8f0bd775a48..942eaf9c2fa 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Customization/GenericTab/GenericTab.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Customization/GenericTab/GenericTab.tsx @@ -81,6 +81,7 @@ export const GenericTab = ({ type }: GenericTabProps) => { verticalCompact className={classNames('grid-container bg-grey', { 'custom-tab': !leftSideWidgetPresent, + 'height-auto': type === PageType.Glossary, })} cols={8} containerPadding={[0, 0]} diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Customization/GenericTab/generic-tab.less b/openmetadata-ui/src/main/resources/ui/src/components/Customization/GenericTab/generic-tab.less index 7ca61a43c3e..0f25a58fe9b 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Customization/GenericTab/generic-tab.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/Customization/GenericTab/generic-tab.less @@ -15,7 +15,6 @@ .grid-container { position: relative; - height: auto !important; .react-grid-item { background: transparent; @@ -65,3 +64,7 @@ min-height: 54px; // Minimum height to prevent collapse overflow: visible; } + +.height-auto { + height: auto !important; +} diff --git a/openmetadata-ui/src/main/resources/ui/src/components/MyData/CustomizableComponents/CustomiseLandingPageHeader/CustomiseLandingPageHeader.tsx b/openmetadata-ui/src/main/resources/ui/src/components/MyData/CustomizableComponents/CustomiseLandingPageHeader/CustomiseLandingPageHeader.tsx index b907f5d0f96..0e814d4bcbf 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/MyData/CustomizableComponents/CustomiseLandingPageHeader/CustomiseLandingPageHeader.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/MyData/CustomizableComponents/CustomiseLandingPageHeader/CustomiseLandingPageHeader.tsx @@ -243,8 +243,31 @@ const CustomiseLandingPageHeader = ({ infinite={false} nextArrow={} prevArrow={} - slidesToScroll={6} - slidesToShow={6}> + responsive={[ + { + breakpoint: 1900, + settings: { + slidesToShow: 8, + slidesToScroll: 8, + }, + }, + { + breakpoint: 1600, + settings: { + slidesToShow: 6, + slidesToScroll: 6, + }, + }, + { + breakpoint: 1300, + settings: { + slidesToShow: 4, + slidesToScroll: 4, + }, + }, + ]} + slidesToScroll={10} + slidesToShow={10}> {recentlyViewData.map((data, index) => (
{data.name} diff --git a/openmetadata-ui/src/main/resources/ui/src/components/MyData/Widgets/Common/WidgetHeader/WidgetHeader.tsx b/openmetadata-ui/src/main/resources/ui/src/components/MyData/Widgets/Common/WidgetHeader/WidgetHeader.tsx index e441d7de268..04df4dd8de1 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/MyData/Widgets/Common/WidgetHeader/WidgetHeader.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/MyData/Widgets/Common/WidgetHeader/WidgetHeader.tsx @@ -91,7 +91,9 @@ const WidgetHeader = ({ data-testid="widget-header" justify="space-between"> - {icon &&
{icon}
} + {icon && ( +
{icon}
+ )} { expect(result).toHaveLength(1); expect(result[0].i).toBe('ExtraWidget.EmptyWidgetPlaceholder'); - expect(result[0].h).toBe(4); + expect(result[0].h).toBe(2); }); it('should add placeholder to existing layout', () => { diff --git a/openmetadata-ui/src/main/resources/ui/src/utils/CustomizableLandingPageUtils.tsx b/openmetadata-ui/src/main/resources/ui/src/utils/CustomizableLandingPageUtils.tsx index aaee9cba671..0ac4e4092cd 100644 --- a/openmetadata-ui/src/main/resources/ui/src/utils/CustomizableLandingPageUtils.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/utils/CustomizableLandingPageUtils.tsx @@ -444,25 +444,19 @@ export const CustomPrevArrow = (props: DOMAttributes) => ( */ export const getLayoutWithEmptyWidgetPlaceholder = ( layout: WidgetConfig[], - emptyWidgetHeight = 4, + emptyWidgetHeight = 2, emptyWidgetWidth = 1 -) => { - // Handle empty or null layout - if (!layout || layout.length === 0) { - return [ - { - h: emptyWidgetHeight, - i: LandingPageWidgetKeys.EMPTY_WIDGET_PLACEHOLDER, - w: emptyWidgetWidth, - x: 0, - y: 0, - isDraggable: false, - }, - ]; - } - - return ensurePlaceholderAtEnd(layout); -}; +) => [ + ...layout, + { + h: emptyWidgetHeight, + i: LandingPageWidgetKeys.EMPTY_WIDGET_PLACEHOLDER, + w: emptyWidgetWidth, + x: 0, + y: 1000, + isDraggable: false, + }, +]; /** * Creates a landing page layout with empty widget placeholder