From ac6b192fb3e22385b6e7a221fdf779760cf0b38a Mon Sep 17 00:00:00 2001
From: IceS2 <pjt1991@gmail.com>
Date: Wed, 21 Aug 2024 11:10:12 +0200
Subject: [PATCH] MINOR: Fix pydantic v2 issues with domo (#17507)

* Fix pydantic v2 issues with domo

* Fix sourceURL for domo charts
---
 ingestion/src/metadata/clients/domo_client.py               | 2 +-
 .../ingestion/source/dashboard/domodashboard/metadata.py    | 6 +++---
 .../ingestion/source/pipeline/domopipeline/metadata.py      | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/ingestion/src/metadata/clients/domo_client.py b/ingestion/src/metadata/clients/domo_client.py
index 948e01639a0..ebf8565d361 100644
--- a/ingestion/src/metadata/clients/domo_client.py
+++ b/ingestion/src/metadata/clients/domo_client.py
@@ -126,7 +126,7 @@ class DomoClient:
 
             if isinstance(response, list) and len(response) > 0:
                 return DomoChartDetails(
-                    id=response[0]["id"],
+                    id=str(response[0]["id"]),
                     name=response[0]["title"],
                     metadata=DomoChartMetadataDetails(
                         chartType=response[0].get("metadata", {}).get("chartType", "")
diff --git a/ingestion/src/metadata/ingestion/source/dashboard/domodashboard/metadata.py b/ingestion/src/metadata/ingestion/source/dashboard/domodashboard/metadata.py
index 30080f5ba04..2b8322b0dce 100644
--- a/ingestion/src/metadata/ingestion/source/dashboard/domodashboard/metadata.py
+++ b/ingestion/src/metadata/ingestion/source/dashboard/domodashboard/metadata.py
@@ -185,7 +185,7 @@ class DomodashboardSource(DashboardServiceSource):
             pages = self.client.domo.page_get(page_id)
             return DomoDashboardDetails(
                 name=pages["name"],
-                id=pages["id"],
+                id=str(pages["id"]),
                 cardIds=pages.get("cardIds", []),
                 description=pages.get("description", ""),
                 collectionIds=pages.get("collectionIds", []),
@@ -217,7 +217,7 @@ class DomodashboardSource(DashboardServiceSource):
             try:
                 chart = self.client.custom.get_chart_details(page_id=chart_id)
                 chart_url = (
-                    f"{self.service_connection.instanceDomain}/page/"
+                    f"{self.service_connection.instanceDomain}page/"
                     f"{dashboard_details.id}/kpis/details/{chart_id}"
                 )
 
@@ -227,7 +227,7 @@ class DomodashboardSource(DashboardServiceSource):
                 if chart.name:
                     yield Either(
                         right=CreateChartRequest(
-                            name=EntityName(chart_id),
+                            name=EntityName(str(chart_id)),
                             description=Markdown(chart.description)
                             if chart.description
                             else None,
diff --git a/ingestion/src/metadata/ingestion/source/pipeline/domopipeline/metadata.py b/ingestion/src/metadata/ingestion/source/pipeline/domopipeline/metadata.py
index c34dbc0515f..e2197bf41bb 100644
--- a/ingestion/src/metadata/ingestion/source/pipeline/domopipeline/metadata.py
+++ b/ingestion/src/metadata/ingestion/source/pipeline/domopipeline/metadata.py
@@ -89,7 +89,7 @@ class DomopipelineSource(PipelineServiceSource):
         self, pipeline_details
     ) -> Iterable[Either[CreatePipelineRequest]]:
         try:
-            pipeline_name = pipeline_details["id"]
+            pipeline_name = str(pipeline_details["id"])
             source_url = self.get_source_url(pipeline_id=pipeline_name)
             task = Task(
                 name=pipeline_name,