yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-07-24 17:59:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix unwanted value in container data asset header (#14593)

Browse Source
This commit is contained in:
Ashish Gupta 2024-01-08 12:57:03 +05:30 committed by GitHub
parent 267fbfa97d
commit acee4fecc2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
openmetadata-ui/src/main/resources/ui/src/utils/DataAssetsHeader.utils.test.tsx
View File

@ -400,6 +400,28 @@ describe('Tests for DataAssetsHeaderUtils', () => {
expect(JSON.stringify(assetData.extraInfo)).toContain('label.size');
expect(JSON.stringify(assetData.extraInfo)).toContain('bytesToSize');
// If Data has 0 as a value,it should display them
const assetWithZeroData = getDataAssetsHeaderInfo(
EntityType.CONTAINER,
{
...mockContainerData,
dataModel: {
...mockContainerData.dataModel,
isPartitioned: true,
},
numberOfObjects: 0,
size: 0,
},
'container',
[]
);
expect(JSON.stringify(assetWithZeroData.extraInfo)).toContain(
'label.number-of-object-plural'
);
expect(JSON.stringify(assetWithZeroData.extraInfo)).toContain('label.size');
// If Data does not present
const assetWithNoExtraData = getDataAssetsHeaderInfo(
EntityType.CONTAINER,

4
openmetadata-ui/src/main/resources/ui/src/utils/DataAssetsHeader.utils.tsx
View File

@ -219,13 +219,13 @@ export const getDataAssetsHeaderInfo = (
}
/>
)}
{containerDetails.numberOfObjects && (
{!isUndefined(containerDetails.numberOfObjects) && (
<ExtraInfoLabel
label={t('label.number-of-object-plural')}
value={containerDetails.numberOfObjects}
/>
)}
{containerDetails.size && (
{!isUndefined(containerDetails.size) && (
<ExtraInfoLabel
label={t('label.size')}
value={bytesToSize(containerDetails.size)}