From acee4fecc25ba8eec91ea636c39f7bd2cf6dcc99 Mon Sep 17 00:00:00 2001 From: Ashish Gupta Date: Mon, 8 Jan 2024 12:57:03 +0530 Subject: [PATCH] fix unwanted value in container data asset header (#14593) --- .../src/utils/DataAssetsHeader.utils.test.tsx | 22 +++++++++++++++++++ .../ui/src/utils/DataAssetsHeader.utils.tsx | 4 ++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/src/utils/DataAssetsHeader.utils.test.tsx b/openmetadata-ui/src/main/resources/ui/src/utils/DataAssetsHeader.utils.test.tsx index 058192c1116..eaddaf8c4f1 100644 --- a/openmetadata-ui/src/main/resources/ui/src/utils/DataAssetsHeader.utils.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/utils/DataAssetsHeader.utils.test.tsx @@ -400,6 +400,28 @@ describe('Tests for DataAssetsHeaderUtils', () => { expect(JSON.stringify(assetData.extraInfo)).toContain('label.size'); expect(JSON.stringify(assetData.extraInfo)).toContain('bytesToSize'); + // If Data has 0 as a value,it should display them + const assetWithZeroData = getDataAssetsHeaderInfo( + EntityType.CONTAINER, + { + ...mockContainerData, + dataModel: { + ...mockContainerData.dataModel, + isPartitioned: true, + }, + numberOfObjects: 0, + size: 0, + }, + 'container', + [] + ); + + expect(JSON.stringify(assetWithZeroData.extraInfo)).toContain( + 'label.number-of-object-plural' + ); + + expect(JSON.stringify(assetWithZeroData.extraInfo)).toContain('label.size'); + // If Data does not present const assetWithNoExtraData = getDataAssetsHeaderInfo( EntityType.CONTAINER, diff --git a/openmetadata-ui/src/main/resources/ui/src/utils/DataAssetsHeader.utils.tsx b/openmetadata-ui/src/main/resources/ui/src/utils/DataAssetsHeader.utils.tsx index 7604e713a9a..88e304f0187 100644 --- a/openmetadata-ui/src/main/resources/ui/src/utils/DataAssetsHeader.utils.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/utils/DataAssetsHeader.utils.tsx @@ -219,13 +219,13 @@ export const getDataAssetsHeaderInfo = ( } /> )} - {containerDetails.numberOfObjects && ( + {!isUndefined(containerDetails.numberOfObjects) && ( )} - {containerDetails.size && ( + {!isUndefined(containerDetails.size) && (