From af134d4afc7985ba86fe3fc9a4d83d480b2093fd Mon Sep 17 00:00:00 2001
From: Pere Miquel Brull
Date: Thu, 9 Dec 2021 17:08:39 +0100
Subject: [PATCH] Simplify service create or update (#1648)
---
ingestion/src/metadata/ingestion/ometa/ometa_api.py | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/ingestion/src/metadata/ingestion/ometa/ometa_api.py b/ingestion/src/metadata/ingestion/ometa/ometa_api.py
index 8b2a21465d1..e2fc58022bf 100644
--- a/ingestion/src/metadata/ingestion/ometa/ometa_api.py
+++ b/ingestion/src/metadata/ingestion/ometa/ometa_api.py
@@ -316,8 +316,7 @@ class OpenMetadata(OMetaLineageMixin, OMetaTableMixin, Generic[T, C]):
"""
entity = data.__class__
- is_create = "create" in entity.__name__.lower()
- is_service = "service" in entity.__name__.lower()
+ is_create = "create" in data.__class__.__name__.lower()
# Prepare the return Entity Type
if is_create:
@@ -327,14 +326,7 @@ class OpenMetadata(OMetaLineageMixin, OMetaTableMixin, Generic[T, C]):
f"PUT operations need a CrateEntity, not {entity}"
)
- # Prepare the request method
- if is_service and is_create:
- # Services can only be created via POST
- method = self.client.post
- else:
- method = self.client.put
-
- resp = method(self.get_suffix(entity), data=data.json())
+ resp = self.client.put(self.get_suffix(entity), data=data.json())
return entity_class(**resp)
@staticmethod