yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-11 00:11:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Handle NullPointerException when adding custom properties to ensure loop continues for other schemas of the same type for addToRegistry (#18088)

Browse Source
This commit is contained in:
sonika-shah 2024-10-03 13:25:46 +05:30 committed by GitHub
parent 1886132f41
commit b003e1d600
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openmetadata-service/src/main/java/org/openmetadata/service/TypeRegistry.java
View File

@ -69,10 +69,16 @@ public class TypeRegistry {
String customPropertyFQN = getCustomPropertyFQN(entityType, propertyName); String customPropertyFQN = getCustomPropertyFQN(entityType, propertyName);
CUSTOM_PROPERTIES.put(customPropertyFQN, customProperty); CUSTOM_PROPERTIES.put(customPropertyFQN, customProperty);
try {
JsonSchema jsonSchema = JsonSchema jsonSchema =
JsonUtils.getJsonSchema(TYPES.get(customProperty.getPropertyType().getName()).getSchema()); JsonUtils.getJsonSchema(
TYPES.get(customProperty.getPropertyType().getName()).getSchema());
CUSTOM_PROPERTY_SCHEMAS.put(customPropertyFQN, jsonSchema); CUSTOM_PROPERTY_SCHEMAS.put(customPropertyFQN, jsonSchema);
LOG.info("Adding custom property {} with JSON schema {}", customPropertyFQN, jsonSchema); LOG.info("Adding custom property {} with JSON schema {}", customPropertyFQN, jsonSchema);
} catch (Exception e) {
CUSTOM_PROPERTIES.remove(customPropertyFQN);
LOG.info("Failed to add custom property {}: {}", customPropertyFQN, e.getMessage());
}
} }
public JsonSchema getSchema(String entityType, String propertyName) { public JsonSchema getSchema(String entityType, String propertyName) {