#3285: Feedback on Glossaries feature/UI (Part 1) (#3288)

This commit is contained in:
Vivek Ratnavel Subramanian 2022-03-08 21:36:37 -08:00 committed by GitHub
parent adbf53c652
commit b156e68af0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 26 additions and 18 deletions

View File

@ -467,7 +467,7 @@ const AddGlossaryTerm = ({
{showRevieweModal && (
<ReviewerModal
header="Add Reviewer"
header="Add Reviewers"
reviewer={reviewer}
onCancel={onReviewerModalCancel}
onSave={handleReviewerSave}

View File

@ -202,7 +202,7 @@ Props) => {
showLoadingStatus
placeholder="Search term..."
searchValue={searchText}
typingInterval={1500}
typingInterval={500}
onSearch={handleSearchText}
/>
@ -268,7 +268,7 @@ Props) => {
{showActions && (
<DropDownList
horzPosRight
dropDownList={getActionsList(selectedData.name)}
dropDownList={getActionsList()}
onSelect={handleSelectedAction}
/>
)}

View File

@ -55,7 +55,7 @@ const GlossaryDetails = ({ isHasAccess, glossary, updateGlossary }: props) => {
const tabs = [
{
name: 'Reviewer',
name: 'Reviewers',
icon: {
alt: 'schema',
name: 'icon-schema',
@ -218,7 +218,7 @@ const GlossaryDetails = ({ isHasAccess, glossary, updateGlossary }: props) => {
</div>
) : (
<ErrorPlaceHolder>
<p className="tw-text-base tw-text-center">No Reviewer Added.</p>
<p className="tw-text-base tw-text-center">No Reviewers.</p>
<p className="tw-text-lg tw-text-center tw-mt-2">{rightPosButton()}</p>
</ErrorPlaceHolder>
);

View File

@ -378,7 +378,7 @@ const GlossaryTermsV1 = ({
</div>
<div className="tw-flex tw-gap-5 tw-mb-2">
<div className="tw-font-medium">Reference</div>
<div className="tw-font-medium">References</div>
<div className="tw-flex tw-group">
<div>
{references && references.length ? (

View File

@ -68,7 +68,7 @@ const RelatedTermsModal = ({
const suggestionSearch = (searchText = '') => {
setIsLoading(true);
getSuggestions(searchText, SearchIndex.USER)
getSuggestions(searchText, SearchIndex.GLOSSARY)
.then((res: AxiosResponse) => {
const data = formatSearchGlossaryTermResponse(
res.data.suggest['table-suggest'][0].options
@ -139,9 +139,9 @@ const RelatedTermsModal = ({
</div>
<div className="tw-modal-body">
<Searchbar
placeholder="Search for user..."
placeholder="Search for a term..."
searchValue={searchText}
typingInterval={1500}
typingInterval={500}
onSearch={handleSearchAction}
/>
<div className="tw-min-h-256">
@ -153,7 +153,7 @@ const RelatedTermsModal = ({
</div>
) : (
<p className="tw-text-center tw-mt-10 tw-text-grey-muted tw-text-base">
No terms available
No terms found. Update the search query and try again.
</p>
)}
</div>

View File

@ -142,7 +142,7 @@ const ReviewerModal = ({
<Searchbar
placeholder="Search for user..."
searchValue={searchText}
typingInterval={1500}
typingInterval={500}
onSearch={handleSearchAction}
/>
<div className="tw-min-h-256">

View File

@ -8,3 +8,15 @@
.rc-tree-switcher {
background-image: none !important;
}
.rc-tree-node-content-wrapper {
margin-left: 3px !important;
}
.rc-tree-node-content-wrapper:hover {
color: rgb(113, 71, 232);
}
.rc-tree-node-content-wrapper:not(.rc-tree-node-selected):hover .rc-tree-title {
text-decoration: underline !important;
}

View File

@ -101,10 +101,10 @@ const AddUsersModal = ({
<div className="tw-modal-body">
<Searchbar
placeholder={
searchPlaceHolder ? searchPlaceHolder : 'Search for user...'
searchPlaceHolder ? searchPlaceHolder : 'Search for a user...'
}
searchValue={searchText}
typingInterval={1500}
typingInterval={500}
onSearch={handleSearchAction}
/>
<div className="tw-grid tw-grid-cols-3 tw-gap-4">

View File

@ -118,16 +118,12 @@ export const updateGlossaryListBySearchedTerms = (
}, [] as ModifiedGlossaryData[]);
};
export const getActionsList = (name = '') => {
export const getActionsList = () => {
return [
{
name: 'Add Term',
value: 'add_term',
},
{
name: `Delete ${name}`,
value: 'delete',
},
];
};