From b156e68af0d7a43077709590bdecf3d9e0dcd8c1 Mon Sep 17 00:00:00 2001 From: Vivek Ratnavel Subramanian Date: Tue, 8 Mar 2022 21:36:37 -0800 Subject: [PATCH] #3285: Feedback on Glossaries feature/UI (Part 1) (#3288) --- .../AddGlossaryTerm/AddGlossaryTerm.component.tsx | 2 +- .../src/components/Glossary/GlossaryV1.component.tsx | 4 ++-- .../GlossaryDetails/GlossaryDetails.component.tsx | 4 ++-- .../GlossaryTerms/GlossaryTermsV1.component.tsx | 2 +- .../Modals/RelatedTermsModal/RelatedTermsModal.tsx | 8 ++++---- .../Modals/ReviewerModal/ReviewerModal.component.tsx | 2 +- .../ui/src/components/common/TreeView/treeView.css | 12 ++++++++++++ .../resources/ui/src/pages/teams/AddUsersModal.tsx | 4 ++-- .../src/main/resources/ui/src/utils/GlossaryUtils.ts | 6 +----- 9 files changed, 26 insertions(+), 18 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/src/components/AddGlossaryTerm/AddGlossaryTerm.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/AddGlossaryTerm/AddGlossaryTerm.component.tsx index e22e269874c..c7bd06cf8e6 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/AddGlossaryTerm/AddGlossaryTerm.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/AddGlossaryTerm/AddGlossaryTerm.component.tsx @@ -467,7 +467,7 @@ const AddGlossaryTerm = ({ {showRevieweModal && ( { showLoadingStatus placeholder="Search term..." searchValue={searchText} - typingInterval={1500} + typingInterval={500} onSearch={handleSearchText} /> @@ -268,7 +268,7 @@ Props) => { {showActions && ( )} diff --git a/openmetadata-ui/src/main/resources/ui/src/components/GlossaryDetails/GlossaryDetails.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/GlossaryDetails/GlossaryDetails.component.tsx index ad721bb1615..80614c70a2a 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/GlossaryDetails/GlossaryDetails.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/GlossaryDetails/GlossaryDetails.component.tsx @@ -55,7 +55,7 @@ const GlossaryDetails = ({ isHasAccess, glossary, updateGlossary }: props) => { const tabs = [ { - name: 'Reviewer', + name: 'Reviewers', icon: { alt: 'schema', name: 'icon-schema', @@ -218,7 +218,7 @@ const GlossaryDetails = ({ isHasAccess, glossary, updateGlossary }: props) => { ) : ( -

No Reviewer Added.

+

No Reviewers.

{rightPosButton()}

 ); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/GlossaryTerms/GlossaryTermsV1.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/GlossaryTerms/GlossaryTermsV1.component.tsx index e89dbf6d008..f6c56f17b1c 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/GlossaryTerms/GlossaryTermsV1.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/GlossaryTerms/GlossaryTermsV1.component.tsx @@ -378,7 +378,7 @@ const GlossaryTermsV1 = ({
-
Reference
+
References
{references && references.length ? ( diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Modals/RelatedTermsModal/RelatedTermsModal.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Modals/RelatedTermsModal/RelatedTermsModal.tsx index f15279094c7..f906e7594db 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Modals/RelatedTermsModal/RelatedTermsModal.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Modals/RelatedTermsModal/RelatedTermsModal.tsx @@ -68,7 +68,7 @@ const RelatedTermsModal = ({ const suggestionSearch = (searchText = '') => { setIsLoading(true); - getSuggestions(searchText, SearchIndex.USER) + getSuggestions(searchText, SearchIndex.GLOSSARY) .then((res: AxiosResponse) => { const data = formatSearchGlossaryTermResponse( res.data.suggest['table-suggest'][0].options @@ -139,9 +139,9 @@ const RelatedTermsModal = ({
@@ -153,7 +153,7 @@ const RelatedTermsModal = ({
) : (

- No terms available + No terms found. Update the search query and try again.

)}
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Modals/ReviewerModal/ReviewerModal.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Modals/ReviewerModal/ReviewerModal.component.tsx index ea3f6f760c2..78ad029887a 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Modals/ReviewerModal/ReviewerModal.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Modals/ReviewerModal/ReviewerModal.component.tsx @@ -142,7 +142,7 @@ const ReviewerModal = ({
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/TreeView/treeView.css b/openmetadata-ui/src/main/resources/ui/src/components/common/TreeView/treeView.css index 0bf7c24265f..63c533777d3 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/TreeView/treeView.css +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/TreeView/treeView.css @@ -8,3 +8,15 @@ .rc-tree-switcher { background-image: none !important; } + +.rc-tree-node-content-wrapper { + margin-left: 3px !important; +} + +.rc-tree-node-content-wrapper:hover { + color: rgb(113, 71, 232); +} + +.rc-tree-node-content-wrapper:not(.rc-tree-node-selected):hover .rc-tree-title { + text-decoration: underline !important; +} diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/teams/AddUsersModal.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/teams/AddUsersModal.tsx index 297f23a943e..9ca57c1cfbb 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/teams/AddUsersModal.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/teams/AddUsersModal.tsx @@ -101,10 +101,10 @@ const AddUsersModal = ({
diff --git a/openmetadata-ui/src/main/resources/ui/src/utils/GlossaryUtils.ts b/openmetadata-ui/src/main/resources/ui/src/utils/GlossaryUtils.ts index 7d6e82f457b..d3c05369461 100644 --- a/openmetadata-ui/src/main/resources/ui/src/utils/GlossaryUtils.ts +++ b/openmetadata-ui/src/main/resources/ui/src/utils/GlossaryUtils.ts @@ -118,16 +118,12 @@ export const updateGlossaryListBySearchedTerms = ( }, [] as ModifiedGlossaryData[]); }; -export const getActionsList = (name = '') => { +export const getActionsList = () => { return [ { name: 'Add Term', value: 'add_term', }, - { - name: `Delete ${name}`, - value: 'delete', - }, ]; };