yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-01 05:03:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: fix the reviewer placeholder container multiple no (#20886)

Browse Source 
* fix the reviewer placeholder container multiple no

* fix unit test
This commit is contained in:
Ashish Gupta 2025-04-17 19:11:47 +05:30 committed by GitHub
parent 598699eef3
commit b17c9be06d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openmetadata-ui/src/main/resources/ui/src/components/DataQuality/IncidentManager/IncidentManagerPageHeader/IncidentManagerPageHeader.component.tsx
View File

@ -284,7 +284,9 @@ const IncidentManagerPageHeader = ({
team: false, team: false,
}} }}
owners={details?.assignee ? [details.assignee] : []} owners={details?.assignee ? [details.assignee] : []}
placeHolder={t('label.assignee')} placeHolder={t('label.no-entity', {
entity: t('label.assignee'),
})}
tooltipText={t('label.edit-entity', { tooltipText={t('label.edit-entity', {
entity: t('label.assignee'), entity: t('label.assignee'),
})} })}

2
openmetadata-ui/src/main/resources/ui/src/components/DataQuality/IncidentManager/IncidentManagerPageHeader/IncidentManagerPageHeader.test.tsx
View File

@ -276,7 +276,7 @@ describe('Incident Manager Page Header component', () => {
screen.getByText('TestCaseIncidentManagerStatus.component') screen.getByText('TestCaseIncidentManagerStatus.component')
).toBeInTheDocument(); ).toBeInTheDocument();
// Assignee // Assignee
expect(screen.getByText('label.assignee')).toBeInTheDocument(); expect(screen.getByTestId('assignee')).toBeInTheDocument();
// Severity // Severity
expect(screen.getByText('label.severity')).toBeInTheDocument(); expect(screen.getByText('label.severity')).toBeInTheDocument();
expect(screen.getByText('Severity.component')).toBeInTheDocument(); expect(screen.getByText('Severity.component')).toBeInTheDocument();

5
openmetadata-ui/src/main/resources/ui/src/components/common/NoOwner/NoOwnerFound.tsx
View File

@ -86,9 +86,8 @@ export const NoOwnerFound: React.FC<NoOwnerFoundProps> = ({
{!isCompactView && ( {!isCompactView && (
<div className="no-owner-text text-sm font-medium"> <div className="no-owner-text text-sm font-medium">
{t('label.no-entity', { {placeHolder ??
entity: placeHolder ?? t('label.owner-plural'), t('label.no-entity', { entity: t('label.owner-plural') })}
})}
</div> </div>
)} )}
</div> </div>