yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-24 08:58:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #4511: Hide the test connection button for Sample Data. (#4669)

Browse Source
This commit is contained in:
darth-coder00 2022-05-04 05:28:36 +05:30 committed by GitHub
parent 78da4ca2e6
commit b4dcbeeaa1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
openmetadata-ui/src/main/resources/ui/src/components/AddService/AddService.component.tsx
View File

@ -214,6 +214,7 @@ const AddService = ({
: {}) as DataService
}
serviceCategory={serviceCategory}
serviceType={selectServiceType}
status={saveServiceState}
onCancel={handleConnectionDetailsBackClick}
onSave={(e) => {

9
openmetadata-ui/src/main/resources/ui/src/components/ServiceConfig/ConnectionConfigForm.tsx
View File

@ -24,6 +24,7 @@ import {
import {
DatabaseConnection,
DatabaseService,
DatabaseServiceType,
} from '../../generated/entity/services/databaseService';
import {
MessagingConnection,
@ -44,6 +45,7 @@ interface Props {
data: DatabaseService | MessagingService | DashboardService | PipelineService;
okText?: string;
cancelText?: string;
serviceType: string;
serviceCategory: ServiceCategory;
status: LoadingState;
onCancel?: () => void;
@ -54,6 +56,7 @@ const ConnectionConfigForm: FunctionComponent<Props> = ({
data,
okText = 'Save',
cancelText = 'Cancel',
serviceType,
serviceCategory,
status,
onCancel,
@ -149,7 +152,11 @@ const ConnectionConfigForm: FunctionComponent<Props> = ({
uiSchema={connSch.uiSchema}
onCancel={onCancel}
onSubmit={handleSave}
onTestConnection={handleTestConnection}
onTestConnection={
serviceType !== DatabaseServiceType.SampleData
? handleTestConnection
: undefined
}
/>
);
};

3
openmetadata-ui/src/main/resources/ui/src/components/ServiceConfig/ServiceConfig.tsx
View File

@ -24,6 +24,7 @@ import ConnectionConfigForm from './ConnectionConfigForm';
interface ServiceConfigProps {
serviceCategory: ServiceCategory;
serviceType: string;
data?: ServicesData;
handleUpdate: (
data: ConfigData,
@ -37,6 +38,7 @@ export const Field = ({ children }: { children: React.ReactNode }) => {
const ServiceConfig = ({
serviceCategory,
serviceType,
data,
handleUpdate,
}: ServiceConfigProps) => {
@ -69,6 +71,7 @@ const ServiceConfig = ({
| PipelineService
}
serviceCategory={serviceCategory}
serviceType={serviceType}
status={status}
onSave={handleOnSaveClick}
/>

1
openmetadata-ui/src/main/resources/ui/src/pages/service/index.tsx
View File

@ -999,6 +999,7 @@ const ServicePage: FunctionComponent = () => {
data={serviceDetails as ServicesData}
handleUpdate={handleConfigUpdate}
serviceCategory={serviceName as ServiceCategory}
serviceType={serviceDetails?.serviceType || ''}
/>
)}