yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-31 04:14:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: handle potential null pointer in test case reindex (#17100)

Browse Source
This commit is contained in:
Teddy 2024-07-19 13:07:48 +02:00 committed by GitHub
parent b1abb7cced
commit b568444d5e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
openmetadata-service/src/main/java/org/openmetadata/service/search/indexes/TestCaseIndex.java
View File

@ -26,8 +26,10 @@ public record TestCaseIndex(TestCase testCase) implements SearchIndex {
public void removeNonIndexableFields(Map<String, Object> esDoc) { public void removeNonIndexableFields(Map<String, Object> esDoc) {
SearchIndex.super.removeNonIndexableFields(esDoc); SearchIndex.super.removeNonIndexableFields(esDoc);
List<Map<String, Object>> testSuites = (List<Map<String, Object>>) esDoc.get("testSuites"); List<Map<String, Object>> testSuites = (List<Map<String, Object>>) esDoc.get("testSuites");
for (Map<String, Object> testSuite : testSuites) { if (testSuites != null) {
SearchIndexUtils.removeNonIndexableFields(testSuite, excludeFields); for (Map<String, Object> testSuite : testSuites) {
SearchIndexUtils.removeNonIndexableFields(testSuite, excludeFields);
}
} }
} }

6
openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java
View File

@ -2049,6 +2049,12 @@ public class TestCaseResourceTest extends EntityResourceTest<TestCase, CreateTes
assertNull(doc.get("changeDescription")); assertNull(doc.get("changeDescription"));
List<Map<String, Object>> testSuites = (List<Map<String, Object>>) doc.get("testSuites"); List<Map<String, Object>> testSuites = (List<Map<String, Object>>) doc.get("testSuites");
assertNull(testSuites.get(0).get("changeDescription")); assertNull(testSuites.get(0).get("changeDescription"));
// Remove changeDescription logic handles null testSuites
testCase.setTestSuites(null);
doc = JsonUtils.convertValue(testCase, Map.class);
testCaseIndex = new TestCaseIndex(testCase);
testCaseIndex.removeNonIndexableFields(doc);
} }
public void deleteTestCaseResult(String fqn, Long timestamp, Map<String, String> authHeaders) public void deleteTestCaseResult(String fqn, Long timestamp, Map<String, String> authHeaders)