yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-30 01:59:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed NaN values in Cost Analysis aggregate APIs (#13708)

Browse Source 
* fixed nan in aggregations

* review comments
This commit is contained in:
Onkar Ravgan 2023-10-26 00:18:05 +05:30 committed by GitHub
parent 452a33b1a0
commit b89f5eaad0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
openmetadata-service/src/main/java/org/openmetadata/service/dataInsight/AggregatedUsedvsUnusedAssetsCountAggregator.java
View File

@ -26,9 +26,12 @@ public abstract class AggregatedUsedvsUnusedAssetsCountAggregator<A, H, B, S>
Double used = Objects.requireNonNullElse(getValue(totalUsed), 0.0);
Double unused = Objects.requireNonNullElse(getValue(totalUnused), 0.0);
Double total = used + unused;
Double usedPercentage = used / total;
Double unusedPercentage = unused / total;
Double usedPercentage = 0.0;
Double unusedPercentage = 0.0;
if (total != 0.0) {
usedPercentage = used / total;
unusedPercentage = unused / total;
}
data.add(
new AggregatedUsedVsUnusedAssetsCount()
.withTimestamp(timestamp)

9
openmetadata-service/src/main/java/org/openmetadata/service/dataInsight/AggregatedUsedvsUnusedAssetsSizeAggregator.java
View File

@ -25,9 +25,12 @@ public abstract class AggregatedUsedvsUnusedAssetsSizeAggregator<A, H, B, S> imp
Double used = Objects.requireNonNullElse(getValue(totalUsed), 0.0);
Double unused = Objects.requireNonNullElse(getValue(totalUnused), 0.0);
Double total = used + unused;
Double usedPercentage = used / total;
Double unusedPercentage = unused / total;
Double usedPercentage = 0.0;
Double unusedPercentage = 0.0;
if (total != 0.0) {
usedPercentage = used / total;
unusedPercentage = unused / total;
}
data.add(
new AggregatedUsedVsUnusedAssetsSize()
.withTimestamp(timestamp)