yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-24 14:45:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Fixed incorrect re-direction link in mention tab (#24025)

Browse Source 
* Fix: Fixed incorrect re-direction link in mention tab

* Fix: minor fix
This commit is contained in:
Rohit Jain 2025-10-28 19:17:03 +05:30 committed by GitHub
parent a34f50a6d0
commit b94d3be456
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.component.tsx
View File

@ -73,6 +73,7 @@ const NotificationBox = ({
let actualUser = mainFeed.from;
let actualTimestamp = mainFeed.postTs;
let feedType = feed.type || ThreadType.Conversation;
const isConversationFeed = feed.type === ThreadType.Conversation;
if (
activeTab === ThreadType.Conversation &&
@ -100,6 +101,7 @@ const NotificationBox = ({
entityFQN={entityFQN as string}
entityType={entityType as string}
feedType={feedType}
isConversationFeed={isConversationFeed}
key={`${actualUser} ${mainFeed.id}`}
task={feed}
timestamp={actualTimestamp}

3
openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationFeedCard.component.tsx
View File

@ -37,6 +37,7 @@ const NotificationFeedCard: FC<NotificationFeedProp> = ({
timestamp,
feedType,
task,
isConversationFeed = false,
}) => {
const { t } = useTranslation();
const { task: taskDetails } = task ?? {};
@ -95,7 +96,7 @@ const NotificationFeedCard: FC<NotificationFeedProp> = ({
<Link
className="no-underline"
to={
feedType === ThreadType.Conversation
isConversationFeed
? prepareFeedLink(entityType, entityFQN, ActivityFeedTabs.ALL)
: getTaskDetailPath(task)
}>

1
openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationFeedCard.interface.tsx
View File

@ -21,4 +21,5 @@ export interface NotificationFeedProp
entityType: string;
entityFQN: string;
timestamp?: number;
isConversationFeed?: boolean;
}

21
openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationFeedCard.test.tsx
View File

@ -224,6 +224,7 @@ describe('Test NotificationFeedCard Component', () => {
const conversationProps = {
...mockProps,
feedType: ThreadType.Conversation,
isConversationFeed: true,
};
await act(async () => {
@ -243,6 +244,25 @@ describe('Test NotificationFeedCard Component', () => {
expect(linkElement).toHaveAttribute('data-to', conversationUrl);
});
it('should call getTaskDetailPath for task feed entity links in mention notifications tab', async () => {
const entityLinkUrl = '/database/test.entity/activity_feed/all';
mockPrepareFeedLink.mockReturnValue(entityLinkUrl);
const conversationProps = {
...mockProps,
feedType: ThreadType.Conversation,
isConversationFeed: false,
};
await act(async () => {
render(<NotificationFeedCard {...conversationProps} />);
});
// Should be called twice - once for main link, once for entity name link
expect(mockGetTaskDetailPath).toHaveBeenCalledTimes(2);
expect(mockGetTaskDetailPath).toHaveBeenCalledWith(mockThread);
});
it('should call prepareFeedLink with ALL subtab for entity links in conversation notifications', async () => {
const entityLinkUrl = '/database/test.entity/activity_feed/all';
mockPrepareFeedLink.mockReturnValue(entityLinkUrl);
@ -250,6 +270,7 @@ describe('Test NotificationFeedCard Component', () => {
const conversationProps = {
...mockProps,
feedType: ThreadType.Conversation,
isConversationFeed: true,
};
await act(async () => {