yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-04 04:29:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor: Fix Superset Dashboard Lineage Handling (#20207)

Browse Source 
* Fix Superset Dashboard Lineage Handling

- Safely handle chart SQL attribute using getattr
- Update error message for dashboard lineage details to be more generic

* refactor: formatting improvement in Superset dashboard lineage handling
This commit is contained in:
Ayush Shah 2025-03-12 23:42:10 +05:30 committed by GitHub
parent a47d725975
commit b9540b0c7d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ingestion/src/metadata/ingestion/source/dashboard/superset/mixin.py
View File

@ -282,7 +282,7 @@ class SupersetSourceMixin(DashboardServiceSource):
return result return result
def _get_input_tables(self, chart: FetchChart): def _get_input_tables(self, chart: FetchChart):
if chart.sql: if getattr(chart, "sql", None):
result = self._parse_lineage_from_dataset_sql(chart) result = self._parse_lineage_from_dataset_sql(chart)
else: else:
result = [ result = [
@ -339,7 +339,7 @@ class SupersetSourceMixin(DashboardServiceSource):
except Exception as exc: except Exception as exc:
yield Either( yield Either(
left=StackTraceError( left=StackTraceError(
name=db_service_name, name="Dashboard Lineage Details",
error=( error=(
"Error to yield dashboard lineage details for DB " "Error to yield dashboard lineage details for DB "
f"service name [{db_service_name}]: {exc}" f"service name [{db_service_name}]: {exc}"