yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-12-16 10:08:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix the activity feed flaky playwright test (#21942)

Browse Source
This commit is contained in:
Ashish Gupta 2025-06-25 16:05:43 +05:30 committed by GitHub
parent 392f081255
commit b99071b82c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts
View File

@ -169,7 +169,9 @@ test.describe('Activity feed', () => {
await page.getByTestId('request-entity-tags').click(); await page.getByTestId('request-entity-tags').click();
// create tag task // create tag task
const openTaskAfterTagResponse = page.waitForResponse(TASK_OPEN_FETCH_LINK);
await createTagTask(page, { ...value, tag: 'PII.None' }); await createTagTask(page, { ...value, tag: 'PII.None' });
await openTaskAfterTagResponse;
await redirectToHomePage(page); await redirectToHomePage(page);
@ -583,11 +585,14 @@ test.describe('Activity feed', () => {
// Create task for the user 1 // Create task for the user 1
await page2.getByTestId('request-entity-tags').click(); await page2.getByTestId('request-entity-tags').click();
const openTaskAfterTagResponse =
page2.waitForResponse(TASK_OPEN_FETCH_LINK);
await createTagTask(page2, { await createTagTask(page2, {
term: entity.entity.displayName, term: entity.entity.displayName,
tag: 'PII.None', tag: 'PII.None',
assignee: user1.responseData.name, assignee: user1.responseData.name,
}); });
await openTaskAfterTagResponse;
await redirectToHomePage(page2); await redirectToHomePage(page2);
const taskResponse = page2.waitForResponse( const taskResponse = page2.waitForResponse(
@ -737,7 +742,10 @@ base.describe('Activity feed with Data Consumer User', () => {
await page1.getByTestId('request-entity-tags').click(); await page1.getByTestId('request-entity-tags').click();
// create tag task // create tag task
const openTaskAfterTagResponse =
page1.waitForResponse(TASK_OPEN_FETCH_LINK);
await createTagTask(page1, { ...value, tag: 'PII.None' }); await createTagTask(page1, { ...value, tag: 'PII.None' });
await openTaskAfterTagResponse;
// Should only see the close button // Should only see the close button
expect(page1.locator('[data-testid="close-button"]')).toBeVisible(); expect(page1.locator('[data-testid="close-button"]')).toBeVisible();
@ -854,7 +862,10 @@ base.describe('Activity feed with Data Consumer User', () => {
await page1.getByTestId('request-entity-tags').click(); await page1.getByTestId('request-entity-tags').click();
// create tag task // create tag task
const openTaskAfterTagResponse =
page1.waitForResponse(TASK_OPEN_FETCH_LINK);
await createTagTask(page1, value, false); await createTagTask(page1, value, false);
await openTaskAfterTagResponse;
await page1.waitForLoadState('networkidle'); await page1.waitForLoadState('networkidle');

2
openmetadata-ui/src/main/resources/ui/playwright/utils/task.ts
View File

@ -146,7 +146,9 @@ export const createTagTask = async (
await clickOutside(page); await clickOutside(page);
} }
const taskResponse = page.waitForResponse(`/api/v1/feed`);
await page.click('button[type="submit"]'); await page.click('button[type="submit"]');
await taskResponse;
await toastNotification(page, /Task created successfully./); await toastNotification(page, /Task created successfully./);
}; };