Fix #7909: Remove ElasticSearch configs from tests (#7910)

openmetadata-service/src/main/java/org/openmetadata/service/resources/elasticSearch/BuildSearchIndexResource.java

@@ -80,21 +80,25 @@ public class BuildSearchIndexResource {
   public static final String ELASTIC_SEARCH_EXTENSION = "service.eventPublisher";
   public static final String ELASTIC_SEARCH_ENTITY_FQN_STREAM = "eventPublisher:ElasticSearch:STREAM";
   public static final String ELASTIC_SEARCH_ENTITY_FQN_BATCH = "eventPublisher:ElasticSearch:BATCH";
-  private final RestHighLevelClient client;
+  private RestHighLevelClient client;
-  private final ElasticSearchIndexDefinition elasticSearchIndexDefinition;
+  private ElasticSearchIndexDefinition elasticSearchIndexDefinition;
   private final CollectionDAO dao;
   private final Authorizer authorizer;
   private final ExecutorService threadScheduler;
 
   public BuildSearchIndexResource(CollectionDAO dao, Authorizer authorizer) {
-    this.client =
+    if (ConfigurationHolder.getInstance()
-        ElasticSearchClientUtils.createElasticSearchClient(
+            .getConfig(ConfigurationHolder.ConfigurationType.ELASTICSEARCH_CONFIG, ElasticSearchConfiguration.class)
-            ConfigurationHolder.getInstance()
+        != null) {
-                .getConfig(
+      this.client =
-                    ConfigurationHolder.ConfigurationType.ELASTICSEARCH_CONFIG, ElasticSearchConfiguration.class));
+          ElasticSearchClientUtils.createElasticSearchClient(
+              ConfigurationHolder.getInstance()
+                  .getConfig(
+                      ConfigurationHolder.ConfigurationType.ELASTICSEARCH_CONFIG, ElasticSearchConfiguration.class));
+      this.elasticSearchIndexDefinition = new ElasticSearchIndexDefinition(client, dao);
+    }
     this.dao = dao;
     this.authorizer = authorizer;
-    this.elasticSearchIndexDefinition = new ElasticSearchIndexDefinition(client, dao);
     this.threadScheduler =
         new ThreadPoolExecutor(
             2, 2, 0L, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<>(5), new ThreadPoolExecutor.CallerRunsPolicy());

openmetadata-service/src/main/java/org/openmetadata/service/resources/teams/UserResource.java

@@ -798,14 +798,14 @@ public class UserResource extends EntityResource<User, UserRepository> {
           sendEmailVerification(uriInfo, registeredUser);
         } catch (Exception e) {
           LOG.error("Error in sending mail to the User : {}", e.getMessage());
-          return Response.status(424).entity(new ErrorMessage(424, EMAIL_SENDING_ISSUE)).build();
+          return Response.status(424, EMAIL_SENDING_ISSUE).build();
         }
       }
-      return Response.status(Response.Status.CREATED).entity("User Registration Successful.").build();
+      return Response.status(Response.Status.CREATED.getStatusCode(), "User Registration Successful.")
-    } else {
+          .entity(registeredUser)
-      return Response.status(Response.Status.BAD_REQUEST)
-          .entity(new ErrorMessage(400, "Signup is not Available"))
           .build();
+    } else {
+      return Response.status(Response.Status.BAD_REQUEST.getStatusCode(), "Signup is not available").build();
     }
   }
 

openmetadata-service/src/main/java/org/openmetadata/service/util/ConfigurationHolder.java

@@ -62,7 +62,9 @@ public class ConfigurationHolder {
                 CONFIG_MAP.put(ConfigurationType.SMTP_CONFIG, config.getSmtpSettings());
                 break;
               case ELASTICSEARCH_CONFIG:
-                CONFIG_MAP.put(ConfigurationType.ELASTICSEARCH_CONFIG, config.getElasticSearchConfiguration());
+                if (config.getElasticSearchConfiguration() != null) {
+                  CONFIG_MAP.put(ConfigurationType.ELASTICSEARCH_CONFIG, config.getElasticSearchConfiguration());
+                }
                 break;
               case LOGIN_CONFIG:
                 CONFIG_MAP.put(ConfigurationType.LOGIN_CONFIG, config.getLoginSettings());

openmetadata-service/src/test/java/org/openmetadata/service/OpenMetadataApplicationTest.java

@@ -85,6 +85,7 @@ public abstract class OpenMetadataApplicationTest {
             ConfigOverride.config("database.password", SQL_CONTAINER.getPassword()),
             // Migration overrides
             ConfigOverride.config("migrationConfiguration.path", migrationScripsLocation));
+
     APP.before();
   }
 

openmetadata-service/src/test/resources/openmetadata-secure-test.yaml

@@ -182,18 +182,6 @@ email:
   password: ""
   transportationStrategy: "SMTP_TLS"
 
-elasticsearch:
-  host: "localhost"
-  port: "9200"
-  scheme: "http"
-  username: ""
-  password: ""
-  truststorePath: ""
-  truststorePassword: ""
-  connectionTimeoutSecs: 5
-  socketTimeoutSecs: 60
-  batchSize: 10
-
 slackChat:
   slackUrl: "http://localhost:8080"