yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-04 04:29:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update PR template (#10700)

Browse Source 
* Update PR template

* Update PR template
This commit is contained in:
Pere Miquel Brull 2023-03-22 16:50:13 +01:00 committed by GitHub
parent f15a752706
commit ba7690f14e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 47 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
.github/pull_request_template.md vendored
View File

@ -1,34 +1,58 @@
### Describe your changes : <!--
<!-- Explain what you have done & tag your assigned issue !--> Thank you for your contribution!
I worked on the ..... because ... Unless your change is trivial, please create an issue to discuss the change before creating a PR.
-->
### Describe your changes:
Fixes <issue-number>
<!--
Short blurb explaining:
- What changes did you make?
- Why did you make them?
- How did you test your changes?
-->
I worked on ... because ...
<!-- For frontend related change, please add screenshots and/or videos of your changes preview! -->
# #
### Type of change : ### Type of change:
<!-- You should choose 1 option and delete options that aren't relevant --> <!-- You should choose 1 option and delete options that aren't relevant -->
- [x] Bug fix - [ ] Bug fix
- [x] Improvement - [ ] Improvement
- [x] New feature - [ ] New feature
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation - [ ] Documentation
#
### Frontend Preview (Screenshots) :
<p align="center">For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.
</p>
# #
### Checklist: ### Checklist:
<!-- add an x in [] if done, don't mark items that you didn't do !--> <!-- add an x in [] if done, don't mark items that you didn't do !-->
- [x] I have read the [**CONTRIBUTING**](https://docs.open-metadata.org/developers/contribute) document. - [x] I have read the [**CONTRIBUTING**](https://docs.open-metadata.org/developers/contribute) document.
- [ ] My PR title is `Fixes <issue-number>: <short explanation>`
- [ ] I have commented on my code, particularly in hard-to-understand areas. - [ ] I have commented on my code, particularly in hard-to-understand areas.
- [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
- [x] All new and existing tests passed.
# <!-- Based on the type(s) of your change, uncomment the required checklist 👇 -->
### Reviewers
<!-- Please see the contributing guidelines and then add your reviewer(s) !--> <!-- Bug fix
<!--- OpenMetadata community thanks you for explaining your changes in detail !--> - [ ] I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.
<!--- If you are unsure of people to review your work, you can add anyone of these developers :) !--> -->
<!--- Frontend: @open-metadata/ui -->
<!--- Backend: @open-metadata/backend --> <!-- Improvement
<!--- Ingestion: @open-metadata/ingestion --> - [ ] I have added tests around the new logic.
- [ ] For connector/ingestion changes: I updated the documentation.
-->
<!-- New feature
- [ ] The issue properly describes why the new feature is needed, what's the goal, and how we are building it. Any discussion
or decision-making process is reflected in the issue.
- [ ] I have updated the documentation.
- [ ] I have added tests around the new logic.
-->
<!-- Breaking change
- [ ] I have added the tag `Backward-Incompatible-Change`.
-->