Remove existing entity source hash presence check (#21621)

This commit is contained in:
Mohit Tilala 2025-06-08 12:37:51 +05:30 committed by Mohit Tilala
parent 30be77e03a
commit ba8716bf8a

View File

@ -393,32 +393,31 @@ class TopologyRunnerMixin(Generic[C]):
if entity is None and stage.use_cache: if entity is None and stage.use_cache:
# check if we find the entity in the entities list # check if we find the entity in the entities list
entity_source_hash = self.cache[stage.type_].get(entity_fqn) entity_source_hash = self.cache[stage.type_].get(entity_fqn)
if entity_source_hash: # if the source hash is not present or different from new hash, update the entity
# if the source hash is present, compare it with new hash # if overrideMetadata is true, we will always update the entity
# if overrideMetadata is true, we will always update the entity if (
if ( entity_source_hash != create_entity_request_hash
entity_source_hash != create_entity_request_hash or self.source_config.overrideMetadata
or self.source_config.overrideMetadata ):
): # the entity has changed, get the entity from server and make a patch request
# the entity has changed, get the entity from server and make a patch request entity = self.metadata.get_by_name(
entity = self.metadata.get_by_name( entity=stage.type_,
entity=stage.type_, fqn=entity_fqn,
fqn=entity_fqn, fields=["*"],
fields=["*"], )
)
# we return the entity for a patch update # we return the entity for a patch update
if entity: if entity:
patch_entity = self.create_patch_request( patch_entity = self.create_patch_request(
original_entity=entity, create_request=entity_request.right original_entity=entity, create_request=entity_request.right
)
entity_request.right = patch_entity
else:
# nothing has changed on the source skip the API call
logger.debug(
f"No changes detected for {str(stage.type_.__name__)} '{entity_fqn}'"
) )
same_fingerprint = True entity_request.right = patch_entity
else:
# nothing has changed on the source skip the API call
logger.debug(
f"No changes detected for {str(stage.type_.__name__)} '{entity_fqn}'"
)
same_fingerprint = True
if not same_fingerprint: if not same_fingerprint:
# We store the generated source hash and yield the request # We store the generated source hash and yield the request