Issue 4660: Bigquery ADC FIx (#5241)

* fixed-bigquery-adc
This commit is contained in:
Abhishek Pandey 2022-06-01 13:52:55 +05:30 committed by GitHub
parent 6ca9b816bd
commit ba88aa1668
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 5 deletions

View File

@ -20,6 +20,9 @@ from metadata.generated.schema.security.credentials.gcsCredentials import (
GCSCredentialsPath,
GCSValues,
)
from metadata.utils.logger import utils_logger
logger = utils_logger()
GOOGLE_CREDENTIALS = "GOOGLE_APPLICATION_CREDENTIALS"
@ -54,7 +57,11 @@ def set_google_credentials(gcs_credentials: GCSCredentials) -> None:
if isinstance(gcs_credentials.gcsConfig, GCSCredentialsPath):
os.environ[GOOGLE_CREDENTIALS] = str(gcs_credentials.gcsConfig.__root__)
return
if gcs_credentials.gcsConfig.projectId is None:
logger.info(
"No credentials available, using the current environment permissions authenticated via gcloud SDK ."
)
return
if isinstance(gcs_credentials.gcsConfig, GCSValues):
credentials_dict = {
"type": gcs_credentials.gcsConfig.type,

View File

@ -91,8 +91,5 @@
]
}
},
"additionalProperties": false,
"required": [
"gcsConfig"
]
"additionalProperties": false
}