diff --git a/ingestion/src/metadata/ingestion/source/dashboard/qliksense/client.py b/ingestion/src/metadata/ingestion/source/dashboard/qliksense/client.py index 538b5e8f8d2..77724c05207 100644 --- a/ingestion/src/metadata/ingestion/source/dashboard/qliksense/client.py +++ b/ingestion/src/metadata/ingestion/source/dashboard/qliksense/client.py @@ -73,6 +73,7 @@ class QlikSenseClient: "ca_certs": self.config.certificates.rootCertificate, "certfile": self.config.certificates.clientCertificate, "keyfile": self.config.certificates.clientKeyCertificate, + "check_hostname": self.config.validateHostName, } return context diff --git a/ingestion/src/metadata/utils/ssl_manager.py b/ingestion/src/metadata/utils/ssl_manager.py index 2993b04a08d..319957fb7eb 100644 --- a/ingestion/src/metadata/utils/ssl_manager.py +++ b/ingestion/src/metadata/utils/ssl_manager.py @@ -124,11 +124,12 @@ class SSLManager: return connection @setup_ssl.register(QlikSenseConnection) - def _(self, _): + def _(self, connection): return { "ca_certs": self.ca_file_path, "certfile": self.cert_file_path, "keyfile": self.key_file_path, + "check_hostname": connection.validateHostName, } @setup_ssl.register(KafkaConnection) diff --git a/openmetadata-docs/content/v1.4.x-SNAPSHOT/connectors/dashboard/qliksense/index.md b/openmetadata-docs/content/v1.4.x-SNAPSHOT/connectors/dashboard/qliksense/index.md index 2fe9b055a3d..b8de7485b22 100644 --- a/openmetadata-docs/content/v1.4.x-SNAPSHOT/connectors/dashboard/qliksense/index.md +++ b/openmetadata-docs/content/v1.4.x-SNAPSHOT/connectors/dashboard/qliksense/index.md @@ -82,6 +82,8 @@ You will have to replace new lines with `\n` and the final private key that you **User ID**: This field specifies the user id of the user. +**Validate Host Name**: Enable/Disable this field to validate the host name against the provided certificates. + {% /extraContent %} {% partial file="/v1.4/connectors/test-connection.md" /%} diff --git a/openmetadata-docs/content/v1.4.x-SNAPSHOT/connectors/dashboard/qliksense/yaml.md b/openmetadata-docs/content/v1.4.x-SNAPSHOT/connectors/dashboard/qliksense/yaml.md index 6aa067169ce..36c8008163c 100644 --- a/openmetadata-docs/content/v1.4.x-SNAPSHOT/connectors/dashboard/qliksense/yaml.md +++ b/openmetadata-docs/content/v1.4.x-SNAPSHOT/connectors/dashboard/qliksense/yaml.md @@ -130,6 +130,12 @@ You will have to replace new lines with `\n` and the final private key that you {% /codeInfo %} +{% codeInfo srNumber=7 %} + +**validateHostName**: Enable/Disable this field to validate the host name against the provided certificates. + +{% /codeInfo %} + {% partial file="/v1.4/connectors/yaml/dashboard/source-config-def.md" /%} {% partial file="/v1.4/connectors/yaml/ingestion-sink-def.md" /%} @@ -174,7 +180,9 @@ source: ```yaml {% srNumber=6 %} userDirectory: user_dir ``` - +```yaml {% srNumber=6 %} + validateHostName: false +``` {% partial file="/v1.4/connectors/yaml/dashboard/source-config.md" /%} {% partial file="/v1.4/connectors/yaml/ingestion-sink.md" /%} diff --git a/openmetadata-spec/src/main/resources/json/schema/entity/services/connections/dashboard/qlikSenseConnection.json b/openmetadata-spec/src/main/resources/json/schema/entity/services/connections/dashboard/qlikSenseConnection.json index b6deb1755e1..784379f3ca4 100644 --- a/openmetadata-spec/src/main/resources/json/schema/entity/services/connections/dashboard/qlikSenseConnection.json +++ b/openmetadata-spec/src/main/resources/json/schema/entity/services/connections/dashboard/qlikSenseConnection.json @@ -86,6 +86,12 @@ } ] }, + "validateHostName": { + "title": "Validate Host Name", + "description": "Validate Host Name", + "type": "boolean", + "default": false + }, "userDirectory": { "title": "User Directory", "description": "User Directory.", diff --git a/openmetadata-ui/src/main/resources/ui/public/locales/en-US/Dashboard/QlikSense.md b/openmetadata-ui/src/main/resources/ui/public/locales/en-US/Dashboard/QlikSense.md index 51d6944086f..61646ae705a 100644 --- a/openmetadata-ui/src/main/resources/ui/public/locales/en-US/Dashboard/QlikSense.md +++ b/openmetadata-ui/src/main/resources/ui/public/locales/en-US/Dashboard/QlikSense.md @@ -153,4 +153,11 @@ $$section ### User ID $(id="userId") This field specifies the user id of the user. +$$ + + +$$section +### Validate Host Name $(id="validateHostName") + +Enable/Disable this field to validate the host name against the provided certificates. $$ \ No newline at end of file