From c0a0c0430620b7208598b99d6afd385ffb7ee9b6 Mon Sep 17 00:00:00 2001 From: Alberto Miorin <32617+amiorin@users.noreply.github.com> Date: Thu, 6 Jan 2022 11:27:19 +0100 Subject: [PATCH] Fix #2058: Reformat a few Java files left for good (#2072) --- .../catalog/resources/events/WebhookResourceTest.java | 3 +-- .../resources/services/DashboardServiceResourceTest.java | 3 +-- .../catalog/resources/teams/RoleResourceTest.java | 3 +-- .../catalog/resources/teams/TeamResourceTest.java | 3 +-- .../catalog/resources/teams/UserResourceTest.java | 6 ++---- .../selenium/pages/common/PaginationAndFilterTest.java | 9 +++++---- .../catalog/selenium/pages/myData/MyDataPageTest.java | 4 ++-- 7 files changed, 13 insertions(+), 18 deletions(-) diff --git a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/events/WebhookResourceTest.java b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/events/WebhookResourceTest.java index ef33b1a1ef8..ecdf7b438b5 100644 --- a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/events/WebhookResourceTest.java +++ b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/events/WebhookResourceTest.java @@ -66,8 +66,7 @@ public class WebhookResourceTest extends EntityResourceTest { } @Test - void post_webhookEnabledStateChange(TestInfo test) - throws URISyntaxException, IOException, InterruptedException { + void post_webhookEnabledStateChange(TestInfo test) throws URISyntaxException, IOException, InterruptedException { // // Create webhook in disabled state. It will not start webhook publisher // diff --git a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/services/DashboardServiceResourceTest.java b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/services/DashboardServiceResourceTest.java index 95b12038104..a6424267857 100644 --- a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/services/DashboardServiceResourceTest.java +++ b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/services/DashboardServiceResourceTest.java @@ -216,8 +216,7 @@ public class DashboardServiceResourceTest extends EntityResourceTest authHeaders = adminAuthHeaders(); DashboardService dashboardService = createEntity(create(test), authHeaders); deleteEntity(dashboardService.getId(), authHeaders); diff --git a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/RoleResourceTest.java b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/RoleResourceTest.java index 1f55a58c66f..821c36cca07 100644 --- a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/RoleResourceTest.java +++ b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/RoleResourceTest.java @@ -110,8 +110,7 @@ public class RoleResourceTest extends EntityResourceTest { } @Test - void patch_roleAttributes_as_non_admin_403(TestInfo test) - throws HttpResponseException, JsonProcessingException { + void patch_roleAttributes_as_non_admin_403(TestInfo test) throws HttpResponseException, JsonProcessingException { // Create table without any attributes Role role = createRole(create(test), adminAuthHeaders()); // Patching as a non-admin should is disallowed diff --git a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/TeamResourceTest.java b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/TeamResourceTest.java index 861fa975d69..0cc78dfa0b4 100644 --- a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/TeamResourceTest.java +++ b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/TeamResourceTest.java @@ -229,8 +229,7 @@ public class TeamResourceTest extends EntityResourceTest { // } @Test - void patch_teamAttributes_as_non_admin_403(TestInfo test) - throws HttpResponseException, JsonProcessingException { + void patch_teamAttributes_as_non_admin_403(TestInfo test) throws HttpResponseException, JsonProcessingException { // Create table without any attributes Team team = createTeam(create(test), adminAuthHeaders()); // Patching as a non-admin should is disallowed diff --git a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/UserResourceTest.java b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/UserResourceTest.java index 352a236f65e..45976943cf9 100644 --- a/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/UserResourceTest.java +++ b/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/teams/UserResourceTest.java @@ -276,8 +276,7 @@ public class UserResourceTest extends EntityResourceTest { * @see TableResourceTest also tests GET user returns owns list */ @Test - void patch_userNameChange_as_another_user_401(TestInfo test) - throws HttpResponseException, JsonProcessingException { + void patch_userNameChange_as_another_user_401(TestInfo test) throws HttpResponseException, JsonProcessingException { // Ensure username can't be changed using patch User user = createUser( @@ -305,8 +304,7 @@ public class UserResourceTest extends EntityResourceTest { } @Test - void patch_userNameChange_as_same_user_200_ok(TestInfo test) - throws HttpResponseException, JsonProcessingException { + void patch_userNameChange_as_same_user_200_ok(TestInfo test) throws HttpResponseException, JsonProcessingException { // Ensure username can't be changed using patch User user = createUser( diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PaginationAndFilterTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PaginationAndFilterTest.java index 417f5347432..07b639854d3 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PaginationAndFilterTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PaginationAndFilterTest.java @@ -166,9 +166,7 @@ public class PaginationAndFilterTest { Events.sendKeys(webDriver, By.cssSelector("[data-testid='searchBox']"), "dim_api_client"); Events.click(webDriver, By.cssSelector("[data-testid='data-name']")); Thread.sleep(waitTime); - actions - .moveToElement(webDriver.findElement(By.xpath("//div[@data-testid='tag-conatiner']//span"))) - .perform(); + actions.moveToElement(webDriver.findElement(By.xpath("//div[@data-testid='tag-conatiner']//span"))).perform(); Events.click(webDriver, By.xpath("//div[@data-testid='tag-conatiner']//span")); Events.click(webDriver, By.cssSelector("[data-testid='associatedTagName']")); for (int i = 0; i <= 4; i++) { @@ -181,7 +179,10 @@ public class PaginationAndFilterTest { Events.click(webDriver, By.cssSelector("[data-testid='checkbox'][id='shopify']")); Thread.sleep(2000); Object filteredResults = webDriver.findElements(By.xpath("//div[@data-testid='search-results']/div")).size(); - String databaseCount = webDriver.findElement(By.xpath("//div[@data-testid='filter-container-shopify']//span[@data-testid='filter-count']")).getAttribute("innerHTML"); + String databaseCount = + webDriver + .findElement(By.xpath("//div[@data-testid='filter-container-shopify']//span[@data-testid='filter-count']")) + .getAttribute("innerHTML"); Assert.assertEquals(databaseCount, filteredResults); } diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/myData/MyDataPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/myData/MyDataPageTest.java index eec8a1dc5b7..f3d6d29b7ea 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/myData/MyDataPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/myData/MyDataPageTest.java @@ -200,8 +200,8 @@ public class MyDataPageTest { Events.click(webDriver, By.cssSelector("[data-testid='image']")); Thread.sleep(2000); try { - WebElement spaceSearch = wait.until(ExpectedConditions.presenceOfElementLocated( - By.cssSelector("[data-testid='Recently-Search- ']"))); + WebElement spaceSearch = + wait.until(ExpectedConditions.presenceOfElementLocated(By.cssSelector("[data-testid='Recently-Search- ']"))); if (spaceSearch.isDisplayed()) { throw new Exception("Spaces are captured in Recent Search"); }