mirror of
https://github.com/open-metadata/OpenMetadata.git
synced 2025-07-13 20:18:24 +00:00
fix: user selectable list popover issues (#10799)
* fix: user selectable list popover issues * fix: skip glossary tests * fix: team cypress tests --------- Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
This commit is contained in:
parent
42000053aa
commit
c1cbee3d1b
@ -902,8 +902,6 @@ export const updateOwner = () => {
|
||||
// Clicking on edit owner button
|
||||
cy.get('[data-testid="add-user"]').should('be.visible').click();
|
||||
|
||||
verifyResponseStatusCode('@getUsers', 200);
|
||||
|
||||
cy.get('[data-testid="selectable-list"]')
|
||||
.find(`[title="${text.trim()}"]`)
|
||||
.click();
|
||||
|
@ -15,7 +15,7 @@ import Loader from 'components/Loader/Loader';
|
||||
import { ADD_USER_CONTAINER_HEIGHT, pagingObject } from 'constants/constants';
|
||||
import { EntityReference } from 'generated/entity/data/table';
|
||||
import { Paging } from 'generated/type/paging';
|
||||
import { cloneDeep } from 'lodash';
|
||||
import { cloneDeep, isEmpty } from 'lodash';
|
||||
import VirtualList from 'rc-virtual-list';
|
||||
import React, { UIEventHandler, useCallback, useEffect, useState } from 'react';
|
||||
import { useTranslation } from 'react-i18next';
|
||||
@ -98,13 +98,21 @@ export const SelectableList = ({
|
||||
fetchListOptions();
|
||||
}, []);
|
||||
|
||||
const handleSearch = async (search: string) => {
|
||||
const handleSearch = useCallback(
|
||||
async (search: string) => {
|
||||
const { data, paging } = await fetchOptions(search);
|
||||
|
||||
setUniqueOptions(data);
|
||||
setUniqueOptions(
|
||||
isEmpty(search)
|
||||
? sortUniqueListFromSelectedList(selectedItemsInternal, data)
|
||||
: data
|
||||
);
|
||||
|
||||
setPagingInfo(paging);
|
||||
setSearchText(search);
|
||||
};
|
||||
},
|
||||
[selectedItemsInternal]
|
||||
);
|
||||
|
||||
const onScroll: UIEventHandler<HTMLElement> = async (e) => {
|
||||
if (
|
||||
@ -150,6 +158,10 @@ export const SelectableList = ({
|
||||
onUpdate([]);
|
||||
};
|
||||
|
||||
const handleClearAllClick = () => {
|
||||
setSelectedItemInternal(new Map());
|
||||
};
|
||||
|
||||
return (
|
||||
<List
|
||||
data-testid="selectable-list"
|
||||
@ -160,7 +172,7 @@ export const SelectableList = ({
|
||||
color="primary"
|
||||
size="small"
|
||||
type="text"
|
||||
onClick={handleRemoveClick}>
|
||||
onClick={handleClearAllClick}>
|
||||
{t('label.clear-entity', { entity: t('label.all-lowercase') })}
|
||||
</Button>
|
||||
<Space className="m-l-auto text-right">
|
||||
|
@ -46,7 +46,7 @@ export const UserSelectableList = ({
|
||||
searchText,
|
||||
1,
|
||||
PAGE_SIZE_MEDIUM,
|
||||
'',
|
||||
'isBot:false',
|
||||
'',
|
||||
'',
|
||||
SearchIndex.USER
|
||||
@ -70,7 +70,9 @@ export const UserSelectableList = ({
|
||||
? {
|
||||
after,
|
||||
}
|
||||
: undefined
|
||||
: undefined,
|
||||
undefined,
|
||||
false
|
||||
);
|
||||
const filterData = getEntityReferenceListFromEntities(
|
||||
data,
|
||||
|
@ -14,6 +14,7 @@
|
||||
@update-btn-hover-bg: #e2e2e2;
|
||||
|
||||
.user-select-popover {
|
||||
min-width: 275px;
|
||||
.ant-popover-inner-content {
|
||||
padding: 0;
|
||||
}
|
||||
|
@ -54,7 +54,7 @@ export const UserTeamSelectableList = ({
|
||||
searchText,
|
||||
1,
|
||||
PAGE_SIZE_MEDIUM,
|
||||
'',
|
||||
'isBot:false',
|
||||
'',
|
||||
'',
|
||||
SearchIndex.USER
|
||||
@ -79,7 +79,9 @@ export const UserTeamSelectableList = ({
|
||||
? {
|
||||
after,
|
||||
}
|
||||
: undefined
|
||||
: undefined,
|
||||
undefined,
|
||||
false
|
||||
);
|
||||
const filterData = getEntityReferenceListFromEntities(
|
||||
data,
|
||||
|
@ -29,6 +29,7 @@
|
||||
box-shadow: 1px 1px 3px rgba(0, 0, 0, 0.12);
|
||||
border-radius: 6px;
|
||||
padding: 0;
|
||||
min-width: 275px;
|
||||
|
||||
.ant-popover-inner {
|
||||
box-shadow: none;
|
||||
|
Loading…
x
Reference in New Issue
Block a user