yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-24 17:08:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Fix: close select dropdown when focus is shifted (#19764)" (#19838)

Browse Source 
This reverts commit 7b495072e094d71c9248225723ff5a3abd0479af.
This commit is contained in:
Karan Hotchandani 2025-02-17 19:33:19 +05:30 committed by GitHub
parent 50f05f32dc
commit c1e895aca8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 0 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Entity.spec.ts
View File

@ -40,7 +40,6 @@ import {
import { CustomPropertyTypeByName } from '../../utils/customProperty'; import { CustomPropertyTypeByName } from '../../utils/customProperty';
import { import {
addMultiOwner, addMultiOwner,
dropdownVisibility,
removeOwner, removeOwner,
removeOwnersFromList, removeOwnersFromList,
} from '../../utils/entity'; } from '../../utils/entity';
@ -220,14 +219,6 @@ entities.forEach((EntityClass) => {
); );
}); });
test("Tags and Glossary Term dropdown shouldn't be visible on tab change", async ({
page,
}) => {
await dropdownVisibility(page, 'tags');
await page.getByRole('tablist').getByRole('tab').first().click();
await dropdownVisibility(page, 'glossary');
});
// Run only if entity has children // Run only if entity has children
if (!isUndefined(entity.childrenTabId)) { if (!isUndefined(entity.childrenTabId)) {
test('Tag Add, Update and Remove for child entities', async ({ test('Tag Add, Update and Remove for child entities', async ({

18
openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts
View File

@ -709,24 +709,6 @@ export const removeGlossaryTermFromChildren = async ({
} }
}; };
export const dropdownVisibility = async (page: Page, tagType: string) => {
await page
.getByTestId('entity-right-panel')
.getByTestId(`${tagType}-container`)
.getByTestId('add-tag')
.click();
await page.waitForSelector(
'.ant-select-dropdown [data-testid="saveAssociatedTag"]',
{ state: 'visible' }
);
await expect(page.getByTestId('saveAssociatedTag')).toBeVisible();
await page.getByTestId('activity_feed').click();
await expect(page.getByTestId('saveAssociatedTag')).not.toBeVisible();
};
export const upVote = async (page: Page, endPoint: string) => { export const upVote = async (page: Page, endPoint: string) => {
const patchRequest = page.waitForResponse(`/api/v1/${endPoint}/*/vote`); const patchRequest = page.waitForResponse(`/api/v1/${endPoint}/*/vote`);

1
openmetadata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/AsyncSelectList.tsx
View File

@ -315,7 +315,6 @@ const AsyncSelectList: FC<AsyncSelectListProps & SelectProps> = ({
style={{ width: '100%' }} style={{ width: '100%' }}
tagRender={customTagRender} tagRender={customTagRender}
onChange={handleChange} onChange={handleChange}
onDropdownVisibleChange={(open) => !open && onCancel?.()}
onInputKeyDown={(event) => { onInputKeyDown={(event) => {
if (event.key === 'Backspace') { if (event.key === 'Backspace') {
return event.stopPropagation(); return event.stopPropagation();

1
openmetadata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/TreeAsyncSelectList.tsx
View File

@ -328,7 +328,6 @@ const TreeAsyncSelectList: FC<Omit<AsyncSelectListProps, 'fetchOptions'>> = ({
treeData={treeData} treeData={treeData}
treeExpandedKeys={isEmpty(searchOptions) ? undefined : expandedRowKeys} treeExpandedKeys={isEmpty(searchOptions) ? undefined : expandedRowKeys}
onChange={handleChange} onChange={handleChange}
onDropdownVisibleChange={(open) => !open && onCancel?.()}
onSearch={onSearch} onSearch={onSearch}
onTreeExpand={setExpandedRowKeys} onTreeExpand={setExpandedRowKeys}
{...props} {...props}