yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-01 13:13:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: liuve update logical test suite aggregation in search (#18978)

Browse Source
This commit is contained in:
Teddy 2024-12-09 20:36:08 +01:00 committed by GitHub
parent 83f094e286
commit c3455aae91
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 21 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/TestCaseRepository.java
View File

@ -274,24 +274,30 @@ public class TestCaseRepository extends EntityRepository<TestCase> {
} }
@Override @Override
protected void postDelete(TestCase test) { protected void postDelete(TestCase testCase) {
super.postDelete(test); super.postDelete(testCase);
// Update test suite with new test case in search index updateTestSuite(testCase);
TestSuiteRepository testSuiteRepository =
(TestSuiteRepository) Entity.getEntityRepository(Entity.TEST_SUITE);
TestSuite testSuite = Entity.getEntity(test.getTestSuite(), "*", ALL);
TestSuite original = TestSuiteRepository.copyTestSuite(testSuite);
testSuiteRepository.postUpdate(original, testSuite);
deleteTestCaseFailedRowsSample(test.getId());
} }
@Override @Override
protected void postCreate(TestCase test) { protected void postCreate(TestCase testCase) {
super.postCreate(test); super.postCreate(testCase);
// Update test suite with new test case in search index updateTestSuite(testCase);
}
private void updateTestSuite(TestCase testCase) {
// Update test suite with updated test case in search index
TestSuiteRepository testSuiteRepository = TestSuiteRepository testSuiteRepository =
(TestSuiteRepository) Entity.getEntityRepository(Entity.TEST_SUITE); (TestSuiteRepository) Entity.getEntityRepository(Entity.TEST_SUITE);
TestSuite testSuite = Entity.getEntity(test.getTestSuite(), "*", ALL); TestSuite testSuite = Entity.getEntity(testCase.getTestSuite(), "*", ALL);
TestSuite original = TestSuiteRepository.copyTestSuite(testSuite);
testSuiteRepository.postUpdate(original, testSuite);
}
private void updateLogicalTestSuite(UUID testSuiteId) {
TestSuiteRepository testSuiteRepository =
(TestSuiteRepository) Entity.getEntityRepository(Entity.TEST_SUITE);
TestSuite testSuite = Entity.getEntity(Entity.TEST_SUITE, testSuiteId, "*", ALL);
TestSuite original = TestSuiteRepository.copyTestSuite(testSuite); TestSuite original = TestSuiteRepository.copyTestSuite(testSuite);
testSuiteRepository.postUpdate(original, testSuite); testSuiteRepository.postUpdate(original, testSuite);
} }
@ -465,6 +471,7 @@ public class TestCaseRepository extends EntityRepository<TestCase> {
testCase.setChangeDescription(change); testCase.setChangeDescription(change);
postUpdate(testCase, testCase); postUpdate(testCase, testCase);
} }
updateLogicalTestSuite(testSuite.getId());
return new RestUtil.PutResponse<>(Response.Status.OK, testSuite, LOGICAL_TEST_CASE_ADDED); return new RestUtil.PutResponse<>(Response.Status.OK, testSuite, LOGICAL_TEST_CASE_ADDED);
} }
@ -483,6 +490,7 @@ public class TestCaseRepository extends EntityRepository<TestCase> {
.withNewValue(updatedTestCase.getTestSuites()))); .withNewValue(updatedTestCase.getTestSuites())));
updatedTestCase.setChangeDescription(change); updatedTestCase.setChangeDescription(change);
postUpdate(testCase, updatedTestCase); postUpdate(testCase, updatedTestCase);
updateLogicalTestSuite(testSuiteId);
testCase.setTestSuite(updatedTestCase.getTestSuite()); testCase.setTestSuite(updatedTestCase.getTestSuite());
testCase.setTestSuites(updatedTestCase.getTestSuites()); testCase.setTestSuites(updatedTestCase.getTestSuites());
return new RestUtil.DeleteResponse<>(testCase, ENTITY_DELETED); return new RestUtil.DeleteResponse<>(testCase, ENTITY_DELETED);