From c39d949ccda5db73af2a993845ddd81d953bc073 Mon Sep 17 00:00:00 2001 From: Harshit Shah Date: Wed, 6 Aug 2025 21:31:24 +0530 Subject: [PATCH] Fix glossary tab and chart icon issue for persona (#22793) (cherry picked from commit 51b826b06ba27734fe81c9d0ca4a16fc7faefd92) --- .../GlossaryTerms/GlossaryTermsV1.component.tsx | 10 +++------- .../resources/ui/src/utils/Persona/PersonaUtils.ts | 2 ++ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryTerms/GlossaryTermsV1.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryTerms/GlossaryTermsV1.component.tsx index 5d3d0afc1ad..6edb630d492 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryTerms/GlossaryTermsV1.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryTerms/GlossaryTermsV1.component.tsx @@ -83,7 +83,7 @@ const GlossaryTermsV1 = ({ isTabExpanded, toggleTabExpanded, }: GlossaryTermsV1Props) => { - const { tab, version } = useRequiredParams<{ + const { tab: activeTab, version } = useRequiredParams<{ tab: EntityTabs; version: string; }>(); @@ -109,10 +109,6 @@ const GlossaryTermsV1 = ({ : MOCK_GLOSSARY_NO_PERMISSIONS; }, [glossaryTerm, permissions]); - const activeTab = useMemo(() => { - return tab ?? EntityTabs.OVERVIEW; - }, [tab]); - const activeTabHandler = (tab: string) => { navigate( { @@ -162,8 +158,8 @@ const GlossaryTermsV1 = ({ const handleAssetSave = useCallback(() => { fetchGlossaryTermAssets(); assetTabRef.current?.refreshAssets(); - tab !== 'assets' && activeTabHandler('assets'); - }, [assetTabRef, tab]); + activeTab !== 'assets' && activeTabHandler('assets'); + }, [assetTabRef, activeTab]); const onExtensionUpdate = useCallback( async (updatedTable: GlossaryTerm) => { diff --git a/openmetadata-ui/src/main/resources/ui/src/utils/Persona/PersonaUtils.ts b/openmetadata-ui/src/main/resources/ui/src/utils/Persona/PersonaUtils.ts index 43c7d52bdb6..37027319796 100644 --- a/openmetadata-ui/src/main/resources/ui/src/utils/Persona/PersonaUtils.ts +++ b/openmetadata-ui/src/main/resources/ui/src/utils/Persona/PersonaUtils.ts @@ -13,6 +13,7 @@ import { camelCase, map, startCase } from 'lodash'; import { ReactComponent as APICollectionIcon } from '../../assets/svg/api-collection-colored.svg'; import { ReactComponent as APIEndpointIcon } from '../../assets/svg/api-endpoints-colored.svg'; +import { ReactComponent as ChartIcon } from '../../assets/svg/chart-colored.svg'; import { ReactComponent as DashboardIcon } from '../../assets/svg/dashboard-colored-new.svg'; import { ReactComponent as DashboardDataModelIcon } from '../../assets/svg/dashboard-data-models-colored.svg'; import { ReactComponent as DataAssetsIcon } from '../../assets/svg/data-assets-colored-new.svg'; @@ -37,6 +38,7 @@ import i18n from '../i18next/LocalUtil'; const ENTITY_ICONS: Record = { [PageType.Table]: TableIcon, + [PageType.Chart]: ChartIcon, [PageType.Container]: StorageIcon, [PageType.Dashboard]: DashboardIcon, [PageType.DashboardDataModel]: DashboardDataModelIcon,