From c41482c9361c69c5be3807c38d6e6ff4df4b50ab Mon Sep 17 00:00:00 2001 From: Ashish Gupta Date: Tue, 7 Oct 2025 10:22:09 +0530 Subject: [PATCH] PLAYWRIGHT: fix the flaky test around tags and activity feed (#23750) --- .../e2e/Features/ActivityFeed.spec.ts | 2 +- .../main/resources/ui/playwright/utils/tag.ts | 19 +++++++++++++++++-- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts index 0db627c7971..67875dec3fe 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts @@ -444,7 +444,7 @@ test.describe('Mention notifications in Notification Box', () => { let count = 0; let iterations = 0; - const maxIterations = 10; + const maxIterations = 20; const delayMs = 5000; while (iterations < maxIterations) { diff --git a/openmetadata-ui/src/main/resources/ui/playwright/utils/tag.ts b/openmetadata-ui/src/main/resources/ui/playwright/utils/tag.ts index 7261cb30bec..803320555da 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/utils/tag.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/utils/tag.ts @@ -490,9 +490,24 @@ export const fillTagForm = async (adminPage: Page, domain: Domain) => { await adminPage.click( '[data-testid="modal-container"] [data-testid="add-domain"]' ); + + const searchDomain = adminPage.waitForResponse( + `/api/v1/search/query?q=*${encodeURIComponent(domain.responseData.name)}*` + ); + await adminPage - .getByTestId(`tag-${domain.responseData.fullyQualifiedName}`) - .click(); + .getByTestId('domain-selectable-tree') + .getByTestId('searchbar') + .fill(domain.responseData.name); + + await searchDomain; + + // Wait for the tag element to be visible and ensure page is still valid + const tagSelector = adminPage.getByTestId( + `tag-${domain.responseData.fullyQualifiedName}` + ); + await tagSelector.waitFor({ state: 'visible' }); + await tagSelector.click(); await adminPage.getByTestId('saveAssociatedTag').click(); };