yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-07-26 10:50:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

from print_exc to format_exc, resolves sonar cloud code smell (#4611)

Browse Source
This commit is contained in:
Ayush Shah 2022-05-02 16:09:59 +05:30 committed by GitHub
parent 792c67a8f1
commit c674408dbb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
17 changed files with 27 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ingestion/src/metadata/cli/docker.py
View File

@ -185,7 +185,6 @@ def run_docker(
) )
except Exception as err: except Exception as err:
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.debug(traceback.print_exc())
click.secho(str(err), fg="red") click.secho(str(err), fg="red")

2
ingestion/src/metadata/ingestion/ometa/auth_provider.py
View File

@ -243,7 +243,7 @@ class OktaAuthenticationProvider(AuthenticationProvider):
self.expiry = response_dict.get(EXPIRY) self.expiry = response_dict.get(EXPIRY)
except Exception as err: except Exception as err:
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.error(err) logger.error(err)
sys.exit() sys.exit()

2
ingestion/src/metadata/ingestion/ometa/mixins/lineage_mixin.py
View File

@ -210,7 +210,7 @@ class OMetaLineageMixin(Generic[T]):
logger.info(f"Successfully added Lineage {created_lineage}") logger.info(f"Successfully added Lineage {created_lineage}")
except Exception as err: except Exception as err:
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.error(err) logger.error(err)
def ingest_lineage_by_query( def ingest_lineage_by_query(

3
ingestion/src/metadata/ingestion/processor/query_parser.py
View File

@ -13,6 +13,7 @@ Query parser implementation
""" """
import datetime import datetime
import traceback
from typing import Optional from typing import Optional
from sql_metadata import Parser from sql_metadata import Parser
@ -91,7 +92,9 @@ class QueryParserProcessor(Processor):
) )
# pylint: disable=broad-except # pylint: disable=broad-except
except Exception as err: except Exception as err:
if hasattr(record, "sql"):
logger.debug(record.sql) logger.debug(record.sql)
logger.debug(traceback.format_exc())
logger.error(err) logger.error(err)
query_parser_data = None query_parser_data = None

2
ingestion/src/metadata/ingestion/sink/elasticsearch.py
View File

@ -266,7 +266,7 @@ class ElasticsearchSink(Sink[Entity]):
self.status.records_written(record.name.__root__) self.status.records_written(record.name.__root__)
except Exception as e: except Exception as e:
logger.error(f"Failed to index entity {record} due to {e}") logger.error(f"Failed to index entity {record} due to {e}")
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
def _create_table_es_doc(self, table: Table): def _create_table_es_doc(self, table: Table):
fqdn = table.fullyQualifiedName.__root__ fqdn = table.fullyQualifiedName.__root__

9
ingestion/src/metadata/ingestion/sink/metadata_rest.py
View File

@ -252,7 +252,7 @@ class MetadataRestSink(Sink[Entity]):
db_schema_and_table.database.name.__root__, db_schema_and_table.database.name.__root__,
) )
) )
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.error(err) logger.error(err)
self.status.failure(f"Table: {db_schema_and_table.table.name.__root__}") self.status.failure(f"Table: {db_schema_and_table.table.name.__root__}")
@ -378,7 +378,7 @@ class MetadataRestSink(Sink[Entity]):
except (APIError, ValidationError) as err: except (APIError, ValidationError) as err:
logger.error(f"Failed to ingest Policy {ometa_policy.policy.name}") logger.error(f"Failed to ingest Policy {ometa_policy.policy.name}")
logger.error(err) logger.error(err)
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
self.status.failure(f"Policy: {ometa_policy.policy.name}") self.status.failure(f"Policy: {ometa_policy.policy.name}")
def _create_location(self, location: Location) -> Location: def _create_location(self, location: Location) -> Location:
@ -420,7 +420,6 @@ class MetadataRestSink(Sink[Entity]):
return role return role
except Exception as err: except Exception as err:
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.debug(traceback.print_exc())
logger.error(err) logger.error(err)
def _create_team(self, create_team: CreateTeamRequest) -> Team: def _create_team(self, create_team: CreateTeamRequest) -> Team:
@ -430,7 +429,6 @@ class MetadataRestSink(Sink[Entity]):
return team return team
except Exception as err: except Exception as err:
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.debug(traceback.print_exc())
logger.error(err) logger.error(err)
def write_users(self, record: OMetaUserProfile): def write_users(self, record: OMetaUserProfile):
@ -494,7 +492,6 @@ class MetadataRestSink(Sink[Entity]):
logger.info("User: {}".format(user.displayName)) logger.info("User: {}".format(user.displayName))
except Exception as err: except Exception as err:
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.debug(traceback.print_exc())
logger.error(err) logger.error(err)
def delete_table(self, record: DeleteTable): def delete_table(self, record: DeleteTable):
@ -505,7 +502,6 @@ class MetadataRestSink(Sink[Entity]):
) )
except Exception as err: except Exception as err:
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.debug(traceback.print_exc())
logger.error(err) logger.error(err)
def write_table_tests(self, record: OMetaTableTest) -> None: def write_table_tests(self, record: OMetaTableTest) -> None:
@ -532,7 +528,6 @@ class MetadataRestSink(Sink[Entity]):
self.status.records_written(f"Table Tests: {record.table_name}.{test}") self.status.records_written(f"Table Tests: {record.table_name}.{test}")
except Exception as err: except Exception as err:
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.debug(traceback.print_exc())
logger.error(err) logger.error(err)
def create_lineage_via_es(self, db_schema_and_table, db_schema, db): def create_lineage_via_es(self, db_schema_and_table, db_schema, db):

5
ingestion/src/metadata/ingestion/source/dynamodb.py
View File

@ -65,7 +65,6 @@ class DynamodbSource(Source[Entity]):
yield from self.ingest_tables() yield from self.ingest_tables()
except Exception as err: except Exception as err:
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.debug(traceback.print_exc())
logger.error(err) logger.error(err)
def ingest_tables(self, next_tables_token=None) -> Iterable[OMetaDatabaseAndTable]: def ingest_tables(self, next_tables_token=None) -> Iterable[OMetaDatabaseAndTable]:
@ -107,7 +106,7 @@ class DynamodbSource(Source[Entity]):
yield table_and_db yield table_and_db
except Exception as err: except Exception as err:
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.error(err) logger.error(err)
def get_columns(self, column_data): def get_columns(self, column_data):
@ -127,7 +126,7 @@ class DynamodbSource(Source[Entity]):
yield Column(**parsed_string) yield Column(**parsed_string)
except Exception as err: except Exception as err:
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.error(err) logger.error(err)
def close(self): def close(self):

2
ingestion/src/metadata/ingestion/source/glue.py
View File

@ -226,7 +226,6 @@ class GlueSource(Source[Entity]):
yield from self.ingest_tables(glue_resp["NextToken"]) yield from self.ingest_tables(glue_resp["NextToken"])
except Exception as err: except Exception as err:
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.debug(traceback.print_exc())
logger.error(err) logger.error(err)
def get_downstream_tasks(self, task_unique_id, tasks): def get_downstream_tasks(self, task_unique_id, tasks):
@ -283,7 +282,6 @@ class GlueSource(Source[Entity]):
yield pipeline_ev yield pipeline_ev
except Exception as err: except Exception as err:
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.debug(traceback.print_exc())
logger.error(err) logger.error(err)
def close(self): def close(self):

2
ingestion/src/metadata/ingestion/source/looker.py
View File

@ -143,7 +143,7 @@ class LookerSource(Source[Entity]):
try: try:
yield from self._get_dashboard_elements(iter_chart) yield from self._get_dashboard_elements(iter_chart)
except Exception as err: except Exception as err:
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.error(err) logger.error(err)
yield Dashboard( yield Dashboard(
name=dashboard.id, name=dashboard.id,

4
ingestion/src/metadata/ingestion/source/metabase.py
View File

@ -158,7 +158,7 @@ class MetabaseSource(Source[Entity]):
self.status.scanned(chart_details["name"]) self.status.scanned(chart_details["name"])
except Exception as err: # pylint: disable=broad-except except Exception as err: # pylint: disable=broad-except
logger.error(repr(err)) logger.error(repr(err))
traceback.print_exc() logger.debug(traceback.format_exc())
continue continue
def get_dashboards(self): def get_dashboards(self):
@ -233,7 +233,7 @@ class MetabaseSource(Source[Entity]):
) )
yield lineage yield lineage
except Exception as err: # pylint: disable=broad-except,unused-variable except Exception as err: # pylint: disable=broad-except,unused-variable
logger.error(traceback.print_exc()) logger.error(traceback.format_exc())
def req_get(self, path): def req_get(self, path):
"""Send get request method """Send get request method

4
ingestion/src/metadata/ingestion/source/powerbi.py
View File

@ -128,7 +128,7 @@ class PowerbiSource(Source[Entity]):
self.charts.append(chart["id"]) self.charts.append(chart["id"])
self.status.scanned(chart["title"]) self.status.scanned(chart["title"])
except Exception as err: # pylint: disable=broad-except except Exception as err: # pylint: disable=broad-except
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.error(repr(err)) logger.error(repr(err))
self.status.failure(chart["title"], err) self.status.failure(chart["title"], err)
@ -165,7 +165,7 @@ class PowerbiSource(Source[Entity]):
), ),
) )
except Exception as err: except Exception as err:
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.error(err) logger.error(err)
self.status.failure(dashboard_details["displayName"], err) self.status.failure(dashboard_details["displayName"], err)

4
ingestion/src/metadata/ingestion/source/sample_data.py
View File

@ -473,7 +473,7 @@ class SampleDataSource(Source[Entity]):
} }
sql_object["user"] = EntityReference(**user_dict, type="user") sql_object["user"] = EntityReference(**user_dict, type="user")
except Exception as err: except Exception as err:
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.debug(err) logger.debug(err)
table_metadata = Table(**table) table_metadata = Table(**table)
table_and_db = OMetaDatabaseAndTable( table_and_db = OMetaDatabaseAndTable(
@ -589,7 +589,7 @@ class SampleDataSource(Source[Entity]):
) )
yield model_ev yield model_ev
except Exception as err: except Exception as err:
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.error(err) logger.error(err)
def ingest_users(self) -> Iterable[OMetaUserProfile]: def ingest_users(self) -> Iterable[OMetaUserProfile]:

2
ingestion/src/metadata/ingestion/source/snowflake_usage.py
View File

@ -119,7 +119,7 @@ class SnowflakeUsageSource(Source[TableQuery]):
self.report.scanned(f"{row['database_name']}") self.report.scanned(f"{row['database_name']}")
yield table_query yield table_query
except Exception as err: except Exception as err:
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.debug(repr(err)) logger.debug(repr(err))
def get_report(self): def get_report(self):

10
ingestion/src/metadata/ingestion/source/sql_source.py
View File

@ -184,7 +184,7 @@ class SQLSource(Source[OMetaDatabaseAndTable]):
self.source_config.enableDataProfiler = False self.source_config.enableDataProfiler = False
except Exception as exc: # pylint: disable=broad-except except Exception as exc: # pylint: disable=broad-except
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.debug(f"Error running ingestion profiler {repr(exc)}") logger.debug(f"Error running ingestion profiler {repr(exc)}")
return None return None
@ -359,7 +359,7 @@ class SQLSource(Source[OMetaDatabaseAndTable]):
yield table_schema_and_db yield table_schema_and_db
except Exception as err: except Exception as err:
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.error(err) logger.error(err)
self.status.failures.append( self.status.failures.append(
"{}.{}".format(self.config.serviceName, table_name) "{}.{}".format(self.config.serviceName, table_name)
@ -501,7 +501,7 @@ class SQLSource(Source[OMetaDatabaseAndTable]):
model_fqdn = f"{schema}.{model_name}".lower() model_fqdn = f"{schema}.{model_name}".lower()
self.data_models[model_fqdn] = model self.data_models[model_fqdn] = model
except Exception as err: except Exception as err:
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.error(err) logger.error(err)
def _parse_data_model_upstream(self, mnode): def _parse_data_model_upstream(self, mnode):
@ -771,12 +771,12 @@ class SQLSource(Source[OMetaDatabaseAndTable]):
) )
] ]
except Exception as err: except Exception as err:
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.error(err) logger.error(err)
om_column = col_dict om_column = col_dict
except Exception as err: except Exception as err:
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.error(f"{err} : {column}") logger.error(f"{err} : {column}")
continue continue
table_columns.append(om_column) table_columns.append(om_column)

2
ingestion/src/metadata/ingestion/source/superset.py
View File

@ -301,7 +301,7 @@ class SupersetSource(Source[Entity]):
yield lineage yield lineage
except Exception as err: except Exception as err:
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
logger.error(err) logger.error(err)
# pylint: disable=too-many-locals # pylint: disable=too-many-locals

2
ingestion/src/metadata/orm_profiler/profiler/core.py
View File

@ -289,7 +289,7 @@ class Profiler(Generic[MetricType]):
except (TimeoutError, Exception) as err: # pylint: disable=broad-except except (TimeoutError, Exception) as err: # pylint: disable=broad-except
print(err) print(err)
print(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.error( logger.error(
f"Error computing query metric {metric.name()} for {self.table.__tablename__}.{col.name} - {err}" f"Error computing query metric {metric.name()} for {self.table.__tablename__}.{col.name} - {err}"
) )

2
ingestion/src/metadata/orm_profiler/sink/metadata_rest.py
View File

@ -91,5 +91,5 @@ class MetadataRestSink(Sink[Entity]):
logger.error( logger.error(
f"Failed to sink profiler & test data for {record.table.fullyQualifiedName.__root__} - {err}" f"Failed to sink profiler & test data for {record.table.fullyQualifiedName.__root__} - {err}"
) )
logger.debug(traceback.print_exc()) logger.debug(traceback.format_exc())
self.status.failure(f"Table: {record.table.fullyQualifiedName.__root__}") self.status.failure(f"Table: {record.table.fullyQualifiedName.__root__}")