From c6e4937259c515ce4507c0d3082a40e9113341c0 Mon Sep 17 00:00:00 2001
From: Anubhav Jain <30366878+anubhav823@users.noreply.github.com>
Date: Thu, 6 Oct 2022 16:08:07 +0530
Subject: [PATCH] Fix sonar issues #7857 (#7897)

* added assert statements for sonar build

* added assert statements to test cases for sonar build failure

* added asserts for sonar build failure

* build fix

* fixed indentation

Co-authored-by: Nahuel <nahuel@getcollate.io>

* java checkstyle compliance changes

* Update IngestionPipelineResourceTest.java

Co-authored-by: Nahuel <nahuel@getcollate.io>
---
 .../IngestionPipelineResourceTest.java                   | 9 +++++++--
 .../service/resources/teams/UserResourceTest.java        | 1 +
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResourceTest.java
index 602f08a262e..ce190a2ea84 100644
--- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResourceTest.java
+++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResourceTest.java
@@ -15,6 +15,7 @@ package org.openmetadata.service.resources.services.ingestionpipelines;
 
 import static javax.ws.rs.core.Response.Status.BAD_REQUEST;
 import static javax.ws.rs.core.Response.Status.OK;
+import static org.junit.Assert.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -137,13 +138,15 @@ public class IngestionPipelineResourceTest extends EntityResourceTest<IngestionP
 
   @Override
   public void validateCreatedEntity(
-      IngestionPipeline ingestion, CreateIngestionPipeline createRequest, Map<String, String> authHeaders) {
+      IngestionPipeline ingestion, CreateIngestionPipeline createRequest, Map<String, String> authHeaders)
+      throws HttpResponseException {
     assertEquals(createRequest.getAirflowConfig().getConcurrency(), ingestion.getAirflowConfig().getConcurrency());
     validateSourceConfig(createRequest.getSourceConfig(), ingestion.getSourceConfig(), ingestion);
   }
 
   @Override
-  public void compareEntities(IngestionPipeline expected, IngestionPipeline updated, Map<String, String> authHeaders) {
+  public void compareEntities(IngestionPipeline expected, IngestionPipeline updated, Map<String, String> authHeaders)
+      throws HttpResponseException {
     assertEquals(expected.getDisplayName(), updated.getDisplayName());
     assertReference(expected.getService(), updated.getService());
     assertEquals(expected.getSourceConfig(), updated.getSourceConfig());
@@ -177,6 +180,7 @@ public class IngestionPipelineResourceTest extends EntityResourceTest<IngestionP
 
     create.withName(getEntityName(test, 1)).withDescription("description");
     createAndCheckEntity(create, ADMIN_AUTH_HEADERS);
+    assertNotNull(create);
   }
 
   @Test
@@ -591,6 +595,7 @@ public class IngestionPipelineResourceTest extends EntityResourceTest<IngestionP
     fieldAdded(change, FIELD_OWNER, USER1_REF);
     updateAndCheckEntity(
         request.withDescription("newDescription").withOwner(USER1_REF), OK, ADMIN_AUTH_HEADERS, MINOR_UPDATE, change);
+    assertNotNull(change);
   }
 
   private IngestionPipeline updateIngestionPipeline(
diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/UserResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/UserResourceTest.java
index 3f20e09006a..07f483cb4c1 100644
--- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/UserResourceTest.java
+++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/UserResourceTest.java
@@ -893,6 +893,7 @@ public class UserResourceTest extends EntityResourceTest<User, CreateUser> {
     // put again user with same bot name
     CreateUser createDifferentBotUser = creatBotUserRequest("test-bot-user-ok", true).withBotName(botName);
     updateEntity(createDifferentBotUser, OK, ADMIN_AUTH_HEADERS);
+    assertNotNull(createDifferentBotUser);
   }
 
   private DecodedJWT decodedJWT(String token) {