From c88ac0dd5c2f89b31e247678dff8c80499d68a7d Mon Sep 17 00:00:00 2001 From: Shailesh Parmar Date: Thu, 10 Aug 2023 11:33:08 +0530 Subject: [PATCH] ui: replace encodeURI with encodeURIComponent in entity details page (#12827) --- .../src/main/resources/ui/cypress/constants/constants.js | 7 +++++++ .../ui/cypress/e2e/Flow/AddAndRemoveTierAndOwner.spec.js | 2 +- .../ui/src/pages/TableDetailsPageV1/TableDetailsPageV1.tsx | 4 ++-- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/cypress/constants/constants.js b/openmetadata-ui/src/main/resources/ui/cypress/constants/constants.js index cfdc4e2d5ea..072b0d9ab7a 100644 --- a/openmetadata-ui/src/main/resources/ui/cypress/constants/constants.js +++ b/openmetadata-ui/src/main/resources/ui/cypress/constants/constants.js @@ -83,6 +83,13 @@ export const SEARCH_ENTITY_TABLE = { serviceName: 'sample_data', entityType: 'Table', }, + table_5: { + term: 'dim.api/client', + displayName: 'dim.api/client', + entity: MYDATA_SUMMARY_OPTIONS.tables, + serviceName: 'sample_data', + entityType: 'Table', + }, }; export const SEARCH_ENTITY_TOPIC = { diff --git a/openmetadata-ui/src/main/resources/ui/cypress/e2e/Flow/AddAndRemoveTierAndOwner.spec.js b/openmetadata-ui/src/main/resources/ui/cypress/e2e/Flow/AddAndRemoveTierAndOwner.spec.js index 466060a7349..c025b5bfde1 100644 --- a/openmetadata-ui/src/main/resources/ui/cypress/e2e/Flow/AddAndRemoveTierAndOwner.spec.js +++ b/openmetadata-ui/src/main/resources/ui/cypress/e2e/Flow/AddAndRemoveTierAndOwner.spec.js @@ -29,7 +29,7 @@ import { const ENTITIES = { table: { - ...SEARCH_ENTITY_TABLE.table_4, + ...SEARCH_ENTITY_TABLE.table_5, schema: 'shopify', database: 'ecommerce_db', }, diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/TableDetailsPageV1/TableDetailsPageV1.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/TableDetailsPageV1/TableDetailsPageV1.tsx index c0dcb5cab59..2970b94657f 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/TableDetailsPageV1/TableDetailsPageV1.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/TableDetailsPageV1/TableDetailsPageV1.tsx @@ -127,9 +127,9 @@ const TableDetailsPageV1 = () => { ); const tableFqn = useMemo( () => - encodeURI( + encodeURIComponent( getPartialNameFromTableFQN( - decodeURI(datasetFQN), + decodeURIComponent(datasetFQN), [FqnPart.Service, FqnPart.Database, FqnPart.Schema, FqnPart.Table], FQN_SEPARATOR_CHAR )