MINOR: Fix e2e tests (#15829)

* Update values

* Update values

* Fix checkstyle
This commit is contained in:
IceS2 2024-04-08 15:58:32 +02:00 committed by GitHub
parent c3c5a81b55
commit c909ff8857
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 19 additions and 19 deletions

View File

@ -70,10 +70,10 @@ class MetabaseCliTest(CliCommonDashboard.TestSuite):
return 0 return 0
def expected_filtered_mix(self) -> int: def expected_filtered_mix(self) -> int:
return 3 return 4
def expected_filtered_sink_mix(self) -> int: def expected_filtered_sink_mix(self) -> int:
return 6 return 7
def expected_dashboards_and_charts_after_patch(self) -> int: def expected_dashboards_and_charts_after_patch(self) -> int:
return 0 return 0

View File

@ -124,15 +124,15 @@ SELECT * from names
@staticmethod @staticmethod
def expected_filtered_table_includes() -> int: def expected_filtered_table_includes() -> int:
return 42 return 43
@staticmethod @staticmethod
def expected_filtered_table_excludes() -> int: def expected_filtered_table_excludes() -> int:
return 28 return 29
@staticmethod @staticmethod
def expected_filtered_mix() -> int: def expected_filtered_mix() -> int:
return 42 return 43
def test_create_table_with_profiler(self) -> None: def test_create_table_with_profiler(self) -> None:
# delete table in case it exists # delete table in case it exists
@ -251,16 +251,16 @@ SELECT * from names
def assert_for_vanilla_ingestion( def assert_for_vanilla_ingestion(
self, source_status: Status, sink_status: Status self, source_status: Status, sink_status: Status
) -> None: ) -> None:
self.assertTrue(len(source_status.failures) == 0) self.assertEqual(len(source_status.failures), 0)
self.assertTrue(len(source_status.warnings) == 0) self.assertEqual(len(source_status.warnings), 0)
self.assertTrue(len(source_status.filtered) == 28) self.assertEqual(len(source_status.filtered), 29)
self.assertTrue( self.assertGreaterEqual(
(len(source_status.records) + len(source_status.updated_records)) (len(source_status.records) + len(source_status.updated_records)),
>= self.expected_tables() self.expected_tables(),
) )
self.assertTrue(len(sink_status.failures) == 0) self.assertEqual(len(sink_status.failures), 0)
self.assertTrue(len(sink_status.warnings) == 0) self.assertEqual(len(sink_status.warnings), 0)
self.assertTrue( self.assertGreater(
(len(sink_status.records) + len(sink_status.updated_records)) (len(sink_status.records) + len(sink_status.updated_records)),
> self.expected_tables() self.expected_tables(),
) )

View File

@ -71,7 +71,7 @@ class TableauCliTest(CliCommonDashboard.TestSuite):
return 2 return 2
def expected_filtered_sink_mix(self) -> int: def expected_filtered_sink_mix(self) -> int:
return 9 return 10
def expected_dashboards_and_charts_after_patch(self) -> int: def expected_dashboards_and_charts_after_patch(self) -> int:
return 2 return 4