filter empty columns, better msg (#18932)

This commit is contained in:
harshsoni2024 2024-12-05 13:05:58 +05:30 committed by GitHub
parent 00e5d299b9
commit c941569a9e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -383,8 +383,11 @@ class TableauSource(DashboardServiceSource):
column=column.id, column=column.id,
) )
for to_column in to_columns: for to_column in to_columns:
if from_column and to_column:
column_lineage.append( column_lineage.append(
ColumnLineage(fromColumns=[from_column], toColumn=to_column) ColumnLineage(
fromColumns=[from_column], toColumn=to_column
)
) )
return column_lineage return column_lineage
except Exception as exc: except Exception as exc:
@ -452,6 +455,7 @@ class TableauSource(DashboardServiceSource):
column.id column.id
for field in upstream_data_model.fields for field in upstream_data_model.fields
for column in field.upstreamColumns for column in field.upstreamColumns
if column is not None
} }
for table in datamodel.upstreamTables or []: for table in datamodel.upstreamTables or []:
om_tables = self._get_database_tables(db_service_entity, table) om_tables = self._get_database_tables(db_service_entity, table)
@ -889,6 +893,9 @@ class TableauSource(DashboardServiceSource):
try: try:
return dashboard_details.project.name return dashboard_details.project.name
except Exception as exc: except Exception as exc:
logger.info(
f"Cannot parse project name for dashboard:{dashboard_details.id} from Tableau server"
)
logger.debug(traceback.format_exc()) logger.debug(traceback.format_exc())
logger.warning( logger.warning(
f"Error fetching project name for {dashboard_details.id}: {exc}" f"Error fetching project name for {dashboard_details.id}: {exc}"