Minor: Bug fixes and improvements (#16323)

* Fix the flaky observability alert cypress tests

* Add glossary entity Creation details object in EntityConstant file for cypress

* Fix the icons in observability alert destination options

---------

Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
This commit is contained in:
Aniket Katkar 2024-05-17 19:45:37 +05:30 committed by GitHub
parent 868d83d5c1
commit c9f3b4a2cd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 38 additions and 7 deletions

View File

@ -53,7 +53,9 @@ export const addOwnerFilter = (
cy.get('[data-testid="owner-name-select"]').click().type(ownerName); cy.get('[data-testid="owner-name-select"]').click().type(ownerName);
verifyResponseStatusCode('@getSearchResult', 200); verifyResponseStatusCode('@getSearchResult', 200);
cy.get(`[title="${ownerName}"]`).filter(':visible').scrollIntoView().click(); cy.get(`[title="${ownerName}"]`).filter(':visible').scrollIntoView().click();
cy.get('[data-testid="owner-name-select"]').should('contain', ownerName); cy.get(`[data-testid="owner-name-select"] [title="${ownerName}"]`).should(
'exist'
);
if (exclude) { if (exclude) {
// Change filter effect // Change filter effect
@ -82,7 +84,9 @@ export const addEntityFQNFilter = (
cy.get('[data-testid="fqn-list-select"]').click().type(entityFQN); cy.get('[data-testid="fqn-list-select"]').click().type(entityFQN);
verifyResponseStatusCode('@getSearchResult', 200); verifyResponseStatusCode('@getSearchResult', 200);
cy.get(`[title="${entityFQN}"]`).filter(':visible').scrollIntoView().click(); cy.get(`[title="${entityFQN}"]`).filter(':visible').scrollIntoView().click();
cy.get(`[title="${entityFQN}"] [aria-label="check"]`).should('exist'); cy.get(`[data-testid="fqn-list-select"] [title="${entityFQN}"]`).should(
'exist'
);
if (exclude) { if (exclude) {
// Change filter effect // Change filter effect
@ -170,7 +174,9 @@ export const addDomainFilter = (
cy.get('[data-testid="domain-select"]').click().type(domainName); cy.get('[data-testid="domain-select"]').click().type(domainName);
verifyResponseStatusCode('@getSearchResult', 200); verifyResponseStatusCode('@getSearchResult', 200);
cy.get(`[title="${domainName}"]`).filter(':visible').scrollIntoView().click(); cy.get(`[title="${domainName}"]`).filter(':visible').scrollIntoView().click();
cy.get('[data-testid="domain-select"]').should('contain', domainName); cy.get(`[data-testid="domain-select"] [title="${domainName}"]`).should(
'exist'
);
if (exclude) { if (exclude) {
// Change filter effect // Change filter effect

View File

@ -463,3 +463,14 @@ export const TEAM_CREATION_DETAILS = {
name: `0%team-name-${uuid()}`, name: `0%team-name-${uuid()}`,
teamType: 'Group', teamType: 'Group',
}; };
export const GLOSSARY_DETAILS = {
name: `0%glossary-${uuid()}`,
description: 'glossary description',
};
export const GLOSSARY_TERM_DETAILS = {
name: `0%glossary-term-${uuid()}`,
glossary: GLOSSARY_DETAILS.name,
description: 'glossary term description',
};

View File

@ -423,7 +423,7 @@ describe(
// Check if option is selected // Check if option is selected
cy.get( cy.get(
`[title="${filter.inputValue}"] .ant-select-item-option-state` `[data-testid="${filter.inputSelector}"] [title="${filter.inputValue}"]`
).should('exist'); ).should('exist');
if (filter.exclude) { if (filter.exclude) {

View File

@ -16,11 +16,15 @@ import React from 'react';
import { ReactComponent as AdminIcon } from '../assets/svg/admin-colored-icon.svg'; import { ReactComponent as AdminIcon } from '../assets/svg/admin-colored-icon.svg';
import { ReactComponent as GChatIcon } from '../assets/svg/gchat.svg'; import { ReactComponent as GChatIcon } from '../assets/svg/gchat.svg';
import { ReactComponent as MentionIcon } from '../assets/svg/ic-mentions.svg'; import { ReactComponent as MentionIcon } from '../assets/svg/ic-mentions.svg';
import { ReactComponent as FollowingIcon } from '../assets/svg/ic-star.svg';
import { ReactComponent as MSTeamsIcon } from '../assets/svg/ms-teams.svg'; import { ReactComponent as MSTeamsIcon } from '../assets/svg/ms-teams.svg';
import { ReactComponent as SlackIcon } from '../assets/svg/slack.svg'; import { ReactComponent as SlackIcon } from '../assets/svg/slack.svg';
import { ReactComponent as TeamIcon } from '../assets/svg/team-colored-icon.svg'; import { ReactComponent as TeamIcon } from '../assets/svg/team-colored-icon.svg';
import { ReactComponent as UserIcon } from '../assets/svg/user-colored-icon.svg'; import { ReactComponent as UserIcon } from '../assets/svg/user-colored-icon.svg';
import { ReactComponent as AssigneeIcon } from '../assets/svg/user.svg'; import {
ReactComponent as AssigneeIcon,
ReactComponent as OwnerIcon,
} from '../assets/svg/user.svg';
import { ReactComponent as GenericIcon } from '../assets/svg/webhook.svg'; import { ReactComponent as GenericIcon } from '../assets/svg/webhook.svg';
import { SubscriptionCategory } from '../generated/events/eventSubscription'; import { SubscriptionCategory } from '../generated/events/eventSubscription';
@ -60,15 +64,25 @@ export const getAlertDestinationCategoryIcons = (type: string) => {
Icon = MailOutlined; Icon = MailOutlined;
break; break;
case 'MsTeams': case 'MsTeams':
case 'Followers':
Icon = MSTeamsIcon; Icon = MSTeamsIcon;
break; break;
case 'Followers':
Icon = FollowingIcon;
break;
case 'Webhook': case 'Webhook':
case 'Owners':
Icon = GenericIcon; Icon = GenericIcon;
break;
case 'Owners':
Icon = OwnerIcon;
break; break;
} }