yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-04 05:16:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve test case form loading and structure in AddTestCaseNewFlow (#23068)

Browse Source 
(cherry picked from commit 1e5d2c92680a47a4e02b1ad16e8acd0d9aab5d45)
This commit is contained in:
Shailesh Parmar 2025-08-23 09:30:52 +05:30 committed by OpenMetadata Release Bot
parent 75a2ae5b9f
commit ca8610314d
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataQuality/AddTestCaseNewFlow.spec.ts
View File

@ -172,6 +172,10 @@ test.describe('Add TestCase New Flow', () => {
await selectTable(page, table1.entity.name); await selectTable(page, table1.entity.name);
await page.click('#testCaseFormV1_selectedColumn'); await page.click('#testCaseFormV1_selectedColumn');
await page.waitForLoadState('networkidle');
await page.waitForSelector(
`.ant-select-dropdown [title="${table1.entity.columns[0].name}"]`
);
await page await page
.locator( .locator(
`.ant-select-dropdown [title="${table1.entity.columns[0].name}"]` `.ant-select-dropdown [title="${table1.entity.columns[0].name}"]`

9
openmetadata-ui/src/main/resources/ui/src/components/DataQuality/AddDataQualityTest/components/TestCaseFormV1.tsx
View File

@ -1038,6 +1038,7 @@ const TestCaseFormV1: FC<TestCaseFormV1Props> = ({
api={fetchTables} api={fetchTables}
disabled={Boolean(table)} disabled={Boolean(table)}
getPopupContainer={getPopupContainer} getPopupContainer={getPopupContainer}
notFoundContent={undefined}
placeholder={t('label.select-entity', { placeholder={t('label.select-entity', {
entity: t('label.table'), entity: t('label.table'),
})} })}
@ -1073,10 +1074,6 @@ const TestCaseFormV1: FC<TestCaseFormV1Props> = ({
)} )}
</Card> </Card>
<Card className="form-card-section" data-testid="test-details-card">
{generateFormFields(testDetailsFormFields)}
</Card>
<Card className="form-card-section" data-testid="test-type-card"> <Card className="form-card-section" data-testid="test-type-card">
<Form.Item className="custom-select-test-type-style m-b-md"> <Form.Item className="custom-select-test-type-style m-b-md">
{selectedTestLevel === TestLevel.TABLE && ( {selectedTestLevel === TestLevel.TABLE && (
@ -1172,6 +1169,10 @@ const TestCaseFormV1: FC<TestCaseFormV1Props> = ({
generateFormFields(computeRowCountField)} generateFormFields(computeRowCountField)}
</Card> </Card>
<Card className="form-card-section" data-testid="test-details-card">
{generateFormFields(testDetailsFormFields)}
</Card>
{shouldShowScheduler && ( {shouldShowScheduler && (
<Row gutter={[20, 20]}> <Row gutter={[20, 20]}>
<Col span={24}> <Col span={24}>